Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1635698pxb; Wed, 9 Feb 2022 00:45:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFyvkh9LOETCu7iBiPpAVmUu/U9m03tNRME6NUAfgA58WJPqwPJSmqmheIYhCKWPU9e/5C X-Received: by 2002:a17:90a:9e5:: with SMTP id 92mr1389683pjo.128.1644396302577; Wed, 09 Feb 2022 00:45:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644396302; cv=none; d=google.com; s=arc-20160816; b=kIvvGba3H5chcWvSvJ0GUUoP9LvmrO3VrE2izXHvU6xT5/+Z0q5aG+qgu22zZf9p4l 4vlirl7tRXo+jShLBGGwIfl1w/nw1LF/jAoHmBNr1fjVs/aqvxXYYzS/EhwFL5KxqtX7 sWKEsz+qUYGgySaBalSoXc/24Xo6Ng8JL+fjy2C+o9ria495haiCt+pqE/UUjLTwMlj9 gWXgCPmtQSfztqhdDfaSzTnp91oZzhLU0nJTwDGc/6OC0qrnWcAUDsObdRxINwVbWtK4 N0qUbTxujIchgiJlWjokA1ViZQH0OCRviHd4p7Nz6l8jOeLQhtr+vDzL9ALLZ+UnRxu5 VDEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=PJNarNUEypMemgOYIFHPo26oMha0F/dWF+URINhJzvw=; b=YvGJY/fVXHqg/Ibf2rGD08tIsckaCW/Xxnckc8cdJsiivS3wyKlFHMGQDJF7hVt36c pqBlRe+w2hdGtH0dJ1mFozcRbb0GCWGf2vCBUj1ZKj0h2cfwKDN7MIcpmn6roORkBn00 F9Jw0G7FdJmHowrUhHSl87IYz31SSMR7SnBVQnPrnufCuDpSH8QvwZEjwUCOpibjaM68 VAUpUJlRi715eK0l2shV1nt+967y+LA44V/8N4gbROHLhHx/4i6MI0xODY+MdmoZgUda 7sGe5BVzhgNEoGh6Hi3ym30L4cFclyntY2XkapQhOmVF5T+F5wjxwjvdVzgJOREG6i9E z0cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@qti.qualcomm.com header.s=qcdkim header.b=JZ6o8zMW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qti.qualcomm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o13si6651060pla.73.2022.02.09.00.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 00:45:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@qti.qualcomm.com header.s=qcdkim header.b=JZ6o8zMW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qti.qualcomm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2245AC0018EE; Wed, 9 Feb 2022 00:41:41 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239614AbiBHNUV (ORCPT + 99 others); Tue, 8 Feb 2022 08:20:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245690AbiBHMmp (ORCPT ); Tue, 8 Feb 2022 07:42:45 -0500 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF99AC03FEC0; Tue, 8 Feb 2022 04:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1644324165; x=1675860165; h=from:to:cc:subject:date:message-id; bh=2RhWuRylgy7FQta6UTPTHtX3kQLdhFq81B4ywAgmIdE=; b=JZ6o8zMW0F/HcmLR4UjHYicVC+1lIscZLIaRmyIGZ6FGRwy8P/4HlyGd USwlz+07J7Ks+0ZaTxmLhl94bq0KXlosOEw1LrqzerKa0ZdrLh5p/vTjc 2P3cROPLjQgKdNXwK7sDn1oWDz/q2j5gQaVmq+K601+43Nuew7UEfS9pb g=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 08 Feb 2022 04:42:44 -0800 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 08 Feb 2022 04:42:43 -0800 X-QCInternal: smtphost Received: from hu-dikshita-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.110.13]) by ironmsg02-blr.qualcomm.com with ESMTP; 08 Feb 2022 18:12:34 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 347544) id 54F624567; Tue, 8 Feb 2022 18:12:33 +0530 (+0530) From: Dikshita Agarwal To: hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, vgarodia@codeaurora.org, Dikshita Agarwal , Dikshita Agarwal Subject: [PATCH v2] Add check for READ ONLY flag Date: Tue, 8 Feb 2022 18:12:21 +0530 Message-Id: <1644324141-27180-1-git-send-email-dikshita@qti.qualcomm.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dikshita Agarwal Add a check for V4L2_CTRL_FLAG_READ_ONLY to avoid request testing for such controls. Signed-off-by: Dikshita Agarwal --- utils/v4l2-compliance/v4l2-test-buffers.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp b/utils/v4l2-compliance/v4l2-test-buffers.cpp index fa8c37c..b8de7af 100644 --- a/utils/v4l2-compliance/v4l2-test-buffers.cpp +++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp @@ -2032,7 +2032,8 @@ int testRequests(struct node *node, bool test_streaming) if (qctrl.type != V4L2_CTRL_TYPE_INTEGER && qctrl.type != V4L2_CTRL_TYPE_BOOLEAN) continue; - if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY) + if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY || + qctrl.flags & V4L2_CTRL_FLAG_READ_ONLY) continue; if (is_vivid && V4L2_CTRL_ID2WHICH(qctrl.id) == V4L2_CTRL_CLASS_VIVID) continue; -- 2.7.4