Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1637193pxb; Wed, 9 Feb 2022 00:47:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwNrv/RMDNjx/01BixgfGm34/2vxBfYKpcadPdTRiFhfLsWMcid6ojutZAz/zUmPtaDO1yF X-Received: by 2002:a05:6a00:10d5:: with SMTP id d21mr1169635pfu.2.1644396469407; Wed, 09 Feb 2022 00:47:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644396469; cv=none; d=google.com; s=arc-20160816; b=QVAvXJj54wO3P3+JuIbkEKvyI2G5mFbkTfKNZwsgxfTE35aL1P/KULmJukvTwJr9hi ZkmT6/o1pjqiwEmYWhFObfmwEtrtu5rnncSvrkFOLO/r2zyoWkR83nPnRGO1swcR0J5S Qq60xT+M4ocqloxYQV/acwuFu46ptlsfR8q15RxCJ8OVkCmahboMtmRW/ig8975EZXhz wOpe163tMNVTMLHr5FyXB6OavtbV+tAy2rNyEKdSezRN0I9JfjwbdTkiZmV7CRE0bpIP RPvCc9fCn0DLerY+HRw9C7oZVI/yDDmNkNP2muswR2K1QG3BsZ7+rBY2UtvFK17NrO0f H6+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=D/59mzxAxGpcuRuvJCsAZqxLYdHzeJaGwUP97h2Fvxg=; b=ATBtyWHCthnPdQn3izsebuUNLsswzCN5VUd0CzcldWTrjFhK2EuFOEsRTaS2MVHXCf k9eZ7muYG578JKc5gDraD1LGc7+7J8vzSQz3ZCIuN2EBPRfgKzab/k72S/+F7gnKqsEi 04a4EpRZHHtaCe6FvE6nPH14HbDdUummbqIHyrU53AyaAfY2aUFzOUic2AhjIDMbQjYu aeVGnr8CyrRGdtX0U7L+5rFucXIcvp2bkMhdNi6QQsjLfTg9S9caQhOiofCwBEUmlBJG 0EvLj6+/+doXDjw3DxjvR8Z74qIb3sLOb5A+ueLFdUInxDhh3k4TomZnKGwh8vDmBrpg /LFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G+vBbN1A; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z1si16476514pfe.46.2022.02.09.00.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 00:47:49 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G+vBbN1A; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7349DC1038E4; Wed, 9 Feb 2022 00:43:06 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384571AbiBHSJU (ORCPT + 99 others); Tue, 8 Feb 2022 13:09:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384557AbiBHSJQ (ORCPT ); Tue, 8 Feb 2022 13:09:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B0C20C061576 for ; Tue, 8 Feb 2022 10:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644343754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/59mzxAxGpcuRuvJCsAZqxLYdHzeJaGwUP97h2Fvxg=; b=G+vBbN1Ad5W7S2gaofDNJZGFiX1+NbQkgaNjrjUmhWt7a9GnwPw8QXfgWPdD976fDMc/jv yOpTKdraI79lQE6Kp8CfB3OsFtvd6vZayR0fIIZZEGEhysYqsxvTGW2+N14VswbhI+2mdE ry+Ok+jOey+VWiJUl/+imYBorEbARz4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-263-94u5fJhhOGSVfatUArxitA-1; Tue, 08 Feb 2022 13:09:13 -0500 X-MC-Unique: 94u5fJhhOGSVfatUArxitA-1 Received: by mail-qv1-f69.google.com with SMTP id e9-20020a0cf749000000b0042bf697ff6bso4555288qvo.5 for ; Tue, 08 Feb 2022 10:09:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=D/59mzxAxGpcuRuvJCsAZqxLYdHzeJaGwUP97h2Fvxg=; b=Be+KC8SNA8IY6PgAMovV8NsGWQLc57Zpa9wQTlC334C2pTl/x8xoZg0MA+Syui8nBu oK1mBRwAmnk/ljiHhlYcWa4t58x3oBVuREadQpPRpvlA4wG1JHc7RM/C63e4ZNSxSuen KHh/ljC5//JkwjWZ3RACPz+5mIcpaysEpxtvbNvPYDobOcEOp8pZkxbFRzZSSIXAEuoi 01B23GiIHRAQGhoxm9Kjz1/yHmCqwNxxq1qcHHgqcYvBQGF1ERD2sccHhHIBEIaPncNk Q+oX3Uu5KTkhvcgWXKv1Ao37j6XzsR0MGtIsVrLj/t6IMPYFTcMCbSb8vgbURuzSKy+z YZkg== X-Gm-Message-State: AOAM5323UxQ9eO+GOxFJJHtAJoYfIV9pl2Rr2koh+vvAJw4L2X/O/X4T jEOg25tpZuek6AApgiAHz6AxGy7yA7uy9n0j2qd/uiTnn0VeU/y7aIm9MmQFNE1m610PKYu9rZH JGJKpZaD27MEJChXM8tnU28zD X-Received: by 2002:a05:6214:2aad:: with SMTP id js13mr4206753qvb.32.1644343753180; Tue, 08 Feb 2022 10:09:13 -0800 (PST) X-Received: by 2002:a05:6214:2aad:: with SMTP id js13mr4206733qvb.32.1644343752985; Tue, 08 Feb 2022 10:09:12 -0800 (PST) Received: from [192.168.8.138] (pool-96-230-100-15.bstnma.fios.verizon.net. [96.230.100.15]) by smtp.gmail.com with ESMTPSA id s2sm7006656qks.60.2022.02.08.10.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 10:09:12 -0800 (PST) Message-ID: Subject: Re: [PATCH] drm/i915/psr: Disable PSR2 selective fetch for all TGL steps From: Lyude Paul To: "Souza, Jose" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" Cc: "airlied@linux.ie" , "ville.syrjala@linux.intel.com" , "Vivi, Rodrigo" , "joonas.lahtinen@linux.intel.com" , "Mun, Gwan-gyeong" , "Roper, Matthew D" , "tvrtko.ursulin@linux.intel.com" , "Kahola, Mika" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "jani.nikula@linux.intel.com" , "daniel@ffwll.ch" , "Hogander, Jouni" , "De Marchi, Lucas" Date: Tue, 08 Feb 2022 13:09:10 -0500 In-Reply-To: <47eed687da699a6abbfd7726439fd307786c9d93.camel@intel.com> References: <20220207213923.3605-1-lyude@redhat.com> <47eed687da699a6abbfd7726439fd307786c9d93.camel@intel.com> Organization: Red Hat Inc. Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-02-08 at 13:06 +0000, Souza, Jose wrote: > On Mon, 2022-02-07 at 16:38 -0500, Lyude Paul wrote: > > As we've unfortunately started to come to expect from PSR on Intel > > platforms, PSR2 selective fetch is not at all ready to be enabled on > > Tigerlake as it results in severe flickering issues - at least on this > > ThinkPad X1 Carbon 9th generation. The easiest way I've found of > > reproducing these issues is to just move the cursor around the left border > > of the screen (suspicious…). > > Where is the bug for that? Where is the logs? I'm happy to open up a bug and include some logs, will do it in just a moment > We can't go from enabled to disabled without any debug and because of a > single device. > In the mean time you have the option to set the i915 parameter to disable > it. I mean - I totally understand the hesistance with the lack of debug info, I'll go open up an issue with said info in a bit. FWIW is a machine currently being sold with Linux pre-installs which is expected to work out of the box, so it's not exactly an uncommon laptop to be running Linux. Also I don't have any problem with us trying to fix the issue before flat out disabling things - I sent the revert hoping that would happen, and also because I needed to write the revert anyway since I had to disable this in Fedora's kernel. > > > > > So, fix people's displays again and turn PSR2 selective fetch off for all > > steppings of Tigerlake. This can be re-enabled again if someone from Intel > > finds the time to fix this functionality on OEM machines. > > > > Signed-off-by: Lyude Paul > > Fixes: 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by > > default") > > Cc: Gwan-gyeong Mun > > Cc: Ville Syrjälä > > Cc: José Roberto de Souza > > Cc: Jani Nikula > > Cc: Rodrigo Vivi > > Cc: intel-gfx@lists.freedesktop.org > > Cc: # v5.16+ > > --- > >  drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++--- > >  1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index a1a663f362e7..25c16abcd9cd 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct > > intel_dp *intel_dp, > >                 return false; > >         } > >   > > -       /* Wa_14010254185 Wa_14010103792 */ > > -       if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) { > > +       /* > > +        * There's two things stopping this from being enabled on TGL: > > +        * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are > > missing > > +        * For all steps: PSR2 selective fetch causes screen flickering > > +        */ > > +       if (IS_TIGERLAKE(dev_priv)) { > >                 drm_dbg_kms(&dev_priv->drm, > > -                           "PSR2 sel fetch not enabled, missing the > > implementation of WAs\n"); > > +                           "PSR2 sel fetch not enabled, currently broken > > on TGL\n"); > >                 return false; > >         } > >   > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat