Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
IronPort-SDR: +sqDrn/0/tQ0Fre2W8OmlYQ4t4bhsB1avfol4/70rN6ZiLzsD/EXUFJIxuPOIC0lDFkaeEtgje
 XEE8DbNcfgsfEAFFfIZr9MCMygnSTosyEBV2BRX9pw+ZZTUBdfTjkpQOec8++lc6jSVDSDdK3P
 lftUdh6vlegsgLXx/S2QzijGDq6Rx2kxd+TCLcIp8hVkVQ0Fq/eeDZroSymI82+adkn0mpZRc8
 FcSOA67Lj3o9KxNdlXbZWAGYmAgu9hHXxRuWDh13YEtfMkh09jglCMNW2rnbOzjfFSCSHR/gaP
 ZtYEDNsp3IjJUMNofyhhyVpA
IronPort-SDR: xuSmEJrU5s4k59y/d+zxkdyFksj6P3gQR32Qdl1vsY5aD51LPk/EJGT7hlGiLHy2bJMmECXVY9
 /GbjKWrd4BCk46iojF4/mhR54Ts2SebsljJwEdORoH+SStP4ab3UZgRnscqEQ1tCpFpF/agG2+
 gJH4B7EsmoOlgKxKxwzSJMgJs7bQv9zQB/g3DNj9RNVQaCyCjXJHs8fa5ron2B/sq/DtWfUUpi
 VkZfSsXPglnp/at5x3p0tZT6Qma59lGDobWjZXmB8tz7ncFEKToIRPClYtH69cY3wvIGggM1y1
 7xw=
WDCIronportException: Internal
Message-ID: <f726e9e1-bdad-ac8a-368b-aae423a00676@opensource.wdc.com>
Date:   Tue, 8 Feb 2022 17:07:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] libata: add horkage for M88V29
Content-Language: en-US
To:     zboszor@pr.hu, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org
Cc:     zboszor@gmail.com
References: <20220204125750.1771303-1-zboszor@pr.hu>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220204125750.1771303-1-zboszor@pr.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2/4/22 21:57, zboszor@pr.hu wrote:
> From: Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi <zboszor@gmail.com>
>=20
> This device is a CF card, or possibly an SSD in CF form factor.
> It supports NCQ and high speed DMA.
>=20
> While it also advertises TRIM support, I/O errors are reported
> when the discard mount option fstrim is used. TRIM also fails
> when disabling NCQ and not just as an NCQ command.
>=20
> TRIM must be disabled for this device.
>=20
> Signed-off-by: Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi <zboszor@gmail.co=
m>
> ---
>  drivers/ata/libata-core.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 67f88027680a..4a7f58fcc411 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4028,6 +4028,7 @@ static const struct ata_blacklist_entry ata_devic=
e_blacklist [] =3D {
> =20
>  	/* devices that don't properly handle TRIM commands */
>  	{ "SuperSSpeed S238*",		NULL,	ATA_HORKAGE_NOTRIM, },
> +	{ "M88V29*",			NULL,	ATA_HORKAGE_NOTRIM, },
> =20
>  	/*
>  	 * As defined, the DRAT (Deterministic Read After Trim) and RZAT

Applied to for-5.17-fixes. Thanks !

--=20
Damien Le Moal
Western Digital Research