Date: Mon, 12 Feb 2007 00:28:51 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>, Arjan van de Ven <arjan@infradead.org>,
       nigel@nigel.suspend2.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: NAK new drivers without proper power management?
Message-ID: <20070212002851.3ca1b27a@localhost.localdomain>
In-Reply-To: <200702120004.15529.rjw@sisk.pl>
References: <1171058269.1484.64.camel@nigel.suspend2.net>
	<20070211194202.GC15445@elf.ucw.cz>
	<20070211210258.0b8da53c@localhost.localdomain>
	<200702120004.15529.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1089
Lines: 19

> +PM support:	Since Linux is used on many portable and desktop systems, your
> +		driver is likely to be used on such a system and therefore it
> +		should support basic power management by implementing, if
> +		necessary, the .suspend and .resume methods used during the
> +		system-wide suspend and resume transitions.  You should verify
> +		that your driver correctly handles the suspend and resume, but
> +		if you are unable to ensure that, please at least define the
> +		.suspend method returning the -ENOSYS ("Function not
> +		implemented") error.  Note, however, that in such a case your
> +		submission is likely to be suspended and only resumed when the
> +		driver correctly handles this feature.

I'd lose the last bit. Just end it at "error.", there are going to be
people who produce good reasons not to handle suspend/resume.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/