Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Darren Hart <dvhart@infradead.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@collabora.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Cc:     kernel@collabora.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
References: <20220119103332.2887370-1-usama.anjum@collabora.com>
 <3a4878b9-f175-f16f-a901-efc33b2bf89f@linuxfoundation.org>
 <24d02704-e590-63d0-4d8a-c76578249bea@collabora.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <1464f5e1-d79b-b440-9a15-c0ed61599e1b@linuxfoundation.org>
Date:   Mon, 7 Feb 2022 14:31:46 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <24d02704-e590-63d0-4d8a-c76578249bea@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/7/22 1:50 PM, Muhammad Usama Anjum wrote:
> On 2/7/22 11:40 PM, Shuah Khan wrote:
>> On 1/19/22 3:33 AM, Muhammad Usama Anjum wrote:
>>> If only futex selftest is compiled, uapi header files are copied to the
>>> selftests/futex/functional directory. This copy isn't needed. Set the
>>> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
>>> path only. This removes extra copy of header file.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>>    tools/testing/selftests/futex/functional/Makefile | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/testing/selftests/futex/functional/Makefile
>>> b/tools/testing/selftests/futex/functional/Makefile
>>> index 5cc38de9d8ea..9a8c3700d773 100644
>>> --- a/tools/testing/selftests/futex/functional/Makefile
>>> +++ b/tools/testing/selftests/futex/functional/Makefile
>>> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>>>      top_srcdir = ../../../../..
>>>    KSFT_KHDR_INSTALL := 1
>>> +DEFAULT_INSTALL_HDR_PATH := 1
>>>    include ../../lib.mk
>>>      $(TEST_GEN_FILES): $(HEADERS)
>>>
>>
>> This will be a good cleanup. However, please make there is no dependencies
>> in the futex test sub-dirs on being able to find the headers under futex
>>
> I've tried the following variations. The build is fine.
> 
> cd tools/testing/selftests/futex/functional
> make
> 
> cd tools/testing/selftests/futex/
> make
> 
> make -C tools/testing/selftests/
> 
>> I vaguely remember leaving this in place for reason.
>>
> This must have been fixed in previous changes made to the build system.
> 

Thanks for checking. I will apply this in for Linux 5.18-rc1

thanks,
-- Shuah