Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Sanjay R Mehta <sanju.mehta@amd.com>,
        Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, dmaengine@vger.kernel.org
References: <41a963a35173f89c874f5c44df5530dc09fea8da.1644044244.git.christophe.jaillet@wanadoo.fr>
 <20220207165117.GH1951@kadam>
From:   Sanjay R Mehta <sanmehta@amd.com>
Message-ID: <aa78a0f9-9bd1-5c24-f834-61085d9fe3a4@amd.com>
Date:   Tue, 8 Feb 2022 09:54:06 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220207165117.GH1951@kadam>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjU3dEZiOG9jazlZUGVXRUx3R1JLWGtOcklxbjZiQmtHeitJMlh6dmZ3Ly9P?=
 =?utf-8?B?dHNxdjhWL2gyYVNNS2JPbnlYYnNkbFZzMk9Yc2RxNmhnbnIwaEVEcHdvYnRC?=
 =?utf-8?B?TThiVUhFZTNzL20vYTBjaGtMTHpqWDJKb0wvL2RWa3liV1ZmSk9PUGtwZFFQ?=
 =?utf-8?B?RktFYXZuNkRkdVZNN2x1a2E5bXZFR0twSm1WanM1aXB0TXI1anZDQ2Z5NUhj?=
 =?utf-8?B?TkJ1R2Rmclp2QVQ0eHJhZTFNUEk5eXQ5SGI1Rmh5eUc5SmZXTG5xR0pnUkJS?=
 =?utf-8?B?VC9ISUhDMkxmRnhyanZ0cUQxdHlEcHV2dFRadWVnZ0tYK3oxWHRZNWxYOHQy?=
 =?utf-8?B?TkJOcGFvem5ld0J4NE9ETkI3RDVwcTJWcm4wYXkzemtiOGFwUmpoUk13SGwx?=
 =?utf-8?B?TEZsMHFOeXdjOHhlcVladG1ha05DWk1tbzVMTW8vNGtieFE5bkpWSzRtNTVp?=
 =?utf-8?B?b2RqTjFRN0Z6Ni9CMVdxSFN2Z3NTeEhCYmZyZzFIQkxzZUpibXBtWkZtL2RQ?=
 =?utf-8?B?T2lzWVc3VGVlMk1JL05LanhGRjNrRVRnYzYzLzl6VFl5NVlpRHFCZ0szNkJB?=
 =?utf-8?B?Z0FyMTNkaGdkYy80WlFOc3JnZEZrUGpFS2pSODQxcWFieSt2TzczL0I1a2N2?=
 =?utf-8?B?NysvN3J5RU81a1ZyWHZkNEp6cktkd0h0RVFKYmZmWmlSRnRaM0Y4c01BSTFp?=
 =?utf-8?B?TVVnMExCRDFTb3VnVlB0SzZITlB1ZUpBQnhTSS9IOUVVVVBzVy94Yko4UWZZ?=
 =?utf-8?B?SUlqNllUSGMyN3VFdm9wL09zdXV5d0NWV2dxMVdNVUdnazc5VDlzYjk0VHgy?=
 =?utf-8?B?d2tVZE5hWUIvSVhNMTRLdlIzRUhWWEp3dEh1NjdSTWJEWExVbldIWmc3aEJK?=
 =?utf-8?B?d3Mrdk1RMFdIeDNzc25DcFVvem5wem9aZy8xZ1dNZG9UZHR5STVmRTlHRUJq?=
 =?utf-8?B?UFlBcUIrWHErREZVdzBnOWx0WE9rcEs5VlNsN1NRTm14U3RiQndPTkFmcC9H?=
 =?utf-8?B?NmhmZUJjeXg2aEJzRnFSWE5QbUxSWUF0Ymk0VmRvYy9IaCt3TkZUZHR4dVEr?=
 =?utf-8?B?SWdyV0tINFNSL2hERENXazBzRUsvYlRZNXRpZ3E5REhVTWgvNW5xb3BVYXpB?=
 =?utf-8?B?THEzeEZ1VDdkeVpFTFF0bmN6LzFZbFpoQW1yNG9xM3N0RWc0ZDA3cVdna29O?=
 =?utf-8?B?Y1gybTBiZWhjUzlVc0RRSElXK0JYaTU5emE4Z2dIOW1tWDR0RHU5MW1WQjJv?=
 =?utf-8?B?aWpFNmhsNVg3MVJRYW1SVzlwbzlIWHZwc25qNk9VN0JsTWpoVThKZGtRYnNI?=
 =?utf-8?B?U2tRSVVBTndpdGgrYmJ2eVpzS3BmeDZVTmp3bjk4aENQZjZQbE1DdjBnelVx?=
 =?utf-8?B?V1NhRG9NWituai9rdkwxQnhIRFg3RE1LRHdxdHpKOUx0aTF0WFh6QUxNRG50?=
 =?utf-8?B?RFFDTUltTjh4a2xFaTB0ZWYwMnZaejVnc2g4ajYvTHVaeUt4T2Q3R003QzYz?=
 =?utf-8?B?S3pTV3k4aE9VU0JPUHgzL3hzTUY2dnA4R0ZlZHpidkdUSkYyZ2dRVjJkNDYz?=
 =?utf-8?B?TGRRK0NiTCsxdzdySEtvdHRmYXZ2L3dGUkZyNEtKUGY5Q29JNnAwOEJTRDJw?=
 =?utf-8?B?V2tLM1dpYWhvYnE5aU03emlxTDhkVkFTWVRLUjEyUldxOXB6MHlLeTA5WFpF?=
 =?utf-8?B?WDdWSVNoMXFRSFdvanc0Q0Jmbjd1dnI3WStFOW5US0xLQXViUVArL0h2UjVX?=
 =?utf-8?B?ZEhsVElNVGxLQ0JLVUIvRnVIR0hTeHlCSS8yMDJ3QmcyVWQwQklkT3lWTGd3?=
 =?utf-8?B?WEhSTTljejhDMTI0NWRyYTlmUFlCNkdHTlU5RitRMG5CTUpZazJobTYrUkNh?=
 =?utf-8?B?Q3VPKzRCdlRhWEdvQnNUaS9obXRVUG5XaGhqVHVPTHZndHFWb1FXRHF1ZENI?=
 =?utf-8?B?Y0F0aCtEQTd3cHgxcFltT2l0cGNFa3NTTjJ2VGFXZS8rL0J3SVVaMVZEOEc1?=
 =?utf-8?B?NVlLMVlCWGszNTNqb2xZSm5QVUdNMzU5NFl6Z1lzY2FEWU9xeGZYbk8wSlAw?=
 =?utf-8?B?OGttWWVnU3BERXF3Rzh1NUtkeVJwbENYRmhuODFUMkh4QlhwUHBGdFRrY3dB?=
 =?utf-8?B?VEZlNmFmMjcyeDlId0xDdWRBQXh6aCswNnV6OXduNVdtZ0JrMkpoVHc4YkNQ?=
 =?utf-8?Q?CPS3a5KIrlIwa6bGNUOKw5M=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c9e6ece-8532-4618-3fcc-08d9eabae077
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1242.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 04:24:20.2863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fPkflLsLumScy5cL10LBXd47ghwKp+cwN2G+HtoNHP+5zxCUTgnU3MIdSltk4wNeI0ZdSFiunF0FCKiPH2gdTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1288
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/7/2022 10:21 PM, Dan Carpenter wrote:
> On Sat, Feb 05, 2022 at 07:58:44AM +0100, Christophe JAILLET wrote:
>> In order to free resources correctly in the error handling path of
>> pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
>> will leak and we will try to release things that have not been allocated
>> yet.
>>
>> Also move a dev_err() to a place where it is more meaningful.
>>
>> Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> v2: update label names
>>     move dev_err(dev, "unable to allocate an IRQ\n");
> 
> Awesome.  Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

Thank you!

Acked-by: Sanjay R Mehta <sanju.mehta@amd.com>
> 
> regards,
> dan carpenter
>