Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <00c5b899-ed35-44a0-6b22-bc3e882e49d4@amd.com>
Date:   Tue, 8 Feb 2022 09:33:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
Content-Language: en-US
To:     zhanglianjie <zhanglianjie@uniontech.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        PanXinhui <Xinhui.Pan@amd.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220208081443.28210-1-zhanglianjie@uniontech.com>
 <108cc1b0-8630-7f41-5ef9-73df69d250e9@amd.com>
 <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFpEcTE0SVJ4ZkpGY3h5RmZIZVAzK3h1cTlpNmpOYVYyMGkrZTV5enZNY3NZ?=
 =?utf-8?B?bGYzL012bk1vK01FckF6ZFAzRmR6b1NVeDhjOEVxbXdYU3YxNGhFTmNlWVh0?=
 =?utf-8?B?a0hUVEtqcWU4ZmZUY0VGL29nMGpPV0dLM2haOTNMY3pwRGhEeG1Va2pyOVhv?=
 =?utf-8?B?cFFUYVc1Tnhub1FtQ1RLWldnNE1ETW1YOUhZZEVaVkowdkNqVFJYNW5lN0lk?=
 =?utf-8?B?Z1kvK0diaUk1ZzlmcU41NXJDYVE4elgrTERPL3BWWDhJYlk0VzVOVVFhNlNr?=
 =?utf-8?B?cHcvLzN3VW1zRDNPRlVGR1cyUlkzck1TWFpzanZmQkJFMy9TVURTV1A0U1dE?=
 =?utf-8?B?dTFyVWR4ZGpkV2hjS1UwU2ZLRFNsNEt4cjhlU0xueWI3VXMvYzl3QjUzN2dy?=
 =?utf-8?B?cjFpb1hxWVY5UmpTWng1djFIT3FCRllHd0dWZ29DeUduRXZhMFUwRk03WUVZ?=
 =?utf-8?B?Z1VmaGtBbVUwMEdBU0VoVm8zanNjcW43eHcwbWVWamlWaG5pRnlXaEJ4RzZl?=
 =?utf-8?B?Mk1NYm1hWFVIenV2Rmk0Wm11Z0VxcEROUVQ0SjY1a1hycTZBVDAvWERLdVJQ?=
 =?utf-8?B?a3MyZ1pGdHNWYnlBMGgxZi9BNTl0d2xveHJXZlNjeDFjZzhJVEJFV0Mxd2sr?=
 =?utf-8?B?MXE1N3IxK2d0MWxweng0aUxrZnlUOGVDL0VkalhOb3lLNDdqdm5LeHFHdjhi?=
 =?utf-8?B?OTc1WWt5U0YwejlyU2d6ZWFFVEVRSlBDUlRhZmZLRkRvN2U2Y3VjS0RBdnAw?=
 =?utf-8?B?T3BmSU11UTJ5WDNnci94NkpwYUt3L2dnQUJpbjNRdmlHeG9tN21KOEJBQjlo?=
 =?utf-8?B?TnljdFkvY1hhOVdwdFV3YUVEWmJpT2hGenFSMXZhVmhhZmllNjMyUHByZmo0?=
 =?utf-8?B?Mkc1SFp2VXZLejlHZ3RheDdJL0ZpMlpxK2pZVHBkWlZ4WjBqNGxFL01sOU85?=
 =?utf-8?B?bVkxbGUwZlp3aFh6bTdwUXRBaEIxeEdGTGZ0Q3pNN3JGUjhzREl1M0czMjUy?=
 =?utf-8?B?RURWdXhtRVZOWXVrZVdZNFhkSW1mbVpPcWV3ZFdybExVM011dVgxS1ZZQ3hB?=
 =?utf-8?B?ckJSVDlOMjNpV043bno5Z0RtTXNpczRVTHVZRVVBaS80elIvMFBmS2hRVEtZ?=
 =?utf-8?B?VVE1eUNETmo4SlJSQ1REVGFMenpyVnFXRGdtT2k2YmpLZ1pDbjRNeUQ2aGZt?=
 =?utf-8?B?MjZnSEMyTTliZDN0NTg1VFM4VVpLVlo4RzJHMjZydXJCbjNhY1NrR0dtVWNQ?=
 =?utf-8?B?YmRzdGlNTy9kOWk3akFjTkVBa05pUW83YU9rUEs1Q3I2dGpuMERTMmNHZHcz?=
 =?utf-8?B?TGtyeEtXMzFCNFZ5MUVBbzdsM3liRFIvR0c5Zm0yYnZxeWdRdjB4SktHdFdN?=
 =?utf-8?B?TTVUSjhNUHcrME1sNTdqN0lNZHJQektZK2xNSWZzdzFPKzMxang3MWg0dFlk?=
 =?utf-8?B?WXNZM2ZqN0l6c0VJWVVYQUxLelFiaUprdW40cG4rK2NjakJ2U1dEaHd2ZnUz?=
 =?utf-8?B?M1ZwbDJQd21xeU9HemZUaVJMK2pEYnZXWEFNc3JvY1YyYUswQ3V2UEJmQ29a?=
 =?utf-8?B?T09KUjk2emt3OUpGSCtVd2QvYVBqMnVUTkNlUHZRbnJrVHJ6MmgwZkJQS2Yz?=
 =?utf-8?B?SUM1TW1UdUpYMDAzeUFWWHZtVThmSmJ3dzNpUnBQVUhzWi9McmJ1eEx5bjJj?=
 =?utf-8?B?Y2tuMW9LN2hkS1dFUHgvcGxXeGpCSzN4aW0wc2FVakFXbUpZcnd4VlQvZEpK?=
 =?utf-8?B?b3hrM0JGYTBWa2VuWXV2NHo1SlJMVENjVWp6Zk1WS0xUNnowL3FHa1dWT1Jp?=
 =?utf-8?B?NGdzVElSa29FeVdhdGRXcnlYdzkvb3R0QlFkWGUrOVhIdHhEK2tLSnA2UXk1?=
 =?utf-8?B?cFZuS3lhZVVHRDlBWHlWZXNsQVF6UUFNVWpBbGwxbWVvOEZqSHBxbmJCcTd6?=
 =?utf-8?B?M3hrOUJ2R05xeURNNDZOUmowVERKYTNsRGp4cXBacVhXOENjeFpKYTV5WDFB?=
 =?utf-8?B?aUloMURIWWlYRkhoSEF3RzZycXZwQ05QZDhUSW51Q0RxQlpGRk5OZktFdyts?=
 =?utf-8?B?bVBsWnZLZ2g2N2h3bGRDeVlkOVFsZWxDMVIrUVc3VVlQZnZVSkRrdmRXV3g3?=
 =?utf-8?B?ZUtEYldSQWtqQzVlWW1WZlBjK0NFSmZSR2duVDQzRGhQK0NKRDhtUXJIbldO?=
 =?utf-8?Q?EyCZq6v6ERZBjH2jBykLGj0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90fc0054-761b-4720-b5b3-08d9eadda9be
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:33:20.9124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q2d8hgc8K9Rl+06bmh/JRP5R5EdLhPFbDwAfOAdIdz0tEHe/uKHOVk/tgKT1SAuM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4629
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I think so, Alex will probably pick that up.

Thanks,
Christian.

Am 08.02.22 um 09:28 schrieb zhanglianjie:
> I am very sorry that I submitted many times due to the character 
> coding problem. Can PATCH V4 be used?
>
>> I'm scratching my head what you are doing here?
>>
>> That's the fives time you send out the same patch, so something is 
>> going wrong here :)
>>
>> Please double check why that lands in your outbox over and over again.
>>
>> Regards,
>> Christian.
>>
>> Am 08.02.22 um 09:14 schrieb zhanglianjie:
>>> after the buffer object is successfully mapped, call 
>>> radeon_bo_kunmap before the function returns.
>>>
>>> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c 
>>> b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> index 377f9cdb5b53..0558d928d98d 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct 
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>>       handle = msg[2];
>>>
>>>       if (handle == 0) {
>>> +        radeon_bo_kunmap(bo);
>>>           DRM_ERROR("Invalid UVD handle!\n");
>>>           return -EINVAL;
>>>       }
>>> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct 
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>>           return 0;
>>>
>>>       default:
>>> -
>>>           DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
>>> -        return -EINVAL;
>>>       }
>>>
>>> -    BUG();
>>> +    radeon_bo_kunmap(bo);
>>>       return -EINVAL;
>>>   }
>>>
>>> -- 
>>> 2.20.1
>>>
>>>
>>>
>>
>>
>
>
>