Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1677334pxb; Wed, 9 Feb 2022 01:57:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2+7RQwnSN+LmNAXM/2JZSEJQU+sL/m45/sl4MSGIVm50eb9GLsS2DTh1fLip4jp3abudd X-Received: by 2002:a17:902:da8e:: with SMTP id j14mr1634622plx.53.1644400659216; Wed, 09 Feb 2022 01:57:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644400659; cv=none; d=google.com; s=arc-20160816; b=IWesfzw+1obrN2bjRzM1bM44FM34Gn0tnDqgd1+3JZkmQPrE0p3BmSSoQk+HFasXIG Ded2zOJhhO8fCwJ7okCIXyEjL8J8gUdUnpakO1DcUnw5nk3SMFep6fuCDt4atd09jLzP RYBy9husZU3380XVQUAxVqvN4lhKThJ8VvwnG5KyL9QUhCET43x47B9zYMTrz+bMylRY q2kKw/5Aosm+mgcxkrOar+V+hzse1dGJQUCExIR78d5S+57EC6XMbQPwTe34JnUaQdvx tm4CytdwsGBTu9q3xE60bn+NHqjg4UTtAmTqJUaO0PoTIi8n7kMMisC2bf2YwnBkijzZ UGHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EZDSS2MYdieKNY+ptNKFPV1o4mbS/p6IjuUtTxEmOkI=; b=wnTN3/+c+jBWAn+1SOwEBFSEMjCqiUTqFt4SvyC9GWGOjePKizucYmzATyxLw2IglC n7lctZoFjMJqeavawJfwLm2f1VdmHmK6eJNQoKeQRXlTMccgIGYaafzvNmyvOy5+llA1 aqmF4JY1xi3vshy8JnNzuYfHn0PHjLsjCdjkRL0qSOXGJBvahHXL7HnKRp8G0Si3c3pW CHYZZWFRpaVqaC0f1hGAesW7yvyabN+Rjh2qm0BqNkzPUTPQItOA3fQNYxizGquzwWNL pxzMCeoOqnS6rjdXQ7ZtwPvH6T3jt0ax8fkJ5bjXU6ahyH1Fjx4QlChhdK+UqBzLLRSO nLdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=duNxmxAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si16257049pfe.355.2022.02.09.01.57.20; Wed, 09 Feb 2022 01:57:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=duNxmxAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348627AbiBGK4K (ORCPT + 99 others); Mon, 7 Feb 2022 05:56:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352176AbiBGKuq (ORCPT ); Mon, 7 Feb 2022 05:50:46 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD94C043181 for ; Mon, 7 Feb 2022 02:50:45 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id m14so23891146wrg.12 for ; Mon, 07 Feb 2022 02:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EZDSS2MYdieKNY+ptNKFPV1o4mbS/p6IjuUtTxEmOkI=; b=duNxmxAdk7clYt7ndWPXMcPdSolXHBq4k1vpVSHdqeR3Y4OWFGyd1weIqSmOvwZb6S Spl+lEN4s/4eqR+CV2VBUi31PwqNpLhu1spSm9qyFUZFnw96KF9rCAhnyUvDBEIf11z1 PSnr7JICxX6dz2N2SJiFNsqmL9hadf/eri3EZFXn1w2FkBwZdwQP/eyRjWS5wMaFGvdn ZF0lDFr030L6E1u3lhpYKRKDd4tReFjacJB9q+g0p4uS1S2/apocHH72RqIDegc24uK8 2jrlj+s/8rx96MGL4wDFQmWS8/lusi4cE2hPx9vSkIyDaelQhP2a0llYAaxuDq8JyPit J5CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EZDSS2MYdieKNY+ptNKFPV1o4mbS/p6IjuUtTxEmOkI=; b=m0BHmCjtOm06RqsPr4H5MAMMo0udjYLBS9vSePYsPvD8LnF/EgK07C4+qyGbru0OSb u0namIiMUlwCCu8fl5Pi0imLBjGfG4ZUyo4Zjo6+pRFYR3Cdj8WXY2oF02rDwosIaGaX S2wgzx/7AWalPY9tpCVl/ls4LrBXAExojFr6zoeBwzitqywiUGuPrGJqaXuQTHQ/N6yV oH+BwiZwKZ075PsW9GPOc+/zG6Y+EqyLXhZxs39zZtz7C9Am2kMXVwrPWTp8d96CJrWT E0DnmD53oydnH7thnORslbRy0Fwf/pF6zKEToMJLIdLA8jHmnxKW1epsrJ+ycNlyhoiy f/Cw== X-Gm-Message-State: AOAM530NQtB05/35uE76M7WSsnfKzn4V6stL5U1KitXStwVsUodJsNst jPGvwCAuSwzYmZHVEkRB2MZuzg== X-Received: by 2002:a5d:6486:: with SMTP id o6mr8980127wri.454.1644231043764; Mon, 07 Feb 2022 02:50:43 -0800 (PST) Received: from usaari01.cust.communityfibre.co.uk ([2a02:6b6d:f804:0:9277:27e1:ecf9:6ab6]) by smtp.gmail.com with ESMTPSA id a22sm112080wmq.45.2022.02.07.02.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 02:50:43 -0800 (PST) From: Usama Arif To: io-uring@vger.kernel.org, axboe@kernel.dk, asml.silence@gmail.com, linux-kernel@vger.kernel.org Cc: fam.zheng@bytedance.com, lkp@lists.01.org, lkp@intel.com, Usama Arif , kernel test robot Subject: [PATCH] io_uring: unregister eventfd while holding lock when freeing ring ctx Date: Mon, 7 Feb 2022 10:50:40 +0000 Message-Id: <20220207105040.2662467-1-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is because ctx->io_ev_fd is rcu_dereference_protected using ctx->uring_lock in io_eventfd_unregister. Not locking the function resulted in suspicious RCU usage reported by kernel test robot. Reported-by: kernel test robot Signed-off-by: Usama Arif --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index ad8f84376955..dbc9d3f3f6c5 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -9471,8 +9471,8 @@ static __cold void io_ring_ctx_free(struct io_ring_ctx *ctx) __io_sqe_files_unregister(ctx); if (ctx->rings) __io_cqring_overflow_flush(ctx, true); - mutex_unlock(&ctx->uring_lock); io_eventfd_unregister(ctx); + mutex_unlock(&ctx->uring_lock); io_destroy_buffers(ctx); if (ctx->sq_creds) put_cred(ctx->sq_creds); -- 2.25.1