Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 8 Feb 2022 08:49:52 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Message-ID: <20220208164952.GA238@COLIN-DESKTOP1.localdomain>
References: <20220208044644.359951-1-colin.foster@in-advantage.com>
 <20220208044644.359951-4-colin.foster@in-advantage.com>
 <20220208150303.afoabx742j4ijry7@skbuf>
 <20220208153913.GA4785@euler>
 <20220208154515.poeg7uartqkae26r@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220208154515.poeg7uartqkae26r@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ObhA8bRiWqzscqSI2Nn6H6tYo6LkusXMQR9+EzwBaE+pkWHez8xQwPKfwooU?=
 =?us-ascii?Q?70+HpAYOWDkANTAOplrgUfsyU19rFHfLM5XiT6CtldeDc8KIgNHjAWIXCYMJ?=
 =?us-ascii?Q?goLzU3mkgI6we2Nsc0S92+sXSC7EyhAFmMZGe+7+YFCnGRsV22yyRA0H/RMb?=
 =?us-ascii?Q?ZWRmpkXfLLD+l/lKg6RV7/RV2MwmivoJLsTFYaK6E6ED5S9oKQED2SZ7Ludw?=
 =?us-ascii?Q?azpQE1lVH7NQ3KvVuTxobaJEHNdp9yCFO/MTAaTsMYyseyhixjlrAhQ1ZT0G?=
 =?us-ascii?Q?710qh+BUMv3tY0d6jrCmWXqkiBBFyx+9tN/vKpUxpvrxZnUl/vk/Ht+GpnEB?=
 =?us-ascii?Q?LjgN4NedSGgJzlzqWRjl8R5rlhMS67TZA7dh1rcBFcCgNIB6Ji0cIctdI+4l?=
 =?us-ascii?Q?q2sug7y8p79ar00na3hzuFxNj6GMU21FDn5fFswzFGIrlrvufPIlFeli0Bq4?=
 =?us-ascii?Q?u00jnBmk6fjt49LrRp/2TvtdyIWDxg3V1qZDTTh/MF4Lm7y13u9raKjpkfBG?=
 =?us-ascii?Q?MXq4m7xIC5WGWbuhvzbpt++BnhpMiidcmGL/rHghw8QGHK2VusB0Eqkcqkve?=
 =?us-ascii?Q?CFWf9oiV6XrnMFGUmvzwHqg6EABbZB/g+IqRlVXJLTJMl6hLpuJ280vMNdE+?=
 =?us-ascii?Q?hKsOfNMyeRtUGRIM9DXBfw/hFCyPrNCEjFZLN6uKNo6Zvk92dX8xbV0FsS58?=
 =?us-ascii?Q?m+8l05NvFuiY5CJeXqxdAFX/mHNZvVaa5s/7gN0FGXwNeZopBm6pZmquFN+f?=
 =?us-ascii?Q?CyXGLZNh+gxipjobXts9l7bhfsaDdJUrPNCw0TFZGyJQRRzn3qbRPw+crNML?=
 =?us-ascii?Q?50f/gt3/XjucBK7NpvXzwKz7Q69U31Uf06urVpVjKW8vACSXeny6jrz4xnGq?=
 =?us-ascii?Q?6SW6i1rVI++OPSSFLzvSkjcUaO+ygUkT9cCufH/lZppXQKCW9UFXCr8dNIrg?=
 =?us-ascii?Q?jufNf68hMe5Rm8GjrUoejC1EB5udniwCcMWlbH04SrF4Dk8AF+hYgKIf/hmX?=
 =?us-ascii?Q?uAZZkdTIMxBefxJPdcVxtxBut7Fc7Yj4/OldtarXgtZOx/Mfl2ozGw3xVFNe?=
 =?us-ascii?Q?x9p8scxnWcPxcWVMgQT6VHcVv7ZOQ64wh6+0oi1Ga0kI7aXOs13mjDh83Wnf?=
 =?us-ascii?Q?ebq3W9UH3ZkTJj2bhHPzKjHE24XVPG/Fz3M7T288Hz+ANNMfQgd8if1fl/LW?=
 =?us-ascii?Q?Ab1ocxODyvSa5AoKM0tpgW9FDt6DqZ4M0nLPb2jLmMsEVeb7D3TqAD2Rf1p0?=
 =?us-ascii?Q?mB5+nHDP817q7O+WffsZk4n8TYnIR2J1WtSRAj5ftC3bptbNNcoKVPDBq3mr?=
 =?us-ascii?Q?Qc1VtJYv86BPKX0KscPvSNwbKbkf7VOAuSVs6OJ9G1CMdq2b8wQGsAtJz8E7?=
 =?us-ascii?Q?xzaVQSshRUgGO3UB8CXKiVS4dTeppJIi1AALUJz6A99BOs+zcXePui6NPquE?=
 =?us-ascii?Q?QI9XlcPCd+OQ3Q5LrvwV2QC4Ao1wMA4SY1BpVjgZGmgRYWf0cJTVMzLMTCON?=
 =?us-ascii?Q?4Sf3gYVGfUQAcwIqRJK8zkHKxmY+haJ/Rce0xkGdjJT2Js+asheluCIfEuhE?=
 =?us-ascii?Q?5CtdepktxFxpdiUJcu8TOwJ16Y4cdSI1FEtWDzAgTCeF+uolOmsNPh9f8by/?=
 =?us-ascii?Q?umYZY4ZmpUnhFZJokFqZXThQWaQtE+AHB+W6hNKBuO9u1XT0NtS4l6dXMENT?=
 =?us-ascii?Q?bXTCRjbpKeht5dRvQ0QAHMZSyC8=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec6f6b5e-dd44-4c17-0291-08d9eb2309a4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 16:49:57.0105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oed+ZJ0N2BOqL2PNfe8SUVuMzwi4rqq28FSFoaCHgbTHwYIWAT3QlxrnCyM1qNF+FqZ/8nafQh2AMGST1Agu4yOY/Or4Hl1gg0Iwlo+jWvk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3551
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 08, 2022 at 03:45:15PM +0000, Vladimir Oltean wrote:
> On Tue, Feb 08, 2022 at 07:41:56AM -0800, Colin Foster wrote:
> > I see that now. It is confusing and I'll clear it up. I never caught
> > this because I'm testing in a setup where port 0 is the CPU port, so I
> > can't get ethtool stats. Thanks!
> 
> You can retrieve the stats on the CPU port, as they are appended to the
> ethtool stats of the DSA master, prefixed with "p%02d_", cpu_dp->index.
> 
> ethtool -S eth0 | grep -v ': 0' # where eth0 is the DSA master

Thanks for this hint. I didn't even think to go looking for it since the
DSA Documenation mentions an "inability to fetch CPU port statistics
counters using ethtool." I see now that this bullet point is from 2015,
and probably should be removed entirely.