Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1689224pxb; Wed, 9 Feb 2022 02:15:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjp/jr834i1QWIM3Mk2tkuDA7YgBeKCke83vnpwsgJA9qFY6D8TasytlyJVvMVz8F1KxjY X-Received: by 2002:a05:6a00:1c77:: with SMTP id s55mr1473540pfw.3.1644401721907; Wed, 09 Feb 2022 02:15:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644401721; cv=none; d=google.com; s=arc-20160816; b=TWFJrGHyvpmdZdxkb4mhezkK72PT1lUIpVE3lPmvhYxbG2V56qR6pB2gingT4Txx9Q FFjlg55FmDbvvYUE4uLgR8jI2h/UIs6CaVjbewlZzaRtXyjS7ZUpsQwwih8e9Su35wno QUiVlLcXMgDT5mfNdwmZBONPZ83xeRFX9frbng0mDyL/0tKAYkhJDk9itcs/NqYkY9W9 NaTDKOcrDTiXO+Yq8otKzp44RXFHGhMzZ7ZH5XEUaiZBd0+qM98jUhYKDgjSnihVFZfe LrT4EMX5VsujjOHX2HJwkQ2DQSdbOqmQBwW8d/dUmYZDi+L1be0tf2j8UtzlBj/mFvp+ pPdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=bmBoCspThb0e3/6sT933uzB0WbHZ0YSRYCjWmTB8oEw=; b=jAcxiQfA3I9KIXkc+e2aPwZsu/hxxgMlqjMhctG0ClkIoo22JARvkxj3vMNTLd4iBb K9bPpUz19S5VCI4bO6cQcwpIeNH0J+awOEn0y5VQeqsZC61sct+yJPGC3js9ROuQChGx 4YYaTV/1LfmNDsBLQlGZJfxXABHjyVKarwFsiC1vjfnWEFVLPf8htmVyo23cxHDjwt9D nT3ou5dLfgcaMa56ERX39IKQByn1eBrR6FJUVpsWRxDHKClT9b3qVTwOy2CuLyKbqAP3 wh/uNJSNtvg1UoaO7Q70tElyWOvumBFhew12uyLVfV2QzTf+jF0uy7C1iWUc2w4PettB 8IYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xwK4FNK4; dkim=neutral (no key) header.i=@suse.de header.b=Ox3NpwQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q70si16282992pgq.226.2022.02.09.02.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 02:15:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xwK4FNK4; dkim=neutral (no key) header.i=@suse.de header.b=Ox3NpwQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 90CFFE04B0F1; Wed, 9 Feb 2022 01:16:44 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239235AbiBHL0h (ORCPT + 99 others); Tue, 8 Feb 2022 06:26:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356137AbiBHKPJ (ORCPT ); Tue, 8 Feb 2022 05:15:09 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCA3C03FEC0 for ; Tue, 8 Feb 2022 02:15:08 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C186F1F383; Tue, 8 Feb 2022 10:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644315306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bmBoCspThb0e3/6sT933uzB0WbHZ0YSRYCjWmTB8oEw=; b=xwK4FNK4oRgULGk+hEaIWl2DMi2wGLEGEdRjGGURmkv8te32jqOeOWas55XHJ7GAnkdosR k/VH5rlFrqrZVJe2hJ+Q7S5ORY2sj+nTaoBdMs003KaXJqB3nX25IOcb7F/h6JHNGNuibn jzVV+JyHg459j+fzgitn7McurWs5N1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644315306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bmBoCspThb0e3/6sT933uzB0WbHZ0YSRYCjWmTB8oEw=; b=Ox3NpwQAyyjdALliT+ueZqIpO+SUsJHjvMMhM5ihNNl7k8zulyFpvPEwjNcDs7J9SYcxfd HZRjbledr9cbOpCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6553713C08; Tue, 8 Feb 2022 10:15:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Dz3fFKpCAmLGcwAAMHmgww (envelope-from ); Tue, 08 Feb 2022 10:15:06 +0000 Date: Tue, 8 Feb 2022 11:15:04 +0100 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages Message-ID: References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207133643.23427-2-linmiaohe@huawei.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 07, 2022 at 09:36:40PM +0800, Miaohe Lin wrote: > Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online"), there is no need to pass in the zone. > > Signed-off-by: Miaohe Lin Yeah, I am with David here, "Reasonably generic function for adding memory" does not really tell me much about that function. -- Oscar Salvador SUSE Labs