Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYHKbq8GXukjoutEaxquFuvaFzqayJwKKA
Date:   Tue, 8 Feb 2022 15:03:04 +0000
Message-ID: <20220208150303.afoabx742j4ijry7@skbuf>
References: <20220208044644.359951-1-colin.foster@in-advantage.com>
 <20220208044644.359951-4-colin.foster@in-advantage.com>
In-Reply-To: <20220208044644.359951-4-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nTpFGh17puV10SIMWPcbBQ5bLeePIdCeNs+p2ixwMGbQALTSvG+WYVG7lwei?=
 =?us-ascii?Q?hpGAxUXNNzZaMzIdfMpy+ddy5+oJMQg0pZpfR/DC4cvFp/LxMBdEgbolowiB?=
 =?us-ascii?Q?JZs4sPOGslMVcpyicuxRoOYaQ3p6LdW+dXtm7Dc16/G3WRBqkUbQSDfEsByt?=
 =?us-ascii?Q?LmhJLrJFl6/U2zFbI4ne4inVgey9f9ohasc6L7thdAX9BF/3+Wd5Fp1DhRW3?=
 =?us-ascii?Q?4X9tW/Y9QcxEVs0PlF4r/AYd81T4mFdMRNZZ2OxLI0l7lPBvuhW9oksCYtvL?=
 =?us-ascii?Q?ejRx7B+LMP5hwP4b6OXF3U9rHxpI0gdtBwhqWL5q3qzZTUJr0vl8chyeo4kO?=
 =?us-ascii?Q?NO7tRIY/scMFriRrDW5+lMg0n8ODSLEP8ehmICdsdhsXQV2itWJ/mo2goEc1?=
 =?us-ascii?Q?2Eq+EMImzSjIyU4tQ6KmK9KByvebn1Qcr6V7Wnlsa42nvIyK4puCdOBfBjb1?=
 =?us-ascii?Q?sX3djgOGWnVwRUEjwhYHxF65CYGEaTmOzNuRgdjZaTCuSjgcy09BARaXdViG?=
 =?us-ascii?Q?qUkdeZKfO8KJW4Y9piAh+96+cBO3Gklf2nYObiiDCYpv6/Ai2nCQqFbqWkTy?=
 =?us-ascii?Q?TfVuKRl7y0CReBhkeylx6VoyKQhV2AvKIQJgPuF17skebnqIFovE/S6Z7S8p?=
 =?us-ascii?Q?C6O5IdMoZf/2dbAnjeLE6ZrvTu0+n8nGE+vPu8gQvWDalCBR+gU9xjO42txD?=
 =?us-ascii?Q?4gI/Ir/Myj4UYijXdV2LL5FNpqPKhukmDHwCfCTd/KiB8IFq9NPdXxVqohI6?=
 =?us-ascii?Q?oTsHZeI0m8Kmp5u4XcHCFOqZVcSRWhwRmerYvHC1c4Z2fUj8e8K7HaaGt4EZ?=
 =?us-ascii?Q?REXIXPE222L3dOMIVTY0bcZSDQeOYjusF8kBURPiDWSx3rLgtxK3TNKYcYXh?=
 =?us-ascii?Q?D9Isr4QD+ipb8ws6khozHind2uOnBPd876918nTaSnPkcFXzG22weBBy0UIV?=
 =?us-ascii?Q?guGWdc6P8kCDUksnuLkQrr2QdX6DQMVcw5JrmUwuqSqZFhZbT7zKJfFc/1oL?=
 =?us-ascii?Q?+ZKxxEusjccNZDj8GNoBuipsIYtnVpXkEYYjOEE6FQRaENnd/rj8vXSsLPjN?=
 =?us-ascii?Q?OU+BOAzjJORb+Iifc73LCULqgD4hQof1ipkxzTaYKexEZbSkUv2BYufDFQD6?=
 =?us-ascii?Q?HyFlrge8eLokpnzOoibsuIZJhG9s1LFElReIjVu5pJ8bEE6ZYqF2TR9QvQNT?=
 =?us-ascii?Q?judUSmej1knGnrvTRYu2R7HcJKtazD7yx2AcaiPzn5x1JBdyiUbq6hOa24/T?=
 =?us-ascii?Q?PQvjIl8mb6BmSzef8V1DnSxox2mdn6aZ8lG4a29I7RANkFZFcb/ejMeiz1fg?=
 =?us-ascii?Q?r8lQlrSnwoKcjibH6axbQotAlT97DM+nsFy024vepMZl0NsjHCP5foJgLb/0?=
 =?us-ascii?Q?Ai01OFlP8tVTdBIskRxv/5r9/zKNEbN4IKwIB2bGuhHSj/Of4wgKTCAhZNhI?=
 =?us-ascii?Q?0Deio1CVFrZVGzDkg/q1S8FasFVQGvfTAUtYNy5QghgAUuPE8zdAp38jG38+?=
 =?us-ascii?Q?qpP6KAP8J7lh1wQaRpNWyxLfAuEdX5uscJsVOjjqh4/BZwRwrfCulNCxwp6b?=
 =?us-ascii?Q?7ioKAaohzHqby0HnyMh2MSLAAHLqmBVbtuZIx/SuEvsaUUtnJT8uxHZUMllN?=
 =?us-ascii?Q?vEpyD8zRtt8mKCTQb+37YRLJRe5h7406y5DBhu/Rre1t?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <796176F8B4425246A9306D4A7F2577C8@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 128114fb-ac57-4c9d-bff5-08d9eb141bb2
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 15:03:04.4958
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Dx5kHqKsNWm/JeYVjf5VmgaxSOUAdH0ENoovIZzskbv3vVNH/SX4ZZZJMG18JdetD7cM3oq0cf5sraOpAlQtwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8050
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 07, 2022 at 08:46:44PM -0800, Colin Foster wrote:
> Create and utilize bulk regmap reads instead of single access for gatheri=
ng
> stats. The background reading of statistics happens frequently, and over
> a few contiguous memory regions.
>=20
> High speed PCIe buses and MMIO access will probably see negligible
> performance increase. Lower speed buses like SPI and I2C could see
> significant performance increase, since the bus configuration and registe=
r
> access times account for a large percentage of data transfer time.
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>  drivers/net/ethernet/mscc/ocelot.c | 78 +++++++++++++++++++++++++-----
>  include/soc/mscc/ocelot.h          |  8 +++
>  2 files changed, 73 insertions(+), 13 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/ms=
cc/ocelot.c
> index 455293aa6343..5efb1f3a1410 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -1737,32 +1737,41 @@ void ocelot_get_strings(struct ocelot *ocelot, in=
t port, u32 sset, u8 *data)
>  }
>  EXPORT_SYMBOL(ocelot_get_strings);
> =20
> -static void ocelot_update_stats(struct ocelot *ocelot)
> +static int ocelot_update_stats(struct ocelot *ocelot)
>  {
> -	int i, j;
> +	struct ocelot_stats_region *region;
> +	int i, j, err =3D 0;
> =20
>  	mutex_lock(&ocelot->stats_lock);
> =20
>  	for (i =3D 0; i < ocelot->num_phys_ports; i++) {
> +		unsigned int idx =3D 0;
> +

This is a bug which causes ocelot->stats to be overwritten with the
statistics of port 0, for all ports. Either move the variable
declaration and initialization with 0 in the larger scope (outside the
"for" loop), or initialize idx with i * ocelot->num_stats.

>  		/* Configure the port to read the stats from */
>  		ocelot_write(ocelot, SYS_STAT_CFG_STAT_VIEW(i), SYS_STAT_CFG);
> =20
> -		for (j =3D 0; j < ocelot->num_stats; j++) {
> -			u32 val;
> -			unsigned int idx =3D i * ocelot->num_stats + j;
> +		list_for_each_entry(region, &ocelot->stats_regions, node) {
> +			err =3D ocelot_bulk_read_rix(ocelot, SYS_COUNT_RX_OCTETS,
> +						   region->offset, region->buf,
> +						   region->count);
> +			if (err)
> +				goto out;
> =20
> -			val =3D ocelot_read_rix(ocelot, SYS_COUNT_RX_OCTETS,
> -					      ocelot->stats_layout[j].offset);
> +			for (j =3D 0; j < region->count; j++) {
> +				if (region->buf[j] < (ocelot->stats[idx + j] & U32_MAX))
> +					ocelot->stats[idx + j] +=3D (u64)1 << 32;

I'd prefer if you reduce the apparent complexity of this logic by
creating some temporary variables:

	u64 *stat =3D &ocelot->stats[idx + j];
	u64 val =3D region->buf[j];

> =20
> -			if (val < (ocelot->stats[idx] & U32_MAX))
> -				ocelot->stats[idx] +=3D (u64)1 << 32;
> +				ocelot->stats[idx + j] =3D (ocelot->stats[idx + j] &
> +							~(u64)U32_MAX) + region->buf[j];
> +			}
> =20
> -			ocelot->stats[idx] =3D (ocelot->stats[idx] &
> -					      ~(u64)U32_MAX) + val;
> +			idx +=3D region->count;
>  		}
>  	}
> =20
> +out:
>  	mutex_unlock(&ocelot->stats_lock);
> +	return err;
>  }
> =20
>  static void ocelot_check_stats_work(struct work_struct *work)
> @@ -1779,10 +1788,11 @@ static void ocelot_check_stats_work(struct work_s=
truct *work)
> =20
>  void ocelot_get_ethtool_stats(struct ocelot *ocelot, int port, u64 *data=
)
>  {
> -	int i;
> +	int i, err;
> =20
>  	/* check and update now */
> -	ocelot_update_stats(ocelot);
> +	err =3D ocelot_update_stats(ocelot);

Please, as a separate change, introduce a function that reads the
statistics for a single port, and make ethtool call that and not the
entire port array, it's pointless.

> +	WARN_ONCE(err, "Error %d updating ethtool stats\n", err);
> =20
>  	/* Copy all counters */
>  	for (i =3D 0; i < ocelot->num_stats; i++)

and here, in the unseen part of the context, lies:

	/* Copy all counters */
	for (i =3D 0; i < ocelot->num_stats; i++)
		*data++ =3D ocelot->stats[port * ocelot->num_stats + i];

I think this is buggy, because this is a reader of ocelot->stats which
is not protected by ocelot->stats_lock (it was taken and dropped by
ocelot_update_stats). But a second ocelot_update_stats() can run
concurrently with ethtool and ruin the day, modifying the array at the
same time as it's being read out.

The new function that you introduce, for reading the stats of a single
port, should require that ocelot->stats_lock is already held, and you
should hold it from top-level (ocelot_get_ethtool_stats).

> @@ -1799,6 +1809,41 @@ int ocelot_get_sset_count(struct ocelot *ocelot, i=
nt port, int sset)
>  }
>  EXPORT_SYMBOL(ocelot_get_sset_count);
> =20
> +static int ocelot_prepare_stats_regions(struct ocelot *ocelot)
> +{
> +	struct ocelot_stats_region *region =3D NULL;
> +	unsigned int last;
> +	int i;
> +
> +	INIT_LIST_HEAD(&ocelot->stats_regions);
> +
> +	for (i =3D 0; i < ocelot->num_stats; i++) {
> +		if (region && ocelot->stats_layout[i].offset =3D=3D last + 1) {
> +			region->count++;
> +		} else {
> +			region =3D devm_kzalloc(ocelot->dev, sizeof(*region),
> +					      GFP_KERNEL);
> +			if (!region)
> +				return -ENOMEM;
> +
> +			region->offset =3D ocelot->stats_layout[i].offset;
> +			region->count =3D 1;
> +			list_add_tail(&region->node, &ocelot->stats_regions);
> +		}
> +
> +		last =3D ocelot->stats_layout[i].offset;
> +	}
> +
> +	list_for_each_entry(region, &ocelot->stats_regions, node) {
> +		region->buf =3D devm_kcalloc(ocelot->dev, region->count,
> +					   sizeof(*region->buf), GFP_KERNEL);
> +		if (!region->buf)
> +			return -ENOMEM;
> +	}
> +
> +	return 0;
> +}
> +
>  int ocelot_get_ts_info(struct ocelot *ocelot, int port,
>  		       struct ethtool_ts_info *info)
>  {
> @@ -2799,6 +2844,13 @@ int ocelot_init(struct ocelot *ocelot)
>  				 ANA_CPUQ_8021_CFG_CPUQ_BPDU_VAL(6),
>  				 ANA_CPUQ_8021_CFG, i);
> =20
> +	ret =3D ocelot_prepare_stats_regions(ocelot);
> +	if (ret) {
> +		destroy_workqueue(ocelot->stats_queue);
> +		destroy_workqueue(ocelot->owq);
> +		return ret;
> +	}
> +
>  	INIT_DELAYED_WORK(&ocelot->stats_work, ocelot_check_stats_work);
>  	queue_delayed_work(ocelot->stats_queue, &ocelot->stats_work,
>  			   OCELOT_STATS_CHECK_DELAY);
> diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
> index 312b72558659..d3291a5f7e88 100644
> --- a/include/soc/mscc/ocelot.h
> +++ b/include/soc/mscc/ocelot.h
> @@ -542,6 +542,13 @@ struct ocelot_stat_layout {
>  	char name[ETH_GSTRING_LEN];
>  };
> =20
> +struct ocelot_stats_region {
> +	struct list_head node;
> +	u32 offset;
> +	int count;
> +	u32 *buf;
> +};
> +
>  enum ocelot_tag_prefix {
>  	OCELOT_TAG_PREFIX_DISABLED	=3D 0,
>  	OCELOT_TAG_PREFIX_NONE,
> @@ -673,6 +680,7 @@ struct ocelot {
>  	struct regmap_field		*regfields[REGFIELD_MAX];
>  	const u32 *const		*map;
>  	const struct ocelot_stat_layout	*stats_layout;
> +	struct list_head		stats_regions;
>  	unsigned int			num_stats;
> =20
>  	u32				pool_size[OCELOT_SB_NUM][OCELOT_SB_POOL_NUM];
> --=20
> 2.25.1
>=