Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220208020441.3081162-1-liambeguin@gmail.com> <20220208020441.3081162-4-liambeguin@gmail.com>
In-Reply-To: <20220208020441.3081162-4-liambeguin@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 8 Feb 2022 15:42:22 +0200
Message-ID: <CAHp75Vd7OfLyfziraV4AHWrnTSCPPN9gzGNxaFa+V6uNe8-YUA@mail.gmail.com>
Subject: Re: [PATCH v14 03/11] iio: afe: rescale: add offset support
To:     Liam Beguin <liambeguin@gmail.com>
Cc:     Peter Rosin <peda@axentia.se>, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 8, 2022 at 4:04 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> This is a preparatory change required for the addition of temperature
> sensing front ends.

...

> +               if (iio_channel_has_info(rescale->source->channel,
> +                                        IIO_CHAN_INFO_OFFSET)) {
> +                       ret = iio_read_channel_offset(rescale->source,
> +                                                     &schan_off, NULL);

> +                       if (ret != IIO_VAL_INT)
> +                               return ret < 0 ? ret : -EOPNOTSUPP;

Wonder if this actually should be

   if (ret < 0)
       return ret;
   if (ret != ...)
       return -EOP...;

> +               }

-- 
With Best Regards,
Andy Shevchenko