Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
To:     simon.horman@corigine.com, Jakub Kicinski <kuba@kernel.org>,
        David Miller <davem@davemloft.net>, shenyang39@huawei.com,
        libaokun1@huawei.com
Cc:     oss-drivers@corigine.com, netdev@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [BUG] net: netronome: nfp: possible deadlock in
 nfp_cpp_area_acquire() and nfp_cpp_area_release()
Message-ID: <922a002a-3ab6-eabe-131c-af3b8951866b@gmail.com>
Date:   Wed, 9 Feb 2022 10:50:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

My static analysis tool reports a possible deadlock in the nfp driver in 
Linux 5.16:

nfp_cpp_area_acquire()
   mutex_lock(&area->mutex); --> Line 455 (Lock A)
   __nfp_cpp_area_acquire()
     wait_event_interruptible(area->cpp->waitq, ...) --> Line 427 (Wait X)

nfp_cpp_area_release()
   mutex_lock(&area->mutex); --> Line 502 (Lock A)
   wake_up_interruptible_all(&area->cpp->waitq); --> Line 508 (Wake X)

When nfp_cpp_area_acquire() is executed, "Wait X" is performed by 
holding "Lock A". If nfp_cpp_area_release() is executed at this time, 
"Wake X" cannot be performed to wake up "Wait X" in 
nfp_cpp_area_acquire(), because "Lock A" has been already hold by 
nfp_cpp_area_acquire(), causing a possible deadlock.

I am not quite sure whether this possible problem is real and how to fix 
it if it is real.
Any feedback would be appreciated, thanks :)


Best wishes,
Jia-Ju Bai