Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <29238228-1057-c823-b9ad-60e64cea8468@amd.com>
Date:   Tue, 8 Feb 2022 09:15:21 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 3/9] i2c: piix4: Move port I/O region request/release
 code into functions
Content-Language: en-US
To:     Jean Delvare <jdelvare@suse.de>
Cc:     linux@roeck-us.net, linux-watchdog@vger.kernel.org,
        jdelvare@suse.com, linux-i2c@vger.kernel.org, wsa@kernel.org,
        andy.shevchenko@gmail.com, rafael.j.wysocki@intel.com,
        linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
        rrichter@amd.com, thomas.lendacky@amd.com, sudheesh.mavila@amd.com,
        Nehal-bakulchandra.Shah@amd.com, Basavaraj.Natikar@amd.com,
        Shyam-sundar.S-k@amd.com, Mario.Limonciello@amd.com
References: <20220130184130.176646-1-terry.bowman@amd.com>
 <20220130184130.176646-4-terry.bowman@amd.com>
 <20220208154524.283609ad@endymion.delvare>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20220208154524.283609ad@endymion.delvare>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b05URi8xZktPMWlaQ1hXZHZydys1MW1wMHo1d0RKUWdjVGp1RkFxNDVGdzhl?=
 =?utf-8?B?UlFRTTJONHh2R1VLK2k3bnZvbi94Q1dMb1N0UUVuTXhVTVBDN1c5MStWendN?=
 =?utf-8?B?aGo5elRTR00wQnZLVUtsVURIRUNtb01oMHp5Vi9Za0owRFdybkU4Nmp5bjVu?=
 =?utf-8?B?Y09FaFVHTHRQWkFiNTVRWFozN3JQUDBEZ204d3Vhb3JQSVBKeEE2QUs0V2p3?=
 =?utf-8?B?QU1Mc2VteDlpdmhNVHUvdlFKYVdoanhYRXpJL1daSFFLNHE0YjM3dE1QaFIr?=
 =?utf-8?B?QVFPWDQyT3NyYmJNbjNYSVdneG9UakYwNFh5MlZPdG4wK1FvZVh0Y1BTaXVG?=
 =?utf-8?B?MDd2aVQxL24rMlZiWFlHbnZZSjlrSGdzaitWUlVLQktBQ3BmdmxLdEdPRnl1?=
 =?utf-8?B?ODVVUjExYndBYmRBOTZaTGk3UzZzK0lySGxPMlJKZGhkSmtDeWlXOXpUNlBw?=
 =?utf-8?B?cHIwekZCT2dpUDU0alJTUnRHVjVwZy9vWVRWUWowSVdqUjdkdmcvQzlpclpK?=
 =?utf-8?B?c2p6bkRjOEdEUDFEeDYrWVliWlJ5dXlIR3diSC9QK0JJb08yNXZrSWtyZ25W?=
 =?utf-8?B?TStLd3dIMndGbDhWaGZOMDR4OW1JSENETUFEWEM0dHdMNjRzODFzazZkSFNH?=
 =?utf-8?B?STVmWDd5UXcxTFZHVzlOcFRTMGVITk1ZcTBXaTVKa3ZIYWd3Z285WDhYTzE4?=
 =?utf-8?B?SzU0UElhcW13ajMxbFV4UmFITzBiY2I0aHVsZURhWDgvQUphemg0eWdCRGxC?=
 =?utf-8?B?S0pRd1loT1MwNWVmQVl1ZGI1U09aQlFQOWh0ek9DOVJPM3M3bGhiNmlMSU1X?=
 =?utf-8?B?azNPblRiYkRhL0cvaVBGWG9kUUhsSVhLNTFXdkJ4WVU4aHZ0elpaT09CSmRG?=
 =?utf-8?B?ajR5V2R0d01pREtsQmV6eUhEUUNlU2NrdXg1dE9yWnRiaDlOUmpqRWp3eERq?=
 =?utf-8?B?d1RKdkJlckpleDF5U2hTUFdQUjlmTzl4b2g3ZGpUSjhOQURCRVlnN00xYWtr?=
 =?utf-8?B?cUNRNDVQMEtaaU81ZnhQSWZvQ0hUOExRWWk2N3BRVDljVWtwT2VPMWNOVVlq?=
 =?utf-8?B?QitaSSthQ1Y2WVdUMysyMkthQktLbmNSaFg3TXRoVkE0VHp1ejFkdVZ5QWNu?=
 =?utf-8?B?anF4Sy9SbUljdzI4Z1JWd3EvdTRYUi9adXZzRTNrT21XR0xRQy81NndnTjBk?=
 =?utf-8?B?ZEhJR3FQbDZpU0FlNlNkVlErbWJldnNGQm1KMC9QN2cwdmF0ZHpzSGNTVFdZ?=
 =?utf-8?B?ZmFTQzIwTWFOdS9BRUU2V1hxeFFrTjl6MUtWckZzbDZSaUhQNGZvby95Uk5r?=
 =?utf-8?B?bEhvUGJqenVHa3cva2JEMzZaazdZUHBaRVY3RkRvVm02QVZVM2hkRVNUUGt4?=
 =?utf-8?B?SjRhWVdGSGhFbGxXc08xYnQ3eXgrck5qcUdmUUtWZXpZSGx6VjR6SGRVNWZa?=
 =?utf-8?B?U1pKa3RoTlBuZWk3QlZOakxFdkV0RFNIOG1MNGNzMnFLSWZGNVlxNHRLc3da?=
 =?utf-8?B?M25VdzJ6bVdxNjdQWTF0UVo5cjVhbEhmeGR4dUVnRlhqWUtrUU1STUs3SEti?=
 =?utf-8?B?eEtaanZ4UndwcGs1Y3NWWjkzMC9SaVY0VmZIZTIyN0l4M3NSZWtZRm9jK1Qy?=
 =?utf-8?B?aUUwNkNyckZwYis0cThheXBoTmZxU0VYODN4dHl0aEhhdmtUa1lOWGZQWW9U?=
 =?utf-8?B?SkE5Q0xqS3RVbm5ONmxnWEdQZ0JvTVNaMkJnV3VZbm5oT2JFVGxJdjBuaGxr?=
 =?utf-8?B?VzhVYnU5emxhSUxHUDFvZ215SHlkRno3MXVWTVZTNlloL1N0SXFGRi80V2dj?=
 =?utf-8?B?Ykh6SXlmVXlmOGxncGJlWTNPa3NpMHFnZFFYVXYva2dSdmtCdU5ldmRKc28x?=
 =?utf-8?B?UU9rVGFqTmtVMHF2N1NkUHVGNllqMVJ1TmRVajFac0Z4Y1Vwd1Y4dXg5SmJx?=
 =?utf-8?B?cWZDbCtRSDJEZmc3TUtkblVCdkUxNEMrTE1BWHlCc2RHdWNjaTlRYXVRMjls?=
 =?utf-8?B?RUttN2ZHUEl0RTFuTTVOaWJsaVEvRU14bm9NQmRUdytmRXFXVFh0SUtCRTNU?=
 =?utf-8?B?aEQwT2wyd1UrNVFyVmtnQm0wK29vUWJFbEtuTmY5N2VRZ0JoRkYwQWltZlZN?=
 =?utf-8?B?T2sxQlZXb29JclExQzM2dU1xaEdrZm8xZ0pyUUZwZ3ZzV2xHYmh0T0I3MVJn?=
 =?utf-8?Q?w6s6KvGhK5ZeLjbzJdpLssg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 698f747c-ca4d-4b7d-3d33-08d9eb15d422
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 15:15:23.7520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R5L6oewE1g7KhaDDcUeHY7GaScgz6h/Cn3krDWwmMwzt1vp5Y0s+g+8E83D5APJUCs65qO9jG6QwrwbdhJjbBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1759
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jean,

On 2/8/22 08:45, Jean Delvare wrote:
> Hi Terry,
> 
> On Sun, 30 Jan 2022 12:41:24 -0600, Terry Bowman wrote:
>> Move duplicated region request and release code into a function. Move is
>> in preparation for following MMIO changes.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> ---
>>  drivers/i2c/busses/i2c-piix4.c | 39 +++++++++++++++++++++++-----------
>>  1 file changed, 27 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
>> index 3ff68967034e..5a98970ac60a 100644
>> --- a/drivers/i2c/busses/i2c-piix4.c
>> +++ b/drivers/i2c/busses/i2c-piix4.c
>> @@ -165,6 +165,24 @@ struct i2c_piix4_adapdata {
>>  	u8 port;		/* Port number, shifted */
>>  };
>>  
>> +static int piix4_sb800_region_request(struct device *dev)
>> +{
>> +	if (!request_muxed_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE,
>> +				  "sb800_piix4_smb")) {
>> +		dev_err(dev,
>> +			"SMBus base address index region 0x%x already in use.\n",
>> +			SB800_PIIX4_SMB_IDX);
>> +		return -EBUSY;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static void piix4_sb800_region_release(struct device *dev)
>> +{
>> +	release_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE);
>> +}
>> +
>>  static int piix4_setup(struct pci_dev *PIIX4_dev,
>>  		       const struct pci_device_id *id)
>>  {
>> @@ -270,6 +288,7 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
>>  	unsigned short piix4_smba;
>>  	u8 smba_en_lo, smba_en_hi, smb_en, smb_en_status, port_sel;
>>  	u8 i2ccfg, i2ccfg_offset = 0x10;
>> +	int retval;
>>  
>>  	/* SB800 and later SMBus does not support forcing address */
>>  	if (force || force_addr) {
>> @@ -291,20 +310,16 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
>>  	else
>>  		smb_en = (aux) ? 0x28 : 0x2c;
>>  
>> -	if (!request_muxed_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE,
>> -				  "sb800_piix4_smb")) {
>> -		dev_err(&PIIX4_dev->dev,
>> -			"SMB base address index region 0x%x already in use.\n",
>> -			SB800_PIIX4_SMB_IDX);
>> -		return -EBUSY;
>> -	}
>> +	retval = piix4_sb800_region_request(&PIIX4_dev->dev);
>> +	if (retval)
>> +		return retval;
>>  
>>  	outb_p(smb_en, SB800_PIIX4_SMB_IDX);
>>  	smba_en_lo = inb_p(SB800_PIIX4_SMB_IDX + 1);
>>  	outb_p(smb_en + 1, SB800_PIIX4_SMB_IDX);
>>  	smba_en_hi = inb_p(SB800_PIIX4_SMB_IDX + 1);
>>  
>> -	release_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE);
>> +	piix4_sb800_region_release(&PIIX4_dev->dev);
>>  
>>  	if (!smb_en) {
>>  		smb_en_status = smba_en_lo & 0x10;
>> @@ -685,9 +700,9 @@ static s32 piix4_access_sb800(struct i2c_adapter *adap, u16 addr,
>>  	u8 port;
>>  	int retval;
>>  
>> -	if (!request_muxed_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE,
>> -				  "sb800_piix4_smb"))
>> -		return -EBUSY;
>> +	retval = piix4_sb800_region_request(&adap->dev);
>> +	if (retval)
>> +		return retval;
>>  
>>  	/* Request the SMBUS semaphore, avoid conflicts with the IMC */
>>  	smbslvcnt  = inb_p(SMBSLVCNT);
>> @@ -762,7 +777,7 @@ static s32 piix4_access_sb800(struct i2c_adapter *adap, u16 addr,
>>  		piix4_imc_wakeup();
>>  
>>  release:
>> -	release_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE);
>> +	piix4_sb800_region_release(&adap->dev);
>>  	return retval;
>>  }
>>  
> 
> There's a third occurrence of request_muxed_region(SB800_PIIX4_SMB_IDX,
> ...) / release_region(SB800_PIIX4_SMB_IDX, ...) in function
> piix4_setup_sb800. Any reason why you don't make use of the new helper
> functions there as well?
> 

I didn't update the other occurrence because it was outside the codepath
for the device we are addressing. At the time I wanted to minimize changes
particularly for other devices.

> OK, I see that this part of the code is specific to the original (ATI)
> SB800, so it can't use MMIO, therefore you don't *have* to call the
> helper functions. But for consistency, wouldn't it still make sense to
> use them?
> 

Yes, it would be more consistent if it used the helper function. 

Regards,
Terry