Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1709207pxb; Wed, 9 Feb 2022 02:48:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgwgOfoSxjjYgscmBjaFX3kYcskCnKr+GDf431ucTT7GieljiJpPtosia3ZWBnBFDz7hs9 X-Received: by 2002:a17:90a:3:: with SMTP id 3mr667116pja.211.1644403702843; Wed, 09 Feb 2022 02:48:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644403702; cv=none; d=google.com; s=arc-20160816; b=dg6s6KapY6SgQbSMi17MCBT0JR00BwgXPJ6nxCwVGJNFPKH8vyS0Ar1Qbx+kzDVUap V5ZKXiq8v1S2ZzqSZYpbWeIGIMunXUVbQoAzU1cGmVLVLcN3zc/XOv0BpDaUHXZmLgzJ cEOJXG4bTA3uIxD7HeVvPRsGJ19sL/WbdkEKKQ9YasiN4FnT8DWTKAfIkD4GPqT5OMYL p2yiACbYPjM5IKahNSNgYjhDYtUZVf6/zUMM0lJQuYQRbU3Y3mO8vIt1xV2fg6XUffPL rdAuUdS1V8nR/5p1oxU83IA51T1MHFxhjVY6UNnbzb5x5IlzjcCwBx4aIhhutyk3zRN4 EF9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=Ck93pc6lmz4Xkpe+9ZwU93qNzmlYj7OnXCm3+nOLtP3aNoFXSbURobm6UORwAZ68H6 jqTtXpShXwe0NGyZJokmGEw7hUtboLVPo9gyvfNIndb5j8Gh0JgjCZR6m08h9fJH9B3u LgNEp780q3aMC77Wcy37wq9Bro0tR8kTSAJRhyY/9Ky1D9V2gE6w4Kmu6F3Tu7OCQDqz FzHML8/iZTbt8pxwcNxhsFPxor0mI6nmtptyX8u113ewoatDdcbIkQaeg2yOF21C6rQ6 a14g1xHZdeTsdHeBWzy4NJ+WLwdZm0kE7rXp8uyTUYMHNeDuXtoxDsGXBxwpJTd5iuaR IUpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=W2DDXQJi; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b18si9079818pll.161.2022.02.09.02.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 02:48:22 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=W2DDXQJi; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3377AE0B5C7D; Wed, 9 Feb 2022 01:26:38 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235040AbiBGSI6 (ORCPT + 99 others); Mon, 7 Feb 2022 13:08:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344937AbiBGSIN (ORCPT ); Mon, 7 Feb 2022 13:08:13 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34FAC0401D9 for ; Mon, 7 Feb 2022 10:08:12 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id u12so4635341plq.10 for ; Mon, 07 Feb 2022 10:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=W2DDXQJis+1qeQfXY6E/rxnSkSH+QKQccGw4pZqh3cKQQ7Ll28D21ZTANWBpjdTXkB +oBg0dRp7zXiF2K9fvNxjOnqLQ0NU4tSCX/uoDUgYXiPcW3lrnrEZ8WrBiPWSBgY4/tx 9wQBgc3U+/16XX6zr1IGWZp+OTMhC+7AmHWl4HQOtmJdf1TDvqV9PwZseP44xIAvTKTJ lY9+rCsDVlGtJn+K+JfRbJQJUoxEyKL8bHmbimQ1ptdoTfcpwUfxMxs8lIMS2tr1n+Up 0WNvMspuYRbKnLIowW6FPQwT66Mrqlup7UTEmGoUmJqEmINAArubT4xrd5hjAe0QVo24 gEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=co/3FWB2EGd01nA5PaQyTRt5r/ASHBFNpfwGOHrgEmE4HvQMIlQagMKudlE8H75Xom 9IK7FFteqhCm30bzxFwdva22B0fjAGW0wxT8i4/9biYpGcBoSNB4Vy2g7L/aPZP/TdXo aNxUBwafM14H3BkH7bl2Dge4IK3H8IgVdvw1ebN1PzHdTzdHvj5U9rS056xpssAEiZjU qWOyYu2ymM+N4HrptW9wIGQwuGpcBqjZSsnh+RSx7hl1/IL11MdZwyhEsTzyej5yxSUA sUZ0QYcqrzZ0lCG6/uVb4E/vhgeTc2pR/MXceTM0W0WeUU0Z48HfJfrZy3KykZn1cBax PbaA== X-Gm-Message-State: AOAM530Q1Zw59PNFjifFWzdlZ0YnONBUS7j4J77imtpvzOCUlyBi5WKl wGQ0zFH7+uKaVKBRQKQucFMPw0uIGzmKlh5mCmKquw== X-Received: by 2002:a17:902:ccce:: with SMTP id z14mr815477ple.34.1644257292200; Mon, 07 Feb 2022 10:08:12 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> In-Reply-To: <20220207063249.1833066-2-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 10:08:01 -0800 Message-ID: Subject: Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig Cc: Andrew Morton , Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. Looks good to me. Reviewed-by: Dan Williams