Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <108cc1b0-8630-7f41-5ef9-73df69d250e9@amd.com>
Date:   Tue, 8 Feb 2022 09:17:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
Content-Language: en-US
To:     zhanglianjie <zhanglianjie@uniontech.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        PanXinhui <Xinhui.Pan@amd.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220208081443.28210-1-zhanglianjie@uniontech.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220208081443.28210-1-zhanglianjie@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUNtdGZOb0J5VlBpTnZmWnM2T2IrSFlOYUcwK1JTSjg3anJORlo2dTVJYSsv?=
 =?utf-8?B?cGkvSzNGeGpFSjByTURuYmdIQ1BhVzJSNG8zbFVCa2hyOWdrTkpSWU1VejE0?=
 =?utf-8?B?YzNSRXdxWlh0TThLV1pXcTB2bDBwNmJ6d1dqUDBWaWovd1UvLzRsVGQ5VStP?=
 =?utf-8?B?WUJleHdjUXNrUFJsQlJyeVcwd3pzQlpKZTFnYTREMm1nb2g1NFZhd3ByRlpD?=
 =?utf-8?B?c3hhZWdPNjgxcE96UVp0dnM2U2dPTGJXYnlqaVhuK0pibFVXOVJXcEJKeVIx?=
 =?utf-8?B?Rkx0TmpSaWcvbGJoSEtXRTBOSlVPSVlvbkExS28xQ1hMNy9oWjVjVms0amxR?=
 =?utf-8?B?bjlLd1BxQksvT2VvelgrTHVsa0ZmQWRpMlc0ZzJ5dlNWN1ZqNjBwOEdJK3lp?=
 =?utf-8?B?RC9IUXVyQjMwTzR2SWF1SkFRSUU1WUhXNWcxMC9BYWZKKzZBeVhlR2tjd1By?=
 =?utf-8?B?TUJ6MEhQNEwvVmpnY2wzbUJSL2s1SWZWRlF2SjZ0bEFpUmFQY2l5SXM5Lzhi?=
 =?utf-8?B?QlRRM1pPcEVZRWtUUVJ4ZjV5czRtckJPcFRUSDhLQWF0YkdFVXYyRnRSMHNC?=
 =?utf-8?B?UkxlV0grTmxCa2J6VE5MSWcvZGVhZnhTcWo1QjNQQzNKVDAvWldyK2pKNGFx?=
 =?utf-8?B?Tmg3M2R3bytreUh6Ny9ZTGN5eDR4Qk92TDVCa0tLRVViaGhpcitDQ1FWN09R?=
 =?utf-8?B?ZmtCQVl1ZW1xMlZQdjgvZFMxUjFzdHVEQVR4eldsWGZCMUVDVFhpMWxndFdh?=
 =?utf-8?B?bzFaMWY4TERucUVYY044TC9KTURzUktJU2dldkxYT2tKYis5Rlp4NWR2d1RW?=
 =?utf-8?B?by8wQjE3NWd5d29HVHJpSWpHVXJ0TWFDR3c1eVhOazFpM0NmMVBGVTRLa0xR?=
 =?utf-8?B?SmFPRDFsNkV5aTM3SkJyS3g4VkZYVXdOQmVSanE1TXY4c2hVS1ZLSzlpQ2pz?=
 =?utf-8?B?Z0J5YXAxTjY5N0EyREh0RzRHUzMrZXlSZWxFemNoTStZYkd4S0M4RnhVZk9J?=
 =?utf-8?B?TGFGN1dKWFpkZGhjRENia1dEdHJWd0s0RTRvZk96dExnNnhoTjBkM0hETDJw?=
 =?utf-8?B?RXNxNWo0QXp3VFFNTXJLY3dKdVZpamtJQUNXSzM3SEpGMXROOHlRTGhteW1D?=
 =?utf-8?B?UVIxS1dBT01SZ1Q3UVJveVdIc1FlMDd6TUdacVRjajFHeUpNRC9GUEFsRW9h?=
 =?utf-8?B?cVdJd0FaQzcrY3lPajJISzRvYVFhOUxTWU1aazhzRmRPVWpJT1FaZSthRXk4?=
 =?utf-8?B?RHNWd0xkdDM1NWxUWXRYa0gwckprOW5MT2NObFhHemIwUjFxOUpnVndndmV0?=
 =?utf-8?B?TEk5ek5vbytsTHZBSFNGL1IycnhRYk1HV3A2NXRjREI1NFBlcmIxSHZFaUl0?=
 =?utf-8?B?Y3FEZyticy9kYTBJOFRxL0RMamlIYjFXaVVtajcyckpyYjdpc3ZobmdDVzJ1?=
 =?utf-8?B?V2UrNzQyVENtN3JHbU0xbmp3bHBpNlRqalFJVVAwZnNQcHozdWdzZ2NkWkZi?=
 =?utf-8?B?NytydlJOZnlFMndTZjRvcDZOWnlhN0YraEh3RFhudUx6U3Uwa3ZqRHRTL3h0?=
 =?utf-8?B?ekg1cnZsYUNTRm0yQWFOT0kzcmJRTS90aVF0c0dpaVVydVE3VGRxa2VBYUZt?=
 =?utf-8?B?ZTJBU21ocUM0Z2tKeXNYWmEvY1hCcDdzbm5aVkN0c0x3L3d0VEZLN3B3TjI1?=
 =?utf-8?B?dFVtNFkxWVA3NlBZRHBSdTFoSGhaVVBPY0p6U0F3emhRUVFOY3JqclNtVDhP?=
 =?utf-8?B?alZkWjJaRUEwMUsxeFFvR01UWjl1Vkh4b2NMMms4TmttTi91b3JjaXAzYUVx?=
 =?utf-8?B?aVFMaVpSUVk1RmlHNzhXTSs0dk1CcnpWQWVBZHJ1bHFyb0wvMHZOb05Fby8x?=
 =?utf-8?B?VnZFTUxvaUZUa1JWNTZuaVlUYU9XRUIwaWFodUQwYzgwMTVUdnlCMUt5eTFS?=
 =?utf-8?B?VTBGYkJXTzV0eEN1TllXWmhYQ2pack51RGVoS3dCL1hhVmlWSzQ4SWxKekVB?=
 =?utf-8?B?aUJnbUZkYnpSYUlqTkFtMWcwbEdlUy9HWW9vOWhKNUVqaWUzanB5aVBzS0pO?=
 =?utf-8?B?dkxFcjhuTVZoWHlnUDBMT1pKZEYvUHI5dUd2RkNMMGxDelVJNEphUEloM0pW?=
 =?utf-8?B?QkF4aGdQYlRKNDdvaUV4VzRVQWhVT0FQTTBqOFFtT1ZraXV5VmhQSlJQaStD?=
 =?utf-8?Q?F8nJFTAmjImcGjC9jLZV0fs=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a86e5a7b-d80c-477a-4e4e-08d9eadb7548
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:17:33.9014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWGqonisV8dPDiLs1p7pZT8gGQtu1KQdBxi2iftziqi7Louq+wTWitHmGOjjtgQ1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5052
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I'm scratching my head what you are doing here?

That's the fives time you send out the same patch, so something is going 
wrong here :)

Please double check why that lands in your outbox over and over again.

Regards,
Christian.

Am 08.02.22 um 09:14 schrieb zhanglianjie:
> after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index 377f9cdb5b53..0558d928d98d 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   	handle = msg[2];
>
>   	if (handle == 0) {
> +		radeon_bo_kunmap(bo);
>   		DRM_ERROR("Invalid UVD handle!\n");
>   		return -EINVAL;
>   	}
> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   		return 0;
>
>   	default:
> -
>   		DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> -		return -EINVAL;
>   	}
>
> -	BUG();
> +	radeon_bo_kunmap(bo);
>   	return -EINVAL;
>   }
>
> --
> 2.20.1
>
>
>