Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1710756pxb; Wed, 9 Feb 2022 02:51:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzngahwNX/TYOg5+v0jyCkLdfMSKNrxl1A9iucEZOpnEmECXylQIKvEnbqE9vYuqaY3AaZl X-Received: by 2002:a63:e84f:: with SMTP id a15mr1386760pgk.191.1644403863913; Wed, 09 Feb 2022 02:51:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644403863; cv=none; d=google.com; s=arc-20160816; b=f+/WcEDXpsgWO+QuLN59SjEQta4Oue+30xJZzieCPg0dHCcnt8ruxa/5s8VZpY2Mqv wBmLS+JQlpS0mtaMYfMl4nbSjxM44BsPfT/qKQrXrUD1ZtcvdE0ob7ZX2HhDxBsMcb2Z b7Y3HXFYnT+wblBQ8C+P1MrRbchSGKBmUMzQ4nbWGmDx9E/CKyCyU63pXyiOPktIZwcF N0GGSObbeoyZEAO1ecLq6IKDbTiJC+UxSpjaCcxYx4RPVNzvYpibLKQuDGTViNdy8Ez3 daVuEryDe024OKixXFXeDr5vJRNHRxEFRTcL4MFhvyMgJx5yOS/0ki92MauNpasHuClJ OA1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=m7750Xtt6+Jfo45pyGz/9r7LcIkPlsuk1CTsbBum1cg=; b=Y1QNCWzaWNxAlmJu3C8jtQEhrErsXEHPeNax+YHAlHCj2puWSHFtDsGoWKacu9SINd GEIKOxvqh4pMc4G36APa4hivn6bkxzkvxX+TwJ+fCqpQfbWrTSh8eDWNSBRXnYYhvrxA uGHZ5xbUd/Vtf4BoYwhKtcLXhAUjpVFCpEjIf7ceUiM/CF2rdxbp0rO/C+RU8zACLgkj KykzVVt+z5W68C0KTY75mu4Z60vazeFtGxU0xuuN4QPDRUGqiV/YMQbHBQGgC7HDr6jl pLSeF5MEPR4waJGMaVZDXEPj8qk6PXicV6MQPIFNH1coVDcHI0WfG2ouuzZ8Nhn9ofW1 TU6g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i5si459311pjz.175.2022.02.09.02.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 02:51:03 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 30927E0B94EA; Wed, 9 Feb 2022 01:27:26 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383838AbiBHRMi (ORCPT + 99 others); Tue, 8 Feb 2022 12:12:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383783AbiBHRMi (ORCPT ); Tue, 8 Feb 2022 12:12:38 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED7B7C061578 for ; Tue, 8 Feb 2022 09:12:35 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHU2U-00034v-M7; Tue, 08 Feb 2022 18:12:26 +0100 From: Heiko Stuebner To: Brian Norris , David Airlie , Daniel Vetter Cc: Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sandy Huang , linux-rockchip@lists.infradead.org, Andrzej Pietrasiewicz , stable@vger.kernel.org, Mark Yao Subject: Re: [PATCH] drm/rockchip: vop: Correct RK3399 VOP register fields Date: Tue, 8 Feb 2022 18:12:25 +0100 Message-Id: <164434033775.248576.1440613083224554584.b4-ty@sntech.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220119161104.1.I1d01436bef35165a8cdfe9308789c0badb5ff46a@changeid> References: <20220119161104.1.I1d01436bef35165a8cdfe9308789c0badb5ff46a@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jan 2022 16:11:22 -0800, Brian Norris wrote: > Commit 7707f7227f09 ("drm/rockchip: Add support for afbc") switched up > the rk3399_vop_big[] register windows, but it did so incorrectly. > > The biggest problem is in rk3288_win23_data[] vs. > rk3368_win23_data[] .format field: > > RK3288's format: VOP_REG(RK3288_WIN2_CTRL0, 0x7, 1) > RK3368's format: VOP_REG(RK3368_WIN2_CTRL0, 0x3, 5) > > [...] Applied, thanks! [1/1] drm/rockchip: vop: Correct RK3399 VOP register fields commit: 9da1e9ab82c92d0e89fe44cad2cd7c2d18d64070 Best regards, -- Heiko Stuebner