Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
IronPort-SDR: 7fLvSuuHR4G2KkjlptkdTQ2TtPRcqWkzOQcqlLM4wfDk2X0XEdhu/17HDWN5JnHy/B4oLS530D
 64Lmy0p3o0ZZSPCfrhYhhCtg8eqld4fiVyGSZuyN/ilfxh5UWb4IlgS9iwI6NcB1frGZfZXTEB
 BuDT9c0UHy7RkSYVAmVVFih4vkS8udBHpbGytg/u0b79sMTIl7Ib214eGyyNYzeIRCWtkLhdyO
 0ByPudznyjm+SrstlKLgjYG9MopBWpTXy+5CnrpZ0Mumqeu3edMHg2xbxXJrUvgCJjvRyhb6D4
 3vpyirPWRn3W1I0gGNi6L2oS
IronPort-SDR: rkjAIQwwE57lmkWMmhR7PdnaM55wCOEPa8WEoVEPvFjtHKtdfoaFDA30aSiVxLforwrBvSJTP+
 6pqlosLdLI3yQ9n1iSgu9n2D/ntdONH/v4QTyqJTbVL9j4VfWzdRQ72J4dSHPpQ9YE815KKmb+
 ypkPmkV8jIMmU150bSJ+oqMHf38uBWbzL82easjuPx/nq/W/rYaUSjLaHcLhbu4TT2JmvWiE5G
 e4A2tjAwcykRpSOMkDibjna8J5sN0vJbVxKbyGFhxetYSAhm5SHClfQ9jE6nkAHpoP/35YVUxo
 R1I=
WDCIronportException: Internal
Message-ID: <071c0b1d-32fb-e02f-d4e9-1540701d837b@opensource.wdc.com>
Date:   Mon, 7 Feb 2022 22:13:17 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 00/16] scsi: libsas and users: Factor out LLDD TMF code
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, artur.paszkiewicz@intel.com,
        jinpu.wang@cloud.ionos.com, chenxiang66@hisilicon.com,
        Ajish.Koshy@microchip.com
Cc:     yanaijie@huawei.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        linuxarm@huawei.com, liuqi115@huawei.com, Viswas.G@microchip.com
References: <1643110372-85470-1-git-send-email-john.garry@huawei.com>
 <1893d9ef-042b-af3b-74ea-dd4d0210c493@opensource.wdc.com>
 <14df160f-c0f2-cc9f-56d4-8eda67969e0b@huawei.com>
 <a8fae323-1877-058a-b03e-d175a725213f@opensource.wdc.com>
 <a2de1656-b1ec-2fb7-caab-657e27dacb48@huawei.com>
 <49da4d80-5cc3-35c3-ccaa-6def8165eb65@huawei.com>
 <59a198a8-1d87-bc09-d2d8-2d495ed74c16@opensource.wdc.com>
 <098f988e-1f12-c412-3111-60393dfe0f0b@huawei.com>
 <f3362c6f-b4b6-2914-0652-d786e19b6b03@opensource.wdc.com>
 <62e56609-7026-93a1-a446-a6fd68328653@opensource.wdc.com>
 <1114e27f-e6b3-e9b9-a892-f543f4636c4e@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1114e27f-e6b3-e9b9-a892-f543f4636c4e@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/7/22 22:09, John Garry wrote:
> Hi Damien,
> 
> On 04/02/2022 03:02, Damien Le Moal wrote:
>> This is the submission path, not completion. The code is:
>>
>> (gdb) list *(pm8001_queue_command+0x842)
>> 0x3d42 is in pm8001_queue_command (drivers/scsi/pm8001/pm8001_sas.c:491).
>> 486				atomic_dec(&pm8001_dev->running_req);
>> 487				goto err_out_tag;
>> 488			}
>> 489			/* TODO: select normal or high priority */
>> 490			spin_lock(&t->task_state_lock);
>> 491			t->task_state_flags |= SAS_TASK_AT_INITIATOR;
>> 492			spin_unlock(&t->task_state_lock);
>> 493		} while (0);
>> 494		rc = 0;
>> 495		goto out_done;
>>
>> So the task is already completed when the submission path tries to set
>> the state flag ? Debugging...
> 
> JFYI, I am putting together a patch to drop SAS_TASK_AT_INITIATOR 
> altogether. I just need to ensure that the logic in the isci code is 
> correct.

Great. Less dead code for the pm8001 driver :)

I was busy with a nasty libata bug today so I did not continue my
investigations. Will try tomorrow.


> 
> Thanks,
> John


-- 
Damien Le Moal
Western Digital Research