Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 8 Feb 2022 14:05:51 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Cc:     <vigneshr@ti.com>, <richard@nod.at>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <git@xilinx.com>
Subject: Re: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the
 flash node
Message-ID: <20220208140551.6271f976@xps13>
In-Reply-To: <20220208125738.32162-1-amit.kumar-mahapatra@xilinx.com>
References: <20220208125738.32162-1-amit.kumar-mahapatra@xilinx.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Amit,

amit.kumar-mahapatra@xilinx.com wrote on Tue, 8 Feb 2022 18:27:38 +0530:

> In devicetree the flash information is embedded within nand chip node,
> so during nand chip initialization the nand chip node should be passed
> to nand_set_flash_node() api, instead of nand controller node.
>=20
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>

Can you please add Fixes tag?

> ---
> BRANCH: nand/next
> ---
>  drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/n=
and/raw/pl35x-nand-controller.c
> index 8a91e069ee2e..3c6f6aff649f 100644
> --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
> +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> @@ -1062,7 +1062,7 @@ static int pl35x_nand_chip_init(struct pl35x_nandc =
*nfc,
>  	chip->controller =3D &nfc->controller;
>  	mtd =3D nand_to_mtd(chip);
>  	mtd->dev.parent =3D nfc->dev;
> -	nand_set_flash_node(chip, nfc->dev->of_node);
> +	nand_set_flash_node(chip, np);
>  	if (!mtd->name) {
>  		mtd->name =3D devm_kasprintf(nfc->dev, GFP_KERNEL,
>  					   "%s", PL35X_NANDC_DRIVER_NAME);

yup, that was wrong.

Thanks,
Miqu=C3=A8l