Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1748241pxb; Wed, 9 Feb 2022 03:46:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxH7AY+HiBp97NR+tIje2hSV6dUPQlvnsSgX9xvysgogLXIxZT7KiTyfJHGFvxs1Pd0Bof7 X-Received: by 2002:a17:902:da91:: with SMTP id j17mr1735328plx.89.1644407182488; Wed, 09 Feb 2022 03:46:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644407182; cv=none; d=google.com; s=arc-20160816; b=sKuzwsrETUUIWPcyWEwQ4hsQ34evO+kAM9mz+QAAqyjcWKSdijjwv6Q2YA3hnPt3Kr +xtg8vg55A6D6lChg2pAVczxe095XPqgGVjoAD9O+GFFANJa1wy6XSy/9j7U+2TOQGf6 t9SBc1McNa0t7pWUFuNRGkHgObgXw3GU6rWqRS6TTg4dm27rHcneywM2rCKyaCyRKC8g gMg6U9PdXmjOsb0DSXuDoPbUKv3dyXU9Q6YI6p3CrzjkNTmVGuMeAeZ7oXuUxyaKjVR9 HXf4fa28DEKAWUrJP08pSzzHE7lmuuDCDKHfjotI7ocgb4mGPfz1Eais5Rf4BRHv1WbE NjUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=8ug9KpH6bIvmPFydrBBlGOiV1ojuh4o4EvlAVOtW+r8=; b=XBAU1D7MRb0tbpATa4Zepe6s59JCRkkSi82MGzeTMbuYKnIBHLcpaAsNXUeVBBazW8 Wj4hzXa5QSz8qRyV9i+OYBSeWbxWXrFMdRwhFvUafsEZRxRu447+MPoyOP+Ysdpz1kXq vOOhTNVcyNdxZVZv9IwbK+qdBeIOt9B6ld2bbP+u6gg4U8MKa20F59akj0xdHBZJ5ch6 tIxY2ltcxKeKVT2k+/6nCC1yQe3BByNaowDWOVDOw6HAF81QyjumP6hVr6XKoYBiychB Buzfzeda8QIvBrlP8b363I8h9UQuj2xswkJJ1LrBOTxD673QGN05wpe8brHlj7cRPu+Z 8t2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Ucb6NZcc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n1si4740078pjq.103.2022.02.09.03.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 03:46:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Ucb6NZcc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DE0BCE0DE2ED; Wed, 9 Feb 2022 01:58:19 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389206AbiBGNvW (ORCPT + 99 others); Mon, 7 Feb 2022 08:51:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388363AbiBGNqu (ORCPT ); Mon, 7 Feb 2022 08:46:50 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D00E7C043181 for ; Mon, 7 Feb 2022 05:46:49 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id x4so3566277plb.4 for ; Mon, 07 Feb 2022 05:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8ug9KpH6bIvmPFydrBBlGOiV1ojuh4o4EvlAVOtW+r8=; b=Ucb6NZccAO1goAXBmte2XO3+lvr0ZtNlsCU1niaB4QeCGfuaC+ZZ34xsjuiUZ34J8P /PnDKyDwwKZuyRevYLH0cVu+uCxqEht+7er+qya2op6bjdApe9jED//PHeQR5KhnvRSi o4CuIM7pIIeu74ADGEG1vVJsUXTxHgkEvPzxtrhogxoQg5Pgb1QV4Ds6kJhzGHEfj/Js X18y8WlvaeZpnMJicsHItS4pA/ToBOt7PEBsnu43DqRWFYqgaSwsjHYfF7nC2ZYrqTz+ K3FGWynLI1LQBD2ydHoPIv4f5Q2OU5bpE28FB9kpldJ0ng8rn0wtSRR/4J+59QLHhwRw 8fKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8ug9KpH6bIvmPFydrBBlGOiV1ojuh4o4EvlAVOtW+r8=; b=LsGTOx2ekGcWpy8owWOSivSypBUmNRlzG1WrIXyoDi3J8HtRYfaYaVB0xOUH4xOCea 8/sRfQL9CDYPzHTRKiRxPC4PIKTVzQewj2uIXlyO9WaFMy/oMIT4t8cAuyKlBpGaLtt0 1g24UPS0b+9A24fmBX2pTm7IPzhPXsi9HjthWislQpe94tetN0OSSKtvhznu/O055km5 AKD6xQ8blKVflKeYFUarIw+PW0UbK+niv13MsOW4k8AsQuW9V1T99Fzvo3cfobqCx5r1 cPmZIe0dTrlkdEE9ju7RmfyT85v5Nog6G6U5iad7nwpZN+dTsRjsjiXpcuqrnB6gr2iS Gq9g== X-Gm-Message-State: AOAM530DrFs4mVdhYcGYjypmzg/FMSHMgfRKnmpa5WP3z4u/anVVX6h1 HT8+c3yqKrNYCSH58jLHCQipFA== X-Received: by 2002:a17:90a:f414:: with SMTP id ch20mr8409368pjb.146.1644241609260; Mon, 07 Feb 2022 05:46:49 -0800 (PST) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id 198sm8378636pgg.4.2022.02.07.05.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 05:46:48 -0800 (PST) Subject: Re: [PATCH] io_uring: unregister eventfd while holding lock when freeing ring ctx To: Usama Arif , io-uring@vger.kernel.org, asml.silence@gmail.com, linux-kernel@vger.kernel.org Cc: fam.zheng@bytedance.com, lkp@lists.01.org, lkp@intel.com, kernel test robot References: <20220207105040.2662467-1-usama.arif@bytedance.com> From: Jens Axboe Message-ID: <696e49fe-3d2e-da6c-2fc6-5d69bc7a60f9@kernel.dk> Date: Mon, 7 Feb 2022 06:46:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220207105040.2662467-1-usama.arif@bytedance.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/22 3:50 AM, Usama Arif wrote: > This is because ctx->io_ev_fd is rcu_dereference_protected using > ctx->uring_lock in io_eventfd_unregister. Not locking the function > resulted in suspicious RCU usage reported by kernel test robot. I'll fold this in with the change, thanks. -- Jens Axboe