Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1754510pxb; Wed, 9 Feb 2022 03:55:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDHzVZD6o1ALBGrbsKEeobUn8sp/l2NkXw/z874ZiJbVpIXM5UlME7ePzj2fJ4jkHEj43y X-Received: by 2002:a63:d848:: with SMTP id k8mr1621495pgj.164.1644407718478; Wed, 09 Feb 2022 03:55:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644407718; cv=none; d=google.com; s=arc-20160816; b=S4F88fv2RmqSWvQJHP3SXBgVF4U53vHpaCOqqstjOgN5U1YQbXd6qgwPGS9q9/gp52 yLcKDv6Lcdg5FcyWws+Yj+EHaIMj6fsawo2yYj5odObosmpDZVj9iaGeYjxSUIdUgYRK hFw1+zTiOw8n8LL4HpIoY7/AwaLxM/WIpxSdjrPcsWSOTHSX/mDG1p8/b2LkiNnJ1+2q NQuMM42J1FTF82qVaq1kQsOQX67Iw6qNZDAFFRtIFn/cvBhsAgEYgMLKrEA6Jp+VmqER 2kTiQHLP6GQBopaRyQIPUjDGdZhnXdW5XLa6OjVVcgEpZrDjYPx+VFo/hzc5HHVwyp6u SS0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=Ko7utT61KQM+vnI1dXkol9PWA1E2/Jgt+cxVzxGcXT0=; b=xsVmi8INpMdSgOoOnYM7NBnMvjoE1de10nP7zpZ+7UGx/fKic+aEOAXvun8mwApSCg 33J0aLq0dKK40+W8nlFCdcvMyS+RwZB9cueaSzeErif+aTeG5tBW8Q0GfMR4MPHuAuNf ZeaKgogufises+JmTxaCXDp/AlXdYA3whJcWG9a/WLVJ++m7fykj7wt/42hVTMD6T+90 s4hkofIUUljdpHvU3K07rJuHXKdr5rbfiBge/rVVxbo7L6YZb557hwQAEsOtftAqMfSX boTYgP0MvTqJIs0aJZ3jwanCcshwXRtkQztgQ9jrEuxh5drZrCx9XwXzSlkOgonJxYB6 kAfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=ZZY8gU8z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h3si15276894pfi.128.2022.02.09.03.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 03:55:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=ZZY8gU8z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CC285E0EA440; Wed, 9 Feb 2022 02:01:57 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384413AbiBGPvr (ORCPT + 99 others); Mon, 7 Feb 2022 10:51:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379814AbiBGPoL (ORCPT ); Mon, 7 Feb 2022 10:44:11 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D5CC0401D1 for ; Mon, 7 Feb 2022 07:44:10 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id z18so3876627iln.2 for ; Mon, 07 Feb 2022 07:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=Ko7utT61KQM+vnI1dXkol9PWA1E2/Jgt+cxVzxGcXT0=; b=ZZY8gU8z+UUez1b9ohUVeo8KMZps07sOCWCFRkg/7ttY17GG/0HOFesNlLcrl8dBg5 fmeyfErMckJfmxBzHzRtDbiLWjhYWyaGjZKlXOE1Xor06BUGcSgGzMl5XYNxiWD2jwVL xFLy9t+BDldE8tUfzecxr61kUeex1AkbJsPpyu3VDGBO7nmsKlK35Cf9MHOTLj5DfUTY 3+nJoPhccbOyiSS7GgMfvXZ5QQnUQXjRRQnlO91K8X+/4ojxRlr0BGy7b/6r1dS9VJvY rKaImVlb3KpOPtvCZTqXNgLvrbLAtytM21Wmz0KnsKZqKJKBWWcgeNHBuSf5y1+pMDZJ 96RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=Ko7utT61KQM+vnI1dXkol9PWA1E2/Jgt+cxVzxGcXT0=; b=hJVwBg5LoCAyeS344XWNDeVgjtl/X60r9lg00FcljF5ZZM9LHW/PEsccZSYD1QOyhU o/eO38nOMxcz5aD5SDrARTEzqB2w1RG4HHPPIajfQl0jFFAb5keGg8sOIvJ25YbRyHe3 F3pH+40pRtqXPOu6XSfPYYnqZZAE0ZIg/cjXJ1cUASz8SAw1RJKGbWgm14AY+E8ts+IA eeilgGQ+75qurQlUxsjpe8qxMdbOEH342Nqu9m40JYNf3zwyGfOlTR4J4W+frxq9Wl8X PI1DGQyzV/OOZj5fCGxFGM6DVyAOiNpkMfidU7LWDkwPpxl17ucG8s/nR90WeNCETkM1 rTBQ== X-Gm-Message-State: AOAM53101/PTGbZPesB8xUw07lqkVP/2U3zeTtD3E6BGz0E57MrfmiWS 0RTu/7qag7542ekqP7QqcKelBA== X-Received: by 2002:a05:6e02:20e1:: with SMTP id q1mr69357ilv.172.1644248650174; Mon, 07 Feb 2022 07:44:10 -0800 (PST) Received: from x1.localdomain ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id u26sm6145534ior.52.2022.02.07.07.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 07:44:09 -0800 (PST) From: Jens Axboe To: Pavel Begunkov , Shakeel Butt Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, io-uring@vger.kernel.org, Andrew Morton In-Reply-To: <20220125051736.2981459-1-shakeelb@google.com> References: <20220125051736.2981459-1-shakeelb@google.com> Subject: Re: [PATCH] mm: io_uring: allow oom-killer from io_uring_setup Message-Id: <164424864739.20474.1005758721065319672.b4-ty@kernel.dk> Date: Mon, 07 Feb 2022 08:44:07 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Jan 2022 21:17:36 -0800, Shakeel Butt wrote: > On an overcommitted system which is running multiple workloads of > varying priorities, it is preferred to trigger an oom-killer to kill a > low priority workload than to let the high priority workload receiving > ENOMEMs. On our memory overcommitted systems, we are seeing a lot of > ENOMEMs instead of oom-kills because io_uring_setup callchain is using > __GFP_NORETRY gfp flag which avoids the oom-killer. Let's remove it and > allow the oom-killer to kill a lower priority job. > > [...] Applied, thanks! [1/1] mm: io_uring: allow oom-killer from io_uring_setup commit: 0a3f1e0beacf6cc8ae5f846b0641c1df476e83d6 Best regards, -- Jens Axboe