Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 8 Feb 2022 16:27:29 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     davem@davemloft.net, rostedt@goodmis.org, mingo@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dev: introduce netdev_drop_inc()
Message-ID: <20220208162729.41b62ae7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220208064318.1075849-1-yajun.deng@linux.dev>
References: <20220208064318.1075849-1-yajun.deng@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue,  8 Feb 2022 14:43:18 +0800 Yajun Deng wrote:
> We will use 'sudo perf record -g -a -e skb:kfree_skb' command to trace
> the dropped packets when dropped increase in the output of ifconfig.
> But there are two cases, one is only called kfree_skb(), another is
> increasing the dropped and called kfree_skb(). The latter is what
> we need. So we need to separate these two cases.
> 
> From the other side, the dropped packet came from the core network and
> the driver, we also need to separate these two cases.
> 
> Add netdev_drop_inc() and add a tracepoint for the core network dropped
> packets. use 'sudo perf record -g -a -e net:netdev_drop' and 'sudo perf
>  script' will recored the dropped packets by the core network.
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

Have you seen the work that's being done around kfree_skb_reason()?