Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYHKbq8GXukjoutEaxquFuvaFzqayJwKKAgAAK3QCAAADugA==
Date:   Tue, 8 Feb 2022 15:45:15 +0000
Message-ID: <20220208154515.poeg7uartqkae26r@skbuf>
References: <20220208044644.359951-1-colin.foster@in-advantage.com>
 <20220208044644.359951-4-colin.foster@in-advantage.com>
 <20220208150303.afoabx742j4ijry7@skbuf> <20220208153913.GA4785@euler>
In-Reply-To: <20220208153913.GA4785@euler>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oIPks6dKi5SvfmiRSSEcv5Fg4b481/ektWbFoFhphC6ywoT/7js4iaNoFtS9?=
 =?us-ascii?Q?elmxuzx2eDzb3U2frl/dU8eFgkEG7ndJHa9QvcBCHB9oMgeucSE0XaDMmrva?=
 =?us-ascii?Q?yIIbyug1JXHOctx/sK38gnQyQG/l2nKbUtE8zDtyBfS/dw+Mf+QwmNnCcNQp?=
 =?us-ascii?Q?tO08zQJ6h+xH3NhucMSw8JOcbtwMuGl1wjoOf4wHykUZ88+svgTClMcw0UYn?=
 =?us-ascii?Q?N1SHl7Osip7oX6xPafCvPlhIDArVAzv5X9n3J76um1oDVEiG528FRiLHcOwy?=
 =?us-ascii?Q?hoDAZnlLB3mjeXcB5aURKAT/NCGjs+BFZbNB4c91ubX4gfTp9CcbQvKCVBde?=
 =?us-ascii?Q?WQEwlz7X7nZeuz69qaEi9PweY6OIEyPchXIpt9MRr4NYU/AVDNbK7iKFsNk3?=
 =?us-ascii?Q?HmOCJ/67wTm61ZSpIfv5/CdOdjZKXa2BiI4DefTIyW+MulVCSkh5xsCFhn6l?=
 =?us-ascii?Q?8KgfeXsMgMXI9OucupFUJy9kDot3o3Dgq6ldFmuciO6OpmPxjiY4iskpLt1g?=
 =?us-ascii?Q?YCVmu4rhJebwDti6eWmn0U434lffHcQUp2nvy6A7w+8CzJLHAIhq8ACQfC3P?=
 =?us-ascii?Q?By+GiJtg4T4OliiiL8yuGYl9JLJO9c+Jp17VPFO22WMt7bWK9n0CwIPBI/d1?=
 =?us-ascii?Q?yycQsXfimzq7mr0dbv0zJb+sUswNIXchf5VejEdzIyu6eyvnHhk5oAbV5hhq?=
 =?us-ascii?Q?sKvp+bLHnesZhMDvJfKVXDEwTYl0ggunb6orX4KR4yFRwi3C022p3/S64Zqs?=
 =?us-ascii?Q?j46m4J3RK6RSCK2rCkwlVXePt/NRH0/3i8PCf4M4hfduID+mxjQEF+4OCvDY?=
 =?us-ascii?Q?osA1vrOBTBrV/9/9yn7WOlh+IHrexQnCliclDoM4RLozcuWySwsrLXAlb864?=
 =?us-ascii?Q?jsMGQ4abDJkiuJ6QaD9i51F7LMDSrokTMX7+BXrLi+g/7lngabl3kfYOhnML?=
 =?us-ascii?Q?4ITa0NWT4szpH7Zi4hb7FavkHc2M9CCdquFAlJ31VFXKAAu8MFVDhn/Fc5as?=
 =?us-ascii?Q?UG20p/D9bn2YoogE5Zak2a5k/Nxiovq/yDDaEC4KnuMsobm0F2OLs7S2ibyH?=
 =?us-ascii?Q?yfaZtct3Vub+72KcmQy3XSxr3nobAa7yuZgI5UM8+K5nlfsI4dQR/z1xXkpE?=
 =?us-ascii?Q?ygetSGY9rAcFGcF3k0sIck+qvuErXtKLISdPlnN6IHW10a2wnzKjgroLcpiq?=
 =?us-ascii?Q?kQ2ZYz2QWlMqpsnvVftI3/AeV8j4iWKbf4KcPt0gxWNC7U6L6LfWJAAPVFqs?=
 =?us-ascii?Q?CKuXdOKOoAXec5JWXwv2s6ObUJO1nMQs1r0k/lXwhPSShQtCCpx+H76WnJqb?=
 =?us-ascii?Q?nPK/M7gQI+hyAADRE3SamhcSAZcHHZBO5EPo17ZLXa8r6kiExqD5VIpjIf12?=
 =?us-ascii?Q?cRhh4yvyIGr3WFWJ8+B0TchyCvGDumcKD5UsnW/+TpFsd+3prd9ZZeCnA56m?=
 =?us-ascii?Q?js0dml4CUGyGXVoxV+UhHT845OzAwoF33IxHz8TQLpItPYeR2P6LsziLE1xV?=
 =?us-ascii?Q?qmJUoyyg3McuCFP4euHHnYjB+6mZjtQObCgZT12Pkmah6cwDP1/NTmY5aTBP?=
 =?us-ascii?Q?5fVhmk5voq1wdJhsJeXon2sk/23uJ/frZFTGWIz+pYYChLzIAbSs0pn5JA5e?=
 =?us-ascii?Q?NF6dtEu+Nw3Zn1tn+io4MlaJq3tHPLi4qGl7Lr3qu82/?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <869712DA8CE1F247A49672AF7F1A13A3@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f10980e-d24d-428f-1de4-08d9eb1a005a
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 15:45:15.6125
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dC1O+vsOqrYKxSzimJsvdWypEhkcDCMnDZUpZqbZDLgG+jAp0q4rr1il5/FDFdkmF8XETsSborPsh6jekD7qfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3180
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 08, 2022 at 07:41:56AM -0800, Colin Foster wrote:
> I see that now. It is confusing and I'll clear it up. I never caught
> this because I'm testing in a setup where port 0 is the CPU port, so I
> can't get ethtool stats. Thanks!

You can retrieve the stats on the CPU port, as they are appended to the
ethtool stats of the DSA master, prefixed with "p%02d_", cpu_dp->index.

ethtool -S eth0 | grep -v ': 0' # where eth0 is the DSA master=