Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYHKbq8GXukjoutEaxquFuvaFzqayJwKKAgAAI4ICAAAkwAIAAAMqA
Date:   Tue, 8 Feb 2022 16:10:32 +0000
Message-ID: <20220208161031.3jknptcqcc7sltwk@skbuf>
References: <20220208044644.359951-1-colin.foster@in-advantage.com>
 <20220208044644.359951-4-colin.foster@in-advantage.com>
 <20220208150303.afoabx742j4ijry7@skbuf>
 <20220208153449.wyv7xrv4kotji7mb@skbuf> <20220208160742.GB4785@euler>
In-Reply-To: <20220208160742.GB4785@euler>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MXYVvqb9ir0WacztkOgjtaXvUkapr7EQFxs5egBqMicpXVo7jy4G3AvRyxpp?=
 =?us-ascii?Q?G2KEPiUA2YD7tCi6xMpIg3lteJVtc+FPu8+Z4YCxtINbhwB7OEURTxaLvBg+?=
 =?us-ascii?Q?KWQouHNJm+sdRAsRlt0lz6EDjhm5cOc4x9E2So4DN2To5zyHfu5rMxW3ZrEa?=
 =?us-ascii?Q?Bkq6Tmvy6zCcukdZaONqCHud/VXbsuWnH4ZBZiOP3EEAQVO2cmfkQA6T/30l?=
 =?us-ascii?Q?ZXd0xcnshjLhA+oLjuA4uFT+krixz1uQn5/blGwbRKqxAuRxNQrYSSCxsddO?=
 =?us-ascii?Q?e7S8mgybUKYpXGpoOOMzB++JapQ/eU4/TFsXF5UOSev2D3yicJhIfFk7JYBz?=
 =?us-ascii?Q?wkyst7mbXSzEALEHs7dTeEMaJZEnEbkfjIJ7gYLzHo9OE82LJOsh9d83EPUr?=
 =?us-ascii?Q?v6VUcymbxCXz0chBHowMc1zFpqqitQlPCpkJ3bk0EsysKqR8zpMDxSkHpqr+?=
 =?us-ascii?Q?t+HSXtQr1tFUwUtXlYFRdyKdMVlO38ZX8xFBVgfJvbTYG7WEe4lKzr00cCi2?=
 =?us-ascii?Q?Zk5JOasNJmNqZex4c04lZ2rmNtksWD/OsHXbc2RrkFQmXWZ8Aj0xFiGUcS4C?=
 =?us-ascii?Q?RfENbkCmISWFa/LiTN0I1iKU7WSsnXlPm1NpsH+NSbTkHDUu96sqQ8BKa6/p?=
 =?us-ascii?Q?Xtujqv9xJzjJ4oH6DeOOoQmsGYuvGtBqohI3/arzHDXpN7665ldgW2915J49?=
 =?us-ascii?Q?z+8BX1LO7D93CWGVcx2ggZcj5YSl7hFWbAT+HIUmoB5KD4wMCYpwMYP9dEuH?=
 =?us-ascii?Q?v4eUEZDgjdz1N2FIhNncpAZ4Xy8f2h0pazzq3l0kBAAWqlPeHtxaMYtx4St3?=
 =?us-ascii?Q?LsR17Cfza+aE8RJgxgqpAjPAAojwPyLchtbn4bsRyREaMh4s17s5y9sFWUjX?=
 =?us-ascii?Q?SEBzkWwG+2OLJwZNVZ4/TQ+BVD8HiPYKMjXuWltRnVrszIoRcaBsrO7G8xW+?=
 =?us-ascii?Q?q3BuFddDpQNNAz74Ohf2mA8FDk8UK40G/36FrLMuHEDBTb7YfBObYyllz/wD?=
 =?us-ascii?Q?+6xOmP4116RFXHDUsW2IB6nhgTLWcRp0wUOpjo+SLOOYUjMOhG5GOuPWylE3?=
 =?us-ascii?Q?RDHxqv0UEjVD1dKTjZ9zjF5/uB+csCPfvZynpHmKoug4s2oR3a4XAafNO1wi?=
 =?us-ascii?Q?k8zBGT5jd4LofEtXwteMgxBRlsnZyYFqE9wddblE6YmXQQbODGAdYLzbB7dQ?=
 =?us-ascii?Q?etWbTtFcZ/lfIscU31P7hr3MBCwZa5QA4JvPE+KXQhqjPP9HdHRLClWIJ0DV?=
 =?us-ascii?Q?9M/FFdLaMczmdFZbbAK5gHoczakSqiVMAR+9cIIz/l2MDv/IJB/AxAdbTNsU?=
 =?us-ascii?Q?FPWn6G6X17D34vudvJNfNKKV2XfYi+H8d5vLzmIEn5mMEkR22nmHWwkSha94?=
 =?us-ascii?Q?4FlHrNOZuJ6b3Ey+fS6iv6jVhGlivPq0fcL3RleInFWLtdmckRpj5C9wSk+P?=
 =?us-ascii?Q?FUlgw/sG79tqg0C1tv9Hf+MHC7zYmeHgSI0gOShvvE9n813RJ+IQduaGfZ/D?=
 =?us-ascii?Q?NxgbAGeIzDM19q3nb+o+iei7/BfUYtMwxVnvkY8TgeKCX2E+oLzyykH9aOFA?=
 =?us-ascii?Q?eTIkm/CkIUn7zV4plFo9xrXToQ4XzUT70clJ9D1AD5Y0ueYx+vrEG/BHmLNp?=
 =?us-ascii?Q?2sTlxESMGLLMvWJTqwkO74E=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <326122240F23884FB62592CA74DEBCDA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd920ea-4f45-486c-ad09-08d9eb1d8865
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 16:10:32.3017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 67NUfXKqX0+MtKqZ7rBmxaIsyQgSUz4NWO7zRMFZvW0BFvZVgBrSXwTSXZm9ibXGErz+iyOlcyUw8iozw/xelQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8299
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 08, 2022 at 08:07:42AM -0800, Colin Foster wrote:
> # ethtool -S swp1 | head -n 5
> NIC statistics:
>      tx_packets: 942
>      tx_bytes: 48984
>      rx_packets: 764
>      rx_bytes: 37808
> # ethtool -S swp2 | head -n 5
> NIC statistics:
>      tx_packets: 946
>      tx_bytes: 49192
>      rx_packets: 1
>      rx_bytes: 46
> # ethtool -S swp3 | head -n 5
> NIC statistics:
>      tx_packets: 1
>      tx_bytes: 52
>      rx_packets: 1699
>      rx_bytes: 80658
> # ethtool -S swp4 | head -n 5
> NIC statistics:
>      tx_packets: 0
>      tx_bytes: 0
>      rx_packets: 0
>      rx_bytes: 0

I understand what confused you now. These are software counters patched
in by dsa_slave_get_ethtool_stats(). They are in no way the counters
from felix_info :: stats_layout, please compare the strings!=