Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220208081443.28210-1-zhanglianjie@uniontech.com>
 <108cc1b0-8630-7f41-5ef9-73df69d250e9@amd.com> <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
 <00c5b899-ed35-44a0-6b22-bc3e882e49d4@amd.com>
In-Reply-To: <00c5b899-ed35-44a0-6b22-bc3e882e49d4@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 8 Feb 2022 12:37:17 -0500
Message-ID: <CADnq5_OukNR9N+iqd63ZT7Jrk0C7k6n6mCVR93WdG=96vqSS-g@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     zhanglianjie <zhanglianjie@uniontech.com>,
        David Airlie <airlied@linux.ie>,
        PanXinhui <Xinhui.Pan@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied the series.  Thanks!

Alex

On Tue, Feb 8, 2022 at 3:33 AM Christian K=C3=B6nig <christian.koenig@amd.c=
om> wrote:
>
> I think so, Alex will probably pick that up.
>
> Thanks,
> Christian.
>
> Am 08.02.22 um 09:28 schrieb zhanglianjie:
> > I am very sorry that I submitted many times due to the character
> > coding problem. Can PATCH V4 be used?
> >
> >> I'm scratching my head what you are doing here?
> >>
> >> That's the fives time you send out the same patch, so something is
> >> going wrong here :)
> >>
> >> Please double check why that lands in your outbox over and over again.
> >>
> >> Regards,
> >> Christian.
> >>
> >> Am 08.02.22 um 09:14 schrieb zhanglianjie:
> >>> after the buffer object is successfully mapped, call
> >>> radeon_bo_kunmap before the function returns.
> >>>
> >>> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> >>> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
> >>>
> >>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> b/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> index 377f9cdb5b53..0558d928d98d 100644
> >>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct
> >>> radeon_cs_parser *p, struct radeon_bo *bo,
> >>>       handle =3D msg[2];
> >>>
> >>>       if (handle =3D=3D 0) {
> >>> +        radeon_bo_kunmap(bo);
> >>>           DRM_ERROR("Invalid UVD handle!\n");
> >>>           return -EINVAL;
> >>>       }
> >>> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct
> >>> radeon_cs_parser *p, struct radeon_bo *bo,
> >>>           return 0;
> >>>
> >>>       default:
> >>> -
> >>>           DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> >>> -        return -EINVAL;
> >>>       }
> >>>
> >>> -    BUG();
> >>> +    radeon_bo_kunmap(bo);
> >>>       return -EINVAL;
> >>>   }
> >>>
> >>> --
> >>> 2.20.1
> >>>
> >>>
> >>>
> >>
> >>
> >
> >
> >
>