Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b5c87b7d-fdb4-2288-5c21-c666fdd40005@kernel.org>
Date:   Mon, 7 Feb 2022 03:45:06 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Nathan Chancellor <nathan@kernel.org>,
        kernel test robot <lkp@intel.com>, stable@vger.kernel.org
References: <20220207084404.212017-1-krzysztof.kozlowski@canonical.com>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <20220207084404.212017-1-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/7/22 02:44, Krzysztof Kozlowski wrote:
> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an
> early reset driver for SoCFPGA") uses reset controller, so it should
> select RESET_CONTROLLER explicitly.  Selecting ARCH_HAS_RESET_CONTROLLER
> is not enough because it affects only default choice still allowing a
> non-buildable configuration:
> 
>    /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq':
>    arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: <stable@vger.kernel.org>
> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   arch/arm/mach-socfpga/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
> index 43ddec677c0b..594edf9bbea4 100644
> --- a/arch/arm/mach-socfpga/Kconfig
> +++ b/arch/arm/mach-socfpga/Kconfig
> @@ -2,6 +2,7 @@
>   menuconfig ARCH_INTEL_SOCFPGA
>   	bool "Altera SOCFPGA family"
>   	depends on ARCH_MULTI_V7
> +	select ARCH_HAS_RESET_CONTROLLER
>   	select ARCH_SUPPORTS_BIG_ENDIAN
>   	select ARM_AMBA
>   	select ARM_GIC
> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA
>   	select PL310_ERRATA_727915
>   	select PL310_ERRATA_753970 if PL310
>   	select PL310_ERRATA_769419
> +	select RESET_CONTROLLER
>   
>   if ARCH_INTEL_SOCFPGA
>   config SOCFPGA_SUSPEND

Acked-By: Dinh Nguyen <dinguyen@kernel.org>