Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1766294pxb; Wed, 9 Feb 2022 04:08:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzX2UypqANhrXQHf3/wLLMCOavwo6zllEsENr/qMEVr/G2NBQfG0qYtZZ463qHFwierW/W X-Received: by 2002:a63:e64d:: with SMTP id p13mr1647458pgj.233.1644408533409; Wed, 09 Feb 2022 04:08:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644408533; cv=none; d=google.com; s=arc-20160816; b=UUNV8lThPZYVxoQf7josRWPgjQdJxKeZV6rHUVaEdbSfih0iHcHbRt4KP8gOrLPjra gY3slzcgAKwFfG5H0SEVxVXhVGveqXrySJ+f5ywrSrO2oayjJsIaz6DyYCbnttpPHV4f nkUCvURe69Urx8aQH4gkCzQRqBaOun+cQNvPnOuIKFVVYU7szoc1c6UXYi7BAk0OLykq iqCcxAeu9JKeqYThrzyta/pBaUWDL+DKdQ4YseuICVbExVDNUS/xZeH/BztkCNxksXMm icnYSZfW32chGDag0Z0bAvqMjF/6n3LOVUq6yjMwilEWuIcr0JfGVpofpmtMLJeyE1o1 8tHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=G0OaMyhQqkQXas6ctfRHC5LROiyByhHqiT789fOBTGc=; b=VNiKJlGW4CgMioZMrrDwncI1Le8I9Yie0UrtZobRZRoltPtOt/Ini3JWSiRv07by91 Qi6FyA/C6jLC0vQEBwBnQZbTdL55vUL3t02h5FVPcfPmRGefYM7zMoqfemHQgC2VCVJQ t8gJdoRjov78yKSLxbwx0slVHOKT8gla8Sx/HbqFdpX/qx+hIPCfVW6jqp/PiC2w6w2G Vu/hhBCIZnH+/FBSxKnCezMGvlR5F6ycllZcaxWw6fPDyrmZ67be+/onQa6RLu/zKLxi MXmQaueFvEW6yHQbxY2iYSdb6n487O0XLl+4ZBTiuuSZjncoRvxCv4sa4FOwmWSkHjE7 f4WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GsZfWIC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id p15si14802485plo.507.2022.02.09.04.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:08:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GsZfWIC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 287B9E083DC5; Wed, 9 Feb 2022 02:07:25 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383088AbiBHQWK (ORCPT + 99 others); Tue, 8 Feb 2022 11:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383073AbiBHQWI (ORCPT ); Tue, 8 Feb 2022 11:22:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39BC1C061578; Tue, 8 Feb 2022 08:22:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB40F616D9; Tue, 8 Feb 2022 16:22:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3387DC340EC; Tue, 8 Feb 2022 16:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644337327; bh=sXbCfyUpCRgkdJeoXxIsdIqWpDpDr+h2fd3sTTQiBW4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GsZfWIC+pXBcJXMk1q3KUH8Cx12/BrNymYL16J79pzY/l8t0dHpJQL/WmXUSxeao5 EgHCmZCmt/Yveslj2EZQb/widC6i9hc1RI50Jf2+Tj09CAJFsIZbUrwTWAOc2q9uKV bhug3/MFFJOS0bdREkpJTvY3aTtaP26U8NntYc4B+rK4e+qJJU/QC2RstCQx8BDqtM Vjj/LJ9qRWx949tzpqh0ZiDqEVPOsmkA4d3yw/xrk0MiVWah/ds56Zxgy9G2in5bri Os7SsQITtQ05pUQI+hIMvgDythuZ07dazEdGseH7fnYaOv7SEP5WvxwmzmeiAM8kbD sg6ZQPX4niNRw== From: Will Deacon To: Miaoqian Lin Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org, Rob Clark , linux-arm-kernel@lists.infradead.org, Robin Murphy , Joerg Roedel Subject: Re: [PATCH] iommu/arm-smmu: Add missing pm_runtime_disable() in qcom_iommu_device_probe Date: Tue, 8 Feb 2022 16:21:53 +0000 Message-Id: <164433576813.932880.12030091721881106363.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220105101619.29108-1-linmq006@gmail.com> References: <20220105101619.29108-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jan 2022 10:16:19 +0000, Miaoqian Lin wrote: > If the probe fails, we should use pm_runtime_disable() to balance > pm_runtime_enable(). > Add missing pm_runtime_disable() for error handling. > > Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm-smmu: Add missing pm_runtime_disable() in qcom_iommu_device_probe https://git.kernel.org/will/c/93665e0275a2 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev