Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1768027pxb; Wed, 9 Feb 2022 04:11:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzA+H6Yh8ig7NqV0hzs+Zd3B220iBM1xeohBM0PhiYroMvxDU022HyBCUO1DGjrbwcODt+6 X-Received: by 2002:a17:902:e885:: with SMTP id w5mr2149372plg.156.1644408661793; Wed, 09 Feb 2022 04:11:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644408661; cv=none; d=google.com; s=arc-20160816; b=B/NFGsiId9dE8u5YUUr11aoozqvv5oMeoeQvoMkP453QHJ2z57UpCgEoybD223Cc1U JiadrAMKU/4FCF8tGQ7QrXtUEjRoHWZVVKFOzh8qgjj+QUbFlU565QI4wv7l9TdbYHcs +rj8Uxh/kbqDgIceVTaoAHRMkOKFwUDzTx6c3K+qo9xt7H3CVZNL6n6gy5TQfKFFr13k eCQDD/nhikPQVt1s/quMNpr+ojC8uZjbPkxbbeNcNkXPrVaQolSqN7kbfWMumYnwpLW/ UwMJgGhcPca+0LBxkKaPNYyMaL3WMrIlgBmVw0iRtBearjRy05CcqObh25jAfOFMaVWz Ms2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=U3YWRJiOX6r2DiP9iWkoebtSk7wb9LQgDyPaYKJpHzg=; b=WH1czYiIusGeS63QoZ94a0aZlqp/Se9YV+N4uZ6k4hEEZH8vrs0+m/qggtvkRVVriI B3BddE8eN8v+yXmb4pzdR+f47lLk+bVK5cIlYyC70QqWMlLMlZ9H2IW5CciqDNPyDhVF 5MIPIPK6iqRfHiI6tYwRd5XdznanOCHNAL5wmCp/H+1qOP1b50V0wAv/3H6Va5r9aqgh euG5yYP2hqBvhqG3cgen8rzNllXziFZ7juxzLEYyEmLgA3eUWJPgqCL1KefRYetcjA8V ngEhias7w4FzKYjMgSqqCpjGBPzF9EsqShsyMCn5X/dE7NKXTI1kbY7Ci4oLNXj5TmOY SBkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="nXjf/f5L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id lr7si6066872pjb.60.2022.02.09.04.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:11:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="nXjf/f5L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4329BE086224; Wed, 9 Feb 2022 02:09:05 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236745AbiBIEOA (ORCPT + 99 others); Tue, 8 Feb 2022 23:14:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347222AbiBIDjV (ORCPT ); Tue, 8 Feb 2022 22:39:21 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F19C043180 for ; Tue, 8 Feb 2022 19:32:11 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id i186so2082965pfe.0 for ; Tue, 08 Feb 2022 19:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U3YWRJiOX6r2DiP9iWkoebtSk7wb9LQgDyPaYKJpHzg=; b=nXjf/f5LQhRawIBVlV+uE2HRNSdBDqb1TVkY42Ucyl1AFQmJYizT78Mo0V0i+FRlJX rkXkKyZSaZlcW4b7o4vnjdFAzIGsQGWZtTQ7/n2MDm3LOZgspH4jaup9YKX7Wx3zDbR3 juZ78ajOOZPzoQDNqX6MLmJvQWkpMBlyfbem9XPtvyItr240K06KEWR9y9RDRFM9UwDD /e8srRI7OVqLv/UhiVxWE+OcLqZ8CcEnoPei08wnD8RIWMa3AOL1Zqhoer3LI2XKwnZL AAYXEaEfFaasSmXgNlKy3+Lj+QEo70qkWiARvzdtca4LrlUlK247CO0X+6C1oTXh2ih3 Qa6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U3YWRJiOX6r2DiP9iWkoebtSk7wb9LQgDyPaYKJpHzg=; b=eNdjHCFUwzRG6dPnDEkCUWQrJyjaEJ5yS55cRcgdS78ixuD7881AQqERh/YUVkSpwR 9zFKq6xK0nPN7KFeKAXzhJaRfWByFwwFm2lA15Fql3DwMQ174MSCYNbkWiCtu6Eo7Sq6 roIadbwbOkJLDbbang6QbDqdPTFcBQ1fUVZF20yZs2znetDFSlErDukNy4wORgA2UMgZ GOjtuHWH4rzExeVx7wix4P55BqLaVJFKm3W2vOZuMthZc9uv5G8aoNdApwbda2D/NaG+ aVLK3jsGBMhxloSB07k91bpRPoAtPjOFvKH1rYSI0cqj6RmuuIJOmh1EMoBomqUHLKAj LEIA== X-Gm-Message-State: AOAM531GLFZEmvYEXUHc0UzNe80DM3xoSep/ZIi7gaDYnRCtmFeMegEe Q8766GXBuiWe70b8brMJgm1SQA== X-Received: by 2002:a63:2c92:: with SMTP id s140mr372406pgs.448.1644377530580; Tue, 08 Feb 2022 19:32:10 -0800 (PST) Received: from google.com ([2401:fa00:1:10:4b6f:f14d:be50:86a]) by smtp.gmail.com with ESMTPSA id y15sm17012526pfi.87.2022.02.08.19.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 19:32:10 -0800 (PST) Date: Wed, 9 Feb 2022 11:32:07 +0800 From: Tzung-Bi Shih To: Prashant Malani Cc: linux-kernel@vger.kernel.org, Benson Leung , "open list:CHROMEOS EC USB TYPE-C DRIVER" , Guenter Roeck Subject: Re: [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Message-ID: References: <20220208184721.1697194-1-pmalani@chromium.org> <20220208184721.1697194-2-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220208184721.1697194-2-pmalani@chromium.org> X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 08, 2022 at 06:47:18PM +0000, Prashant Malani wrote: > Move mux and role flag checks inside of cros_typec_configure_mux(), > which is a more logical location for them. > > Signed-off-by: Prashant Malani Reviewed-by: Tzung-Bi Shih