Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 8 Feb 2022 10:34:57 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, alex.williamson@redhat.com,
        cohuck@redhat.com, mgurtovoy@nvidia.com, yishaih@nvidia.com,
        linuxarm@huawei.com, liulongfang@huawei.com,
        prime.zeng@hisilicon.com, jonathan.cameron@huawei.com,
        wangzhou1@hisilicon.com
Subject: Re: [RFC v4 4/8] hisi_acc_vfio_pci: add new vfio_pci driver for
 HiSilicon ACC devices
Message-ID: <20220208143457.GA164934@nvidia.com>
References: <20220208133425.1096-1-shameerali.kolothum.thodi@huawei.com>
 <20220208133425.1096-5-shameerali.kolothum.thodi@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220208133425.1096-5-shameerali.kolothum.thodi@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NTrqVn7dF2iEjQnB1INrQ+UdHAQvLc+2o27AQXQsppWzC1Mn4Ot0ipLp1yRF?=
 =?us-ascii?Q?OQdyVTNQ+m+aE+efRmsCJ0Lid53FvyX4kOmKtWWzgFJInWpMgl6EIHv3lTgC?=
 =?us-ascii?Q?GkLGGQD9vCR2XFjjJ+ZcSH3RTs5p9Aob8g31zmE1UXNp25u4cbfAVn2TIayN?=
 =?us-ascii?Q?Lnp75OI6c4hbMqUe5WfWbbHpVZVYPo17EwvyLT67CF/YDWkK9RsXvMOBABx+?=
 =?us-ascii?Q?3K27FX03CamlH73xeCMbQzuqtvf4Ss5DL8l1y1Mqn5nYy7xm/MCaL5uveatO?=
 =?us-ascii?Q?qKQVY38qpp8BGdTlFpTApymDT1VVrNuk4cBDDm3/Aw1wGc+E3+CBZHrPV8GU?=
 =?us-ascii?Q?kI4apDf3gipltJmxyWVg/ZFVKGzHDhFY80bIjET3HpQDjwu5i2ldkGCsVM8K?=
 =?us-ascii?Q?2tDtaLahvd35Duabc2NQHO9fYODkcnMvbW7M2r+M40DklyTb5OTlvNV4EUd0?=
 =?us-ascii?Q?Ua7vp0+nB0SCRtv1EjSXQ9LgI/frU6Nn4IDKz7dx2BOt4Irwfygk71XOmdbr?=
 =?us-ascii?Q?Q+IaG8eBk8ciFw4HD4J9iFRgoN7rITLraoSQ8ZaCY28G7MRhUVgaH4hxmIP5?=
 =?us-ascii?Q?Gltyo915EHBcupdS5MTe6GGsagNooQjjzGEw4k7kpQ9dFMrzYz1KvCPMCF2H?=
 =?us-ascii?Q?bchjVdeaV0rupJO8Imwud8bDvDIpVidw4ccv0+Je/YrWHxElpT05GSt0ZRAl?=
 =?us-ascii?Q?o5qUoMvEf0MiBF7NVdWjnOGjQmWStYSm65Tm65Wfr4vOieTBYB5Ao9BWM5iw?=
 =?us-ascii?Q?JF0B8RXUCNgu3m+Fqgq7r/iwzUp5B0Pb+0YNmwDwPHcACxer4OsKMC94hqow?=
 =?us-ascii?Q?KctyDpyv/gujOgYd2JN0ACf4xcvV8bC/YOy3ZTLV6coAedofahKJRTah5+8f?=
 =?us-ascii?Q?cwycJSsFk85qqj89Pji+y43NCTHtO1qAlk/BpNHmb1Pg6eGeRiAgUWrX1XPU?=
 =?us-ascii?Q?PIxyGfKhNoIyIa39NfL/mjaOARWSAT6VYqG2E8gMka2QlLg2MicB4zEkLUV3?=
 =?us-ascii?Q?aIsHs7f5J2+Ghdj1uHMBaZd/x+2xffLMTDuztUXm6FTK62FcDDtBFM+Bf51M?=
 =?us-ascii?Q?szfsTi9b0mKzz8EsOBwTk4URPXod0OHO+ZWSQ63/X/9rfyi4FUAjf7xfKmx3?=
 =?us-ascii?Q?cflfs8RGD9N7ei6sQ8p2zQ61L/8vGLYgpQMzQEgXxKmhtup4AOurT5o4z3+W?=
 =?us-ascii?Q?bvNbNkKBYoZDPsIkeEVAd0Cov5Sb6Ro2QTCYcpqlQFw7b9c8tqQ+9RZndL9N?=
 =?us-ascii?Q?cnh9Z2dSeFlMFO47gamjetctpdt0PY9gwYQX/WGa2Oxe18e+xjBJz4oGKtog?=
 =?us-ascii?Q?HyDsqxZeQDgNAd/ZA9U7r1vlbnh36QsoFcNVjSra1WR/4cIcptZ/bFVKHi2J?=
 =?us-ascii?Q?+OiHa03yxgZJyPhPl320q2C80VyBgbixU5EqyLgQBSWGTsqCwUX5avb5WVdo?=
 =?us-ascii?Q?Awy1cojHirmqUhMM4CHP4sgpL4MYieTRIeVHQ4U+phKGjEt/DaXft7nL/xgk?=
 =?us-ascii?Q?sR3lIpKqHltMh8dxTJ4SLnLgTvwPFspCoE6GPIfP7whGuXgBx6hV5KnAN5hg?=
 =?us-ascii?Q?i3XrbiLj2cN2iVtdC3w=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b43e068d-b102-48cc-c915-08d9eb102eb7
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:34:58.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VhZGwclAoAvXU5P93WLfJOxN9lWWTZoN/z9r70AugOLcA38mOSrLTNfjeeg5n0lH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1388
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 08, 2022 at 01:34:21PM +0000, Shameer Kolothum wrote:
> Add a vendor-specific vfio_pci driver for HiSilicon ACC devices.
> This will be extended in subsequent patches to add support for
> VFIO live migration feature.
> 
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
>  drivers/vfio/pci/Kconfig             |  9 +++
>  drivers/vfio/pci/Makefile            |  3 +
>  drivers/vfio/pci/hisi_acc_vfio_pci.c | 99 ++++++++++++++++++++++++++++
>  3 files changed, 111 insertions(+)
>  create mode 100644 drivers/vfio/pci/hisi_acc_vfio_pci.c
> 
> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> index 187b9c259944..8023b20acf66 100644
> +++ b/drivers/vfio/pci/Kconfig
> @@ -44,6 +44,15 @@ config VFIO_PCI_IGD
>  	  To enable Intel IGD assignment through vfio-pci, say Y.
>  endif
>  
> +config HISI_ACC_VFIO_PCI
> +	tristate "VFIO PCI support for HiSilicon ACC devices"
> +	depends on ARM64 && VFIO_PCI_CORE

You should try very hard to make this driver compatible with
COMPILE_TEST, I think it should not be a problem.

Jason