Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 7 Feb 2022 17:30:11 -0600
From:   Rob Herring <robh@kernel.org>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     pavel@ucw.cz, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: remove ide-disk trigger
Message-ID: <YgGrg7NgHnK5chrE@robh.at.kernel.org>
References: <20220125210537.54036-1-clabbe@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220125210537.54036-1-clabbe@baylibre.com>
Precedence: bulk

On Tue, Jan 25, 2022 at 09:05:37PM +0000, Corentin Labbe wrote:
> No user of ide-disk remains, so remove this deprecated trigger.

Strictly speaking, this would break someone if they didn't update their 
DT. But it only looks like only a few platforms used this and they were 
fixed in 2016. The commit message should say all this so I don't have to 
go research it.

With that,

Acked-by: Rob Herring <robh@kernel.org>

> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> Changes since v1:
> - remove also DEFINE_LED_TRIGGER(ledtrig_ide)
> 
>  Documentation/devicetree/bindings/leds/common.yaml | 3 ---
>  drivers/leds/trigger/ledtrig-disk.c                | 4 ----
>  2 files changed, 7 deletions(-)