Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Christoph Hellwig' <hch@infradead.org>,
        Stafford Horne <shorne@gmail.com>
CC:     LKML <linux-kernel@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "Jonas Bonn" <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Randy Dunlap <rdunlap@infradead.org>,
        "openrisc@lists.librecores.org" <openrisc@lists.librecores.org>
Subject: RE: [PATCH] openrisc: remove CONFIG_SET_FS
Thread-Topic: [PATCH] openrisc: remove CONFIG_SET_FS
Thread-Index: AQHYG/BjkR+ecsCi7UOyp98rZRODA6yIU2uA
Date:   Mon, 7 Feb 2022 17:14:43 +0000
Message-ID: <3744dcbbf2874875b023548aacdd8b41@AcuMS.aculab.com>
References: <20220206013648.3491865-1-shorne@gmail.com>
 <YgC/8ng5WX6Nt104@infradead.org>
In-Reply-To: <YgC/8ng5WX6Nt104@infradead.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Christoph Hellwig
> Sent: 07 February 2022 06:45
> 
> On Sun, Feb 06, 2022 at 10:36:47AM +0900, Stafford Horne wrote:
> > Remove the address space override API set_fs() used for User Mode Linux.
> 
> This ain't UML :)
> 
> > +	return size <= TASK_SIZE && addr <= (TASK_SIZE - size);
> 
> No need for the inner braces.

Since TASK_SIZE is actually an address wouldn't be better to
swap the condition around (in every architecture).

	return addr <= TASK_SIZE && size <= TASK_SIZE - addr;

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)