Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 09 Feb 2022 08:09:24 +0100
Message-ID: <s5h35ksqzx7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mohan Kumar <mkumard@nvidia.com>
Cc:     <broonie@kernel.org>, <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
        <thierry.reding@gmail.com>, <tiwai@suse.com>,
        <jonathanh@nvidia.com>, <spujar@nvidia.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication
In-Reply-To: <20220209042326.15764-4-mkumard@nvidia.com>
References: <20220209042326.15764-1-mkumard@nvidia.com>
        <20220209042326.15764-4-mkumard@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 09 Feb 2022 05:23:23 +0100,
Mohan Kumar wrote:
> 
> --- a/include/sound/hda_codec.h
> +++ b/include/sound/hda_codec.h
> @@ -240,6 +240,10 @@ struct hda_codec {
>  	unsigned int single_adc_amp:1; /* adc in-amp takes no index
>  					* (e.g. CX20549 codec)
>  					*/
> +	unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger
> +					     * control flag
> +					     * (e.g. Nvidia codecs)
> +					     */

This flag is specific to (Nvidia) HDMI codec and referred only from
patch_hdmi.c, right?  If so, the flag would be better put locally to
struct hdmi_spec instead of a global hda_codec.


thanks,

Takashi