Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH] tee: amdtee: Make use of the helper macro LIST_HEAD()
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Jens Wiklander <jens.wiklander@linaro.org>,
        Sumit Garg <sumit.garg@linaro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
References: <20220209032745.38570-1-cai.huoqing@linux.dev>
From:   Rijo Thomas <Rijo-john.Thomas@amd.com>
Message-ID: <302e8426-5a22-23dd-2b3b-7eb6d0ee2e8d@amd.com>
Date:   Wed, 9 Feb 2022 12:46:36 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <20220209032745.38570-1-cai.huoqing@linux.dev>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REFpQ1VESmRJZVJ0cWplMS9wMkpqMFBpbmtNNlJvd3JhTXlMcXJpNExNMERY?=
 =?utf-8?B?YWU1RDJiZTdKbHNaQWF2SDl0MTFESXlGaHdTd0Z3WmIxTDM1V1RTRmo4aENX?=
 =?utf-8?B?c3Q2Rjc1cHNscjU1dWZlaE9qVGJvR2F6VzRoMXhJMVJleEVwUFMydnJ0RDdi?=
 =?utf-8?B?ekhKREsyQUt2bWFNM0ZOUTcxcVF1aEZDR2hoeG1IQ3d4SHJHZGJYVlcwN0JN?=
 =?utf-8?B?aXFFNHMzVFFkNjllWEVVbWhWSW5GTnhBa3NmeVk3N3UrNnFFMVZ1R1JDYmRv?=
 =?utf-8?B?YkhBYVFhci9iR2VxZXNhSkFlL3RhckYyMVVSWnV2OGtxUWhQWEJuTkZYdmpR?=
 =?utf-8?B?UDBMdTNSaEY3eWNuREZ0enpLajI2OVFKUFJwOUhWS2V5NFd0QmlkMmNMUXV2?=
 =?utf-8?B?VlBvVURMN1dvVE5DY1pwcEpPQ3hWa3hXZkxBckFodTVxTVZUUld5SzBDdEF3?=
 =?utf-8?B?UlVkTnNqRVROdDdOTW93amNmT0t2YjBaalFqaG0wZkQ5aTBaWEZsUXIyRnRn?=
 =?utf-8?B?MEJtTVVjeko0RWQ4SGluZW55RS9BSlFUQnJsM1llOHJXUWVabHZCK2toM04z?=
 =?utf-8?B?NVJZdC9IZjdTdzhPOFBla0l3a2JoUjlNajZNcGdYdDRvY3F6Ykl1Rk1hRWhD?=
 =?utf-8?B?TjVWWGpIeFdjY0k3OXVCdThRU2QvQlFDL0xLbVFRZHFDSFYwWnFOd2htaHdQ?=
 =?utf-8?B?TkJzUEFKQjdoNUVHNGRZNVlXMzh6Zi9McTlUNUlPbTJseDhDaXJaaWlxUzZE?=
 =?utf-8?B?ckk0cVY2OXhuZVMvUEVLUDJ1NnVYNjhoNUo4c215ZGdlOVhaSDFIY2NVR2NY?=
 =?utf-8?B?MHF5dDh0SVh2K1JMM1J3bUFPeHNrQkRmYkdzWitmRjl1WWlRUGZpYk5YckdE?=
 =?utf-8?B?aVczbG5ZKzNma3BzQ1U4VnA1eU1VL09ub1J2T0NhUlRHVTBsMEoxMEtqa1J3?=
 =?utf-8?B?blVYNHFWRWJXYTR5ZmlsR2ptOFJzQUlMb0hBK0QwbnphSWRJeTdHeURkdnR5?=
 =?utf-8?B?clhBOWhlbXJDRFlzMGZteEFlN09ibExVd3AyVUlNeGRQaWVkVWhYcEVwS1ZQ?=
 =?utf-8?B?emh5bGFpVy9WV0s5Q3U4VFZVN01oc2s4c205VFUyMmlQL2V3QzBiT0Rxdjdo?=
 =?utf-8?B?U0JVWW1CaWRiL0wvdWlzSjRabUF5WXppbi90Z3c4TW9LR2xvT2NIa3lWa1NY?=
 =?utf-8?B?dllKbEJHRm8yVk8vamhnVHBpckdBTTlzWXFSTHZ4eVVVcFZLMU85YVRkN2lL?=
 =?utf-8?B?bzA2UWhVWUUrMzFURTFnZUVWUFIzRTFqbWRSR1VxY0RBeFVMOFdGK2pLaTVn?=
 =?utf-8?B?ZzVrVHBVZ1VuaWsyMG9OOWppRkRHanR0cnRQT1NtRWtreDlUVXB2MXNsMjNO?=
 =?utf-8?B?WUxNZHJXMmYvaWt6MGExaWx3SFcwaWt2K3lxbVpicm5Nc3hyUTV5NmlEdnk2?=
 =?utf-8?B?QzlyN1lUVmlQWU9xdWpmdkt1NmFyNUlaYWRSVDlvS0JWbUNESnV1c3BBYlM1?=
 =?utf-8?B?MzRETDczVHZ1Z1hLeUZMTTJqOS84MUVsZjRhTEZLOFhPdFA5UTdObEhoSnFv?=
 =?utf-8?B?bHUxQ2ZXNzE2bHp0WHVxU2xCYmxXYnpQOE1NeVhTRUdBbi9JZmdEUUN1V1E4?=
 =?utf-8?B?a1lLOTZWYTI5T0dUVXljY0tBWFFrbGtMaVYwL0xsd1d4OG5GcEExWkk0MXRi?=
 =?utf-8?B?bGg0dzkrRGpFeUZXMVN1UUFrTkl6dW4yaEtXTC9QalV4blJlV0RvTEw5bWpX?=
 =?utf-8?B?T2kzRHdMeXRXS0R0R0hmMlFscGE5dDVoS3VEWDEyYUJTQlAzOURRL2dpUU9l?=
 =?utf-8?B?ZVgzaUZMV04wamF5WnlnZldzclhKcTNiSXVYd1NjekpPSC9rMlZFTUlYTFRU?=
 =?utf-8?B?ai8wZnhQZzFwUFVocm5VUzFVMEpEZlRlSTBlU3p0VmFCd2VuYzZFbjN6UkZq?=
 =?utf-8?B?TldaaFpEQmdSN0pubk9MWnQrVmZ0b01KTUpUTGQ1eUJuVEhVVTQ5N0kyYmJN?=
 =?utf-8?B?N2xlaWErM05RK0tTQlZyUEYzblNJTFpucEdSRGVkK2Roelh5MGJjWkd6bHR5?=
 =?utf-8?B?eFJsZ3RpWkxUNTZhWVk5N3p0YjM2Vk0xeWN4cEx4WnllVTY4blVtSHQxUmZW?=
 =?utf-8?B?NmorK3VZN21jOTJWM2l5WTQ5SXhXUjJWaDdRS0tjNHBwdmRJWkN1Kzd1T3NZ?=
 =?utf-8?Q?ljlHOT2x4i+q2Wr0pfIiLpI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a454d120-d902-4588-dcb9-08d9eb9c22ae
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 07:16:48.1758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jKW3NMOskjbp3+XaLQhPOz+ApeNEjG0fNy3hG150VaoeZLL3NIQplRjnhpIF05ElPgUZO9XMHJAkHpMcAOHcGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5042
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/9/2022 8:57 AM, Cai Huoqing wrote:
> Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> "LIST_HEAD(head)" to simplify the code.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
>  drivers/tee/amdtee/call.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
> index 07f36ac834c8..cec6e70f0ac9 100644
> --- a/drivers/tee/amdtee/call.c
> +++ b/drivers/tee/amdtee/call.c
> @@ -122,7 +122,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
>  }
>  
>  static DEFINE_MUTEX(ta_refcount_mutex);
> -static struct list_head ta_list = LIST_HEAD_INIT(ta_list);
> +static LIST_HEAD(ta_list);
>  

Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

Thanks,
Rijo

>  static u32 get_ta_refcount(u32 ta_handle)
>  {
>