Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1797186pxb; Wed, 9 Feb 2022 04:51:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6owPkb8XhXUinPssytgUDr8/koBGG/EEX9f3Q/5T84tYp4twUfXpPeav3UvG881VgtsEq X-Received: by 2002:a17:90a:a385:: with SMTP id x5mr3240658pjp.129.1644411099391; Wed, 09 Feb 2022 04:51:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644411099; cv=none; d=google.com; s=arc-20160816; b=p0FHa2pHUXvlYD8SD/+0T8qKP3AODrm1/+5wVjEHA06Pen9CVc5i6ekLYx32qYQk4W /Dl4JLhbN6sgfoS29OkL3Gl107LtfD3osI6IYzoer8wEKz5y0FLV0m6hyzg+PueRV4/P fvRcPsdN235g7bmO4kvQG9/+uAv64teLWMrVSStp03NPkHg8ikxTrQ68uaIcm7uiuj41 8YRr5qMC2gaGqFiJyFHvHTvWLSrSfclTXMuSSDLXRN8lYjG7Fy2fOiixoZfk12AmeLFK yb6N3J9TKYb7OTqvxkhqNelyMf2xf4SJnN+Pu9HxT6rttJ7QgcMdg4JGeviIgvWnnZdt m33Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1QlWDn92UQ5AsU9+yqgoQ21HGVUJbCNA19V+fHfieKE=; b=PWsB72Gx+X5n7VyOn6IzGGUEP17/Xz01tRrpmbBx8lf/UnwP71yPxfKSAJqBOsHchR empC6JincgVjNeky4p1KhHbsgmBm8mlfcvH2nVr7wyxwUOiKu0zJJiEgzhmKLXn2jFZM rkGTKUsZ5AAv5lf5BZ8zVB8cg++ol39FhRZFkrb0YzMmepm6l2IEpmktck5kpvSHyj88 PeRSlmG6moz1yzynvd4T8ZFrOJXN0/b8nnySr5ZVXMg4aOKqy6rev69ITAtDfUizP74/ a28aIZD6Ja3N+8xV0zNO0yN4ts1ceZVeB9ajA+zfZ2hYCRQ5caknhWLHpwh+HBVe1GzV N89w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tjV0CgiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l184si16301341pge.734.2022.02.09.04.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:51:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tjV0CgiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 70241E15D7AF; Wed, 9 Feb 2022 02:31:00 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239297AbiBIH4i (ORCPT + 99 others); Wed, 9 Feb 2022 02:56:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiBIH4d (ORCPT ); Wed, 9 Feb 2022 02:56:33 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278C1C0613CA; Tue, 8 Feb 2022 23:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1QlWDn92UQ5AsU9+yqgoQ21HGVUJbCNA19V+fHfieKE=; b=tjV0CgiQGKSmPUvKTFd1KwxTrb cQ2xvuqbUx7Z6ObEOmVImNzBRZdZ0bCfqWuEuzl4nnXqsNQFNMR2e3TjHSjj+uld3eLo+G0NufLTq e7aAXIajAeiHDxOk7uV8sReREWLIg68eoRxowvYIdBwnvDG3N3Bkn6RMDGHKXM+e8/l3gfip08IMW oTXyQFQXMpRaybO9dliKTKPX2hy/VJ9d8ErSpfX7KEz3b/rq0a0ChE0IHH1hMWn2xzaQASt5xTa5w NV8aisWryFAvy2W61auRUHBnurL0mJ40NuaSZj7pNUC542KwSWnBgU9GnER4xGKtPgKFQBUxshmR/ Rd+BaKlg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHhq6-00GYV7-64; Wed, 09 Feb 2022 07:56:34 +0000 Date: Tue, 8 Feb 2022 23:56:34 -0800 From: Christoph Hellwig To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Christoph Hellwig , Greg Kroah-Hartman , Andrew Morton Subject: Re: [PATCH REPOST] irq_poll: Add local_bh_disable() in cpu_dead notifier Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 08, 2022 at 03:34:05PM +0100, Sebastian Andrzej Siewior wrote: > __raise_softirq_irqoff() adds a bit to the pending sofirq mask and this > is it. The softirq won't be handled in a deterministic way but randomly > when an interrupt fires and handles the softirq in its irq_exit() routine or > if something randomly checks and handles pending softirqs in the call > chain before the CPU goes idle. > > Add a local_bh_disable/enable() around the IRQ-off section which will > handle pending softirqs. And I still haven't seen any good explanation of why this is useful.