Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1798759pxb; Wed, 9 Feb 2022 04:53:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJymd1XjFsc9xUsla65b2rilkiw7jyVAPJTDThMzVo5tZvVALvTkkAL/oiF2GiqVF6jXozkl X-Received: by 2002:a63:2b8a:: with SMTP id r132mr1761374pgr.47.1644411232234; Wed, 09 Feb 2022 04:53:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644411232; cv=none; d=google.com; s=arc-20160816; b=jRDP6zpNmMAvcomcCdtbITbPLh9J26CSRGclFYkCjnBZrYEP5RpUKIClEYO9Gr8fUv rnXk9a0mez0OF4CxNjzhQ/ig3RqMFfyekUCivAtItMRhEOL38FHTbpPO7I6KAtW6AnhB tRYj88oSmXFZsu+tVbp6utL0wOWdvHLGtyJXtTfEayg/PnOuWv5kstH0mU8zhDeh2wjf mtitzp5GkyxWKTFNjeEP/tFuBDu8U+wLxpaYWcaYwXDBXAPF0KyBJu/2uOd0xApBAUp3 j7XLEgchyel1JgVKvq8YYV45xQ5u9FLSEiTxpfeMCzFAvAaT4C+89AhqOowcaFNixS26 zecA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+qxPvnU7/bFsBLodA0zdXkuFLNsU2FdFQ61Ne/u6I2c=; b=itzAmaIRl/4lH4fwZ3dhg0XRe6ZLxGd0V54vyGNw4JV/kh1AHf6dmUn/Lz+ke0+dfc /eAFSjnxTgpD+/DVfYwD9Q1LBbEwvIYMQ2rzAjuQizQNHZjEj5u7I4+lsdjL4E83StL7 R+h9s7TWqHsJ0djdtgzzI7H5JuV0dNN6t0UXkzyOpH+yzKHAvGzlFQw3ZpN9WS/Nt1/Q 1uN8AQ7KR8BLqSeRMIE1Fg3+bKZbR+tVPHFKaYyGi4HS6SUhHLI8OuVonRsgxjj/GYNc wp+aEyv9xpUwV5xstZRhPMWbV56uClwhZ3AGZteJxgWvTkMkJfAqiFWYzbdsxYiKB/GD 5l5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I6K8ICjN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i64si4065508pge.676.2022.02.09.04.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:53:52 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I6K8ICjN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B061AE160635; Wed, 9 Feb 2022 02:31:36 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239494AbiBIH7O (ORCPT + 99 others); Wed, 9 Feb 2022 02:59:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiBIH7M (ORCPT ); Wed, 9 Feb 2022 02:59:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83290C0613CA; Tue, 8 Feb 2022 23:59:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B02EB81F46; Wed, 9 Feb 2022 07:59:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40946C340E7; Wed, 9 Feb 2022 07:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644393554; bh=o3d1r5nyYz91T6wRpb3Xtl5wpWAZV1OgB32q5ncAlFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I6K8ICjNzVwQMg3o/1xmH8e9ryafuMmG/zBsENYkvwq1JaMNJqT82m0RCfmIAcQe4 VN5pL7WQGMnRtYtzz45d//+LYGaPCF/meyjILIAslS3JOGyuyZ3ZXj0qiwmFX0z20+ 35AG0nLwpfvAH9c3NN0pId8FaPa5IQre1LEolBTNkssvJ6KZjb4g/hIhDRTSC09vwT aSrcWXN/p0WsI1rbdwAzuhwyTkLA5Yfj47Lsth2L65pBvPqcsi6n0sbcATz/w3iPdI E0FMKUqqk3ZRwNlsIGOZpe4edmBV39Cm+y0WYTsUfVP34lDGRXu4MoV4d+bYKmfD4h uPOZG2uck6Wrw== Date: Wed, 9 Feb 2022 13:29:08 +0530 From: Manivannan Sadhasivam To: Paul Davey Cc: Hemant Kumar , Bhaumik Bhatt , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures Message-ID: <20220209075908.GA10700@workstation> References: <20210812031700.23397-1-paul.davey@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210812031700.23397-1-paul.davey@alliedtelesis.co.nz> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 12, 2021 at 03:16:58PM +1200, Paul Davey wrote: > I encountered some problems getting the MHI driver to work on an Octeon > 3 platform these seem to all be related to endianness issues. The modem > interface appears to require the DMA structures to be in little endian, > however the MHI core driver was assembling them in native endianness. > > Using little endian explicitly allows the interface to function as > expected. > > Changes in v4: > - add Fixes and Reviewed-By tags as requested/offered. > Changes in v3: > - removed change of doorbell helper functions db_val type from > dma_addr_t to __le64 favouring doing conversion only when writing to > context wp fields. > Changes in v2: > - use __fls instead of find_last_bit in pm_state conversion patch as > requested by Hemant Kumar > > Paul Davey (2): > bus: mhi: Fix pm_state conversion to string > bus: mhi: Fix MHI DMA structure endianness I've included these two patches two my MHI endpoint patch series. But I hope to merge these along with MHI host cleanup patches separately for v5.18. Thanks, Mani > > drivers/bus/mhi/core/debugfs.c | 26 +++---- > drivers/bus/mhi/core/init.c | 43 ++++++------ > drivers/bus/mhi/core/internal.h | 119 ++++++++++++++++---------------- > drivers/bus/mhi/core/main.c | 22 +++--- > drivers/bus/mhi/core/pm.c | 4 +- > 5 files changed, 109 insertions(+), 105 deletions(-) > > -- > 2.32.0 >