Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1799725pxb; Wed, 9 Feb 2022 04:55:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyICJINmIEe/qOLDquB6KkAxE0rKB/qM1BLHq7mm48ErT5MJoNnX7XJxco2P88POTs7RD6c X-Received: by 2002:a05:6a00:1308:: with SMTP id j8mr2188421pfu.34.1644411333178; Wed, 09 Feb 2022 04:55:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644411333; cv=none; d=google.com; s=arc-20160816; b=Slh0xpucJdLwi7G3HVyliVnKFLh2EX372kDJkp4tquYEkvsBMr/GcOBbl8HTzpuqXT giiO5O9kOiFyoH0UPUTweoeJm+itUfotuNpH4A8QFArNbpIFGHhD28W8GDmk6fsgst6v l7Uyv0J53BH7D1ysOmU0nd4DmAnFIcDFa+LLQgq3ykiVXr3joIxoMvz9BTNq/c/ZekNv qciSpBoC/dLEJyeautGBq8JML/lC5jtGW4pLSvlBjbb9B7Eule+Jc1nlmEmR0DQHz7Ln 8kWKqs9ROseKPCL+efk4+kCgsOLx2H7TG8NiiZon16NrbAwB0AMWZF0LV//T4qAcXIV7 oJJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=E1AYkjwOeu1CBIrwgicffZLYV6zw8T+CrhwIBMOKAjg=; b=Zr6Za9PwvsM+qqvO/QXvtxBHXf4odw6vpWkw9Ua5gik8ydDBdSzRiK8HV+HnUY5ays EFqKO63uKZ8liZT8lCDhoJ2CRTf9M3O2+boQHUmAEBtsZDnb3NkgKjmG57Uag8JV2TT5 05YPvi1FJL2wbyupEnEzR1axP8lkGmlyhdt6hEPp3ja042d2WkFJxBi3bwTwa+8aXDuJ x6DJZH24KIbShUeB6VE6tyNygmCOFk6XdpSmPzbRvX+Rog4WlbwI30PMeciRJiH41CHQ u4VQt/oT52VRsa4KUXSeXNtkRpWK7+/bVnLQA/2Q0yetSo5f5c7766I295ZdWWgzCYlR treg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a15si15731849pgi.719.2022.02.09.04.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:55:33 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 38EE5E01B0EF; Wed, 9 Feb 2022 02:32:12 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241524AbiBIIcO (ORCPT + 99 others); Wed, 9 Feb 2022 03:32:14 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241439AbiBIIcI (ORCPT ); Wed, 9 Feb 2022 03:32:08 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA34CC05CBBE for ; Wed, 9 Feb 2022 00:32:11 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHiON-0007nf-Pu; Wed, 09 Feb 2022 09:31:59 +0100 Received: from pengutronix.de (unknown [195.138.59.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D988B2EF8B; Wed, 9 Feb 2022 08:31:58 +0000 (UTC) Date: Wed, 9 Feb 2022 09:31:55 +0100 From: Marc Kleine-Budde To: Srinivas Neeli Cc: "wg@grandegger.com" , "davem@davemloft.net" , "kuba@kernel.org" , Michal Simek , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Appana Durga Kedareswara Rao , Srinivas Goud , git Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function Message-ID: <20220209083155.xma5m7tayy2atyoo@pengutronix.de> References: <20220208162053.39896-1-srinivas.neeli@xilinx.com> <20220209074930.azbn26glrxukg4sr@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ghoqq6pqwpgc7xyw" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ghoqq6pqwpgc7xyw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09.02.2022 08:29:55, Srinivas Neeli wrote: > > On 08.02.2022 21:50:53, Srinivas Neeli wrote: > > > Add check for NAPI poll function to avoid enabling interrupts with out > > > completing the NAPI call. > >=20 > > Thanks for the patch. Does this fix a bug? If so, please add a Fixes: > > tag that lists the patch that introduced that bug. >=20 > It is not a bug. I am adding additional safety check( Validating the > return value of "napi_complete_done" call). Thanks for your feedback. Should this go into can or can-next? regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --ghoqq6pqwpgc7xyw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmIDe/gACgkQrX5LkNig 011/twf9GGBR2QEXqjnEmw/xzHM60lmxr6bpT4M7YV7fCn4qqpSmKiNJvO8CbePC Zyv7vyArUWuFtHsCOn4tEQeUr++ssJ82IPKWYBoO/AnNuU/XBid0J7n5cQP/B/ke AQiGc9kPruEo5hI/yHXQEcWuehl40v9Xu7rEf7Mik/LaWc34ELzbTavxKEgVzyeY BYKWU0J/yzgBPRzMAU49gS1Eb9+QYfT2KxjlVEcplbnhrAg6qHxGPGDKZNpxO6q+ JQIZXzTUnDAjkDGC0D7/rP4Z0l5yxhs2wedwMyEEZ9HPIUnJRbMIT0xe9WFdAxpw 3UUl4Jk056IshF5rZ6mRfqSSTm+jxg== =1RHL -----END PGP SIGNATURE----- --ghoqq6pqwpgc7xyw--