Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Qing Wang <wangqing@vivo.com>
To:     Jyoti Bhayana <jbhayana@google.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] iio: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:37:53 -0800
Message-Id: <1644395873-3937-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eayACl/w+/lcDdjHVmqQ85v7KshYSgNqXDMMNdleLffdxDUNIuvADba7Uw5R?=
 =?us-ascii?Q?3XwTjIcf4vwCPnukUV23aPRm0Sq60X09N3z7HCKkUS76WonN3Y57Au8fzANc?=
 =?us-ascii?Q?xWK9qKvFXvMwcHrUumTzLI8tuJvO2BQYtY97ky51ew8J/xdoBrCYcbBlONyH?=
 =?us-ascii?Q?vWLv2An24XMH03RQ082rdkM4lv/2GCbIGP5jzAg5HZrW5e+W4CaeVRze4F9o?=
 =?us-ascii?Q?gAB1OOo+/zbF80hXXuiUqJiPL68quXG8NWUGTK95Wr+iw2wjAP4Xs8k0oix7?=
 =?us-ascii?Q?vZVx80gnhu0BUcQw1K17b41rf7uVgXwAvStM/N5Ta1vEdGLIH2HFFYdiet4K?=
 =?us-ascii?Q?FR77jK+fuvfBBmVNtCvFbXPfRi0S9wdzRWqbUSJBbuX7tldapHuFKLmGK4QK?=
 =?us-ascii?Q?NubEBnq4eIh5UmQiaAE3YFFotQZOFYsNVxPKmAmTVESfRxSETnis850N8IJv?=
 =?us-ascii?Q?Xy/hu+8nr2kZDXyGJcLmB66JkhTyH0ifvJ85sYaTi1qo2hsb3/l9KyiFMuY2?=
 =?us-ascii?Q?nkjBUinbe3NehM55uAGoPsNJrG3FGUljxnUCHqa7VT+E3/ff9Hdmwa2dxvPv?=
 =?us-ascii?Q?evVa0TxjiY0+nNAQKgX2xFlG3Qi/baeDehO4PgZVyTJftG9DHiNQ/gy7cU/p?=
 =?us-ascii?Q?Xy74Ppi+em4vU6M2vj4s1Q/i92yi4j9vt31om1YTqmsIDhBNHNR61gWFIMlJ?=
 =?us-ascii?Q?Rha4RHboy/rQsDWHTPZoY+P5R9QA8fL8SaeOmxxjivOLqDWlb+gyR+15V54j?=
 =?us-ascii?Q?AEUIumm5prrB54mswy2jhrDuF2oWfgg9mGk82FLOJMlLUYcm9NNuTcCrgS7S?=
 =?us-ascii?Q?FwuqPSWojCslof9b6gt8G+vDhu/isxjh1yz5Ge2lxIt374ufw+YJzPFvyxKs?=
 =?us-ascii?Q?kxVMY4xT/+3xVKX40c7NI86xHXcPQeXmFTuxoNSYYa3h8+8EgIfNNV67rKjN?=
 =?us-ascii?Q?iUmlEHyHLQ9eQ3RX9Ca92xgMVPxdsaivkUUuGnmYsGE1pa1VuxexmmVLNP5s?=
 =?us-ascii?Q?kziz9avwIyuMHF4eNzK3NPhO3UeGcnpuYlU9W14ebK5ROMPLW6wY+zbfLNJQ?=
 =?us-ascii?Q?njj1ysi8bNaIb9P2vR8GSfdYZ3r5bvRzWtZdC79XZz32mn5Up2y343PwRJGF?=
 =?us-ascii?Q?nNBTnBEXUKtz6/aAR4HJbwHFH4jXBHntijx5mwoH2OKcFKOtlspWsafgdcYv?=
 =?us-ascii?Q?imTDIuZla1wBcWc9DaAsrXHZMs7MSNJbCGexUdKWoMK2ajXHSCNWTQpJi2Mf?=
 =?us-ascii?Q?Dt0c3zxElfGI0K2Ct1d4jwxflHK0FUa4SH8kLwrgt+IETWGXvdaB+h431GJl?=
 =?us-ascii?Q?U+7ANwT1cdU6O5YBy85L2s4e6woTZZPUaZqwsT6HS7R6UDdsFY37AUS9lNWQ?=
 =?us-ascii?Q?DmZ+lZzHqTu2z6oult7TBTuOjEvpdZ4jR8wTILqadF4Zh/MByofrSW4b1iCv?=
 =?us-ascii?Q?mDzb3P60ixjMoHKLw+Zir+sjwHehCCsJ1F41hwokvAnUrxzdEVd8I7O1UOUR?=
 =?us-ascii?Q?kKv3Unx+mmTNXSBHZNw3Rni3lpB7pF9Ts0YmkoUzmp0um1b2qkWn00sYSFds?=
 =?us-ascii?Q?DZolUXlOX4hqWh56n7P9KfuqL0Du63c4cNuxHoXU+IEY6fqPgWxkVO+rvYpR?=
 =?us-ascii?Q?ZnxaF/ZyJbtGCZ7PMM4tN4c=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d23d5c9c-69d3-464f-1e6c-08d9eba77bec
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:38:02.3742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7xswR4gy65zBpi8qTnW1WxIRCPV18fIktBAaDiA2lOTCVWuXbf5nzCnfgv09jjExflZTiLSsAXCK+3cyHChxQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/iio/common/scmi_sensors/scmi_iio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
index d538bf3..d6df5da
--- a/drivers/iio/common/scmi_sensors/scmi_iio.c
+++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
@@ -160,7 +160,7 @@ static int scmi_iio_set_odr_val(struct iio_dev *iio_dev, int val, int val2)
 	mult = scnprintf(buf, sizeof(buf), "%llu", sf) - 1;
 
 	sec = int_pow(10, mult) * UHZ_PER_HZ;
-	do_div(sec, uHz);
+	div64_u64(sec, uHz);
 	if (sec == 0) {
 		dev_err(&iio_dev->dev,
 			"Trying to set invalid sensor update value for sensor %s",
@@ -237,10 +237,10 @@ static void convert_ns_to_freq(u64 interval_ns, u64 *hz, u64 *uhz)
 	u64 rem, freq;
 
 	freq = NSEC_PER_SEC;
-	rem = do_div(freq, interval_ns);
+	rem = div64_u64(freq, interval_ns);
 	*hz = freq;
 	*uhz = rem * 1000000UL;
-	do_div(*uhz, interval_ns);
+	div64_u64(*uhz, interval_ns);
 }
 
 static int scmi_iio_get_odr_val(struct iio_dev *iio_dev, int *val, int *val2)
@@ -266,7 +266,7 @@ static int scmi_iio_get_odr_val(struct iio_dev *iio_dev, int *val, int *val2)
 	mult = SCMI_SENS_CFG_GET_UPDATE_EXP(sensor_config);
 	if (mult < 0) {
 		sensor_interval_mult = int_pow(10, abs(mult));
-		do_div(sensor_update_interval, sensor_interval_mult);
+		div64_u64(sensor_update_interval, sensor_interval_mult);
 	} else {
 		sensor_interval_mult = int_pow(10, mult);
 		sensor_update_interval =
@@ -500,7 +500,7 @@ static u64 scmi_iio_convert_interval_to_ns(u32 val)
 	mult = SCMI_SENS_INTVL_GET_EXP(val);
 	if (mult < 0) {
 		sensor_interval_mult = int_pow(10, abs(mult));
-		do_div(sensor_update_interval, sensor_interval_mult);
+		div64_u64(sensor_update_interval, sensor_interval_mult);
 	} else {
 		sensor_interval_mult = int_pow(10, mult);
 		sensor_update_interval =
-- 
2.7.4