Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] media: dvb-frontends: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:38:16 -0800
Message-Id: <1644395896-4036-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z/zy6WlRIzoAl9PvZA2o5+dZPC9On/eOR83pkPqBhhkM8EwqV/8YTXkVptq/?=
 =?us-ascii?Q?CH6qQxraj2YZz3m/N2ECqPOJ+Q77mRikY0yh//Gg9qKxdzTUGrht2dZNxl6d?=
 =?us-ascii?Q?xou11ueR7lexMgX1hHyRn5o3hMsX6iO6ECLuy37mbYqJKtVGNoNjY0AYzR54?=
 =?us-ascii?Q?cxUS/ZMz0enmJlGv1vgl51Ryf9bQPYLoTS/+FzBu6ilD5W3cfOpbmzcAVEvi?=
 =?us-ascii?Q?5C2dcZ2+PZmVGCMjilmNEE7E4Rftn8wX3DBLBxEUJ6gGiXah98NK/3/+krJw?=
 =?us-ascii?Q?GK1/R2/p1I+yHOsVBwIDGT6XUitIULJx0TpOlJd81k9IIZsMmJTbL39QV7yZ?=
 =?us-ascii?Q?xE93nEnmFtfSHEzzYaqKFLL+FFEXj363TQ1gEFbAN4NxB3jLUNlnOxl5wOKQ?=
 =?us-ascii?Q?b5A+fvvXemLR8RUabSStPlJMKxuQg7BQsqDXhFQvW8GecPJDNay3hnO2MevN?=
 =?us-ascii?Q?sE/aiQFw0qpDwsEXmjESkBGIAUSHFgNQS70QCM+qF65EHYd4sYw3qy2PLH27?=
 =?us-ascii?Q?zgRwzazrRMGIxriTMPeUVmn7yD8u/z/bg3y3xzyDVv0ZGGDDQiA3ce/Nx2j2?=
 =?us-ascii?Q?F2aK3SYN5k9wvo2pS9XkLJwBsXetC0o3IQL37DAjHmFakhd6bGKgwtgFP9K6?=
 =?us-ascii?Q?C2eq+WEjYaRLO68yW3DbHSy0tePC9oFCPmweuJOCTV8Ai2SCeJsy9NzBtmnt?=
 =?us-ascii?Q?kfSFGC0zdfQJL5HH97TS7nrCVAna9LXt5LiEi8iV1LEfaLvB5VBeVyqe7Apo?=
 =?us-ascii?Q?IaFRXNmCyzjDmW365J0hMvgC0+BwyYXmx6DAnEctVfG3uTvH/j9OTzxzmZHJ?=
 =?us-ascii?Q?OWbD7PI0nMedHWxHIUUZcNLCqU+MAOqCdy2vjdSL5ZG1WKrEhXXEhqttG6M4?=
 =?us-ascii?Q?xarN61o1vGG2Y54YyHp1tqvNdfrpKMxQZ3PUm9zI9Jx/zkccC/5ah4mhCucx?=
 =?us-ascii?Q?u0SGtJO7hGdfp89icdWELhZ/KZ3c08V3aoJT2geLCID8GK3vG8ynnE424f+k?=
 =?us-ascii?Q?bQGmW7ZN8Ff6lYtFE6TKRJeTkVrQsJGyFyTXOliydhlb9gqVwPnm/fvahW3B?=
 =?us-ascii?Q?7Qb+vRL9ZkEsMKgOfLHpr8ReQcik1/GZTHzSAAwqiURRKd1lftBkp7mkvqVv?=
 =?us-ascii?Q?KLeQgRf8LCqFfy3yX+0MpFBUMM8oDuZXCc3VRqoURmaRr59P23Banm/zZTf5?=
 =?us-ascii?Q?x5Ot83EYK5YhvXON1jkKdobPNjJsW7mSAbzmhw3UH1gasq06icgNNaODy5Dq?=
 =?us-ascii?Q?BomQUrL1Mrz+xg3ZlPECuXEcRb0J4Bu88ABo7W7K06XfpwcFP+/3LZUhh2mx?=
 =?us-ascii?Q?Nv4lEpnHOlSNAozkwqxHvurtzipDNp37oOOAFdHf7/MHbMySXKN7NHfIGSwc?=
 =?us-ascii?Q?NKc6/AxOFG1M5jt5AnSo4cACUZLpvhukg9rDBMnRPOCPgath7xaft42U0nE8?=
 =?us-ascii?Q?PJsM+7ovbuNYjqJqoBDD1P8H+xFXDL40C9hodq4QJbvdePABMxuPmmbSLcQ0?=
 =?us-ascii?Q?UUgv23iaB7h1mSGuHCilSAqzcy4x3P+AED4r39TpKdAv1lt8VpbmvP5Q/DqM?=
 =?us-ascii?Q?PFGhRq+QOG6RtOReTe4u8WWokKHW+gRsjliSnagafhroQNndO2a6XDuCgDwi?=
 =?us-ascii?Q?cT62WDY+/JHtN+4DUetyD2Q=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c0df24a-1643-4ce0-eebb-08d9eba78a07
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:38:26.0133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: awQKXEhdgbb+DZKJfWXnyPeNSaR4QHVrFgHUh2gCd22xuQjofCkOH2pPooBpsVyit7bMH4uVCJQRfKVsW4BGAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/tda10048.c     | 2 +-
 drivers/media/dvb-frontends/tda18271c2dd.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb-frontends/tda10048.c b/drivers/media/dvb-frontends/tda10048.c
index d1d206e..1ce2e67
--- a/drivers/media/dvb-frontends/tda10048.c
+++ b/drivers/media/dvb-frontends/tda10048.c
@@ -344,7 +344,7 @@ static int tda10048_set_wref(struct dvb_frontend *fe, u32 sample_freq_hz,
 	z = 7 * sample_freq_hz;
 	do_div(t, z);
 	t += 5;
-	do_div(t, 10);
+	div64_u64(t, 10);
 
 	tda10048_writereg(state, TDA10048_TIME_WREF_LSB, (u8)t);
 	tda10048_writereg(state, TDA10048_TIME_WREF_MID1, (u8)(t >> 8));
diff --git a/drivers/media/dvb-frontends/tda18271c2dd.c b/drivers/media/dvb-frontends/tda18271c2dd.c
index a3483448..fd92878
--- a/drivers/media/dvb-frontends/tda18271c2dd.c
+++ b/drivers/media/dvb-frontends/tda18271c2dd.c
@@ -328,7 +328,7 @@ static int CalcMainPLL(struct tda_state *state, u32 freq)
 
 	OscFreq = (u64) freq * (u64) Div;
 	OscFreq *= (u64) 16384;
-	do_div(OscFreq, (u64)16000000);
+	do_div(OscFreq, 16000000);
 	MainDiv = OscFreq;
 
 	state->m_Regs[MPD] = PostDiv & 0x77;
@@ -352,7 +352,7 @@ static int CalcCalPLL(struct tda_state *state, u32 freq)
 	OscFreq = (u64)freq * (u64)Div;
 	/* CalDiv = u32( OscFreq * 16384 / 16000000 ); */
 	OscFreq *= (u64)16384;
-	do_div(OscFreq, (u64)16000000);
+	do_div(OscFreq, 16000000);
 	CalDiv = OscFreq;
 
 	state->m_Regs[CPD] = PostDiv;
-- 
2.7.4