Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Abel Vesa <abel.vesa@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] clk: imx: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:36:58 -0800
Message-Id: <1644395819-3791-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vJAMxgGHKYItJKZpBweQ9nVFIUivcws6iS63HK5XFEZHD/j1zunH5Mdisrh0?=
 =?us-ascii?Q?BkT3dYPHr3t2yCpUt7kEtJKknpzmBAJj1ha8aSpT381Vk1k4HdWiqODM9CyB?=
 =?us-ascii?Q?gkryXMesU0Xb5bfojIWo2+oNgeewE2xLO0/Z74mVlqLH5oH4Qkl9AOTdNM/R?=
 =?us-ascii?Q?UFOzgci/3S6RPvlhTmuUgNDWHHhaC4mv/cLFLtN9Ul6Y7hewQgDH/uJE0Zt9?=
 =?us-ascii?Q?SmXy3lSvnN4jcqNNx8ecrU7BEQxNbZPrJyieHdGS+NJyAHj7MGCeekney8IX?=
 =?us-ascii?Q?LFc/QBCgY/LZepmFSD8cNsIsKDvnReuFO1G37ZLuVR4L7kblF1AiPkXX6wlU?=
 =?us-ascii?Q?J40Mc7carM9v2nal3MK3/dFlz8t4UqgxlR2qS59a03dX9EzzyXFd+oL7n5JB?=
 =?us-ascii?Q?dDUt9w806tMSbHqijS/TKPcVcV4ypM6M65yY9t4o/2HXUVpBkD0glDrSdSQ+?=
 =?us-ascii?Q?8WiNxjgvmglMrwOa1eYpaqD9NCgRrqCWyWNJYRrRQwsSwbOYYFBFn16g7rxz?=
 =?us-ascii?Q?azxYr21gFM3/BOfmiI5jyFe5xUJj51BPl3Akn3tqzhX0GWKnyAcqQwJ8yb76?=
 =?us-ascii?Q?Zl0ob1dBOjjnhLiOJe/u15AQVJq4p3Ck6OqcNuBNEUgDCdmaQEE0jthuLPKT?=
 =?us-ascii?Q?be1xuyOXlXyrrOumGhBtP58f15YJpMxvF05rT/H/4+tSwiDIoQKLWs5NAz9C?=
 =?us-ascii?Q?1iaMn8DV/V8MWEYvThlk6KkIqMzjuh8XRiqjYEhKtjCapBstIps8Py/YT8F+?=
 =?us-ascii?Q?yYucqTPdxHLPs9H6AGhbddD1mkm9nh4OLjbmK0rV9S9aW1S4/0xIZQ44xfxG?=
 =?us-ascii?Q?QQJxpQcGBFP+JzdmX9EXo3wekOMhWIXfe+MrSuQEy9xrtWrtJsodGegpoM5U?=
 =?us-ascii?Q?WPSkgnwiWC/lV5wwva9cXxDxx/dNKUDHs4ZuW49zBvPaOt+3gJq2FLd0CYu3?=
 =?us-ascii?Q?R5X3ONDwsN3trmKvmseKy6oACsEKxlS6U9WTcQQ/KKgume2nRaVEq1GXbJN5?=
 =?us-ascii?Q?pU5r8mpDm+vpakVWcuDJYg8pDDd774G7FcE+0FdQS4wm+BXisFzW+nfeCwT/?=
 =?us-ascii?Q?7Qt/YS0B5sN57mYmhmYwE2D7/4ZQJUpT89HkkNVqPKe7JKMOhLxKZTZ+itoj?=
 =?us-ascii?Q?TRBcvAd+DRwGm/6a+ebueFl5Utkqqg6mIewphZAuDUTDYJOvtTlqkwuMlV/k?=
 =?us-ascii?Q?CxSsgoOE922gboVza9KVg4I8pbZyCJ5mjWAmlbpDZjILjMo4e0X90UvUk+sk?=
 =?us-ascii?Q?vQDil1THOJ0izmVX+vFJEHLYD+EpOaGZdkApWE70iBDret9pjjyvX/ME0h54?=
 =?us-ascii?Q?wr3nyTeKrGpPqMcYjjcypexEkXe2fypEkRIqAby4/SOvlWxH9WjzEpsrwYyM?=
 =?us-ascii?Q?7o2SzWaicpAc1y/dN2idprY0kAJrJmjI+KcQZ8wzZ9gLmlQ0VugKY2oudn+Q?=
 =?us-ascii?Q?yzfFcOX5/xow4ozQqJKOPFDVl+OihYWeiULK0odOt0cQLOxaqzfsM5nTtCjl?=
 =?us-ascii?Q?XhewCVCeV4TsYrJb4p0oeSNKuRR0aNeU51UAY+9PQ7YwnSFzCZ+V3SCCBPnw?=
 =?us-ascii?Q?LCA5fgNj1IAz5i8/vQox2vXhEyfaTnTD8yNp2xJ+PGcgeLeTpUEhIpq+IKQX?=
 =?us-ascii?Q?Fi6/zYeVQL4nq/86eE8y4rQ=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3bdae0b-a8e5-4356-12c3-08d9eba75b48
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:37:07.4870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rTNN0me2TVM6wTfiGgqrr6MunzDxxixN0xwdZAGrOAQkDVZKgdNjNe4AFN2n6vyCS1koiVQObSwKMiVvK4Rd2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/clk/imx/clk-frac-pll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-frac-pll.c b/drivers/clk/imx/clk-frac-pll.c
index c703056..90b25e3
--- a/drivers/clk/imx/clk-frac-pll.c
+++ b/drivers/clk/imx/clk-frac-pll.c
@@ -129,11 +129,11 @@ static long clk_pll_round_rate(struct clk_hw *hw, unsigned long rate,
 	parent_rate *= 8;
 	rate *= 2;
 	temp64 = rate;
-	do_div(temp64, parent_rate);
+	div64_u64(temp64, parent_rate);
 	divfi = temp64;
 	temp64 = rate - divfi * parent_rate;
 	temp64 *= PLL_FRAC_DENOM;
-	do_div(temp64, parent_rate);
+	div64_u64(temp64, parent_rate);
 	divff = temp64;
 
 	temp64 = parent_rate;
-- 
2.7.4