Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] clk: xgene: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:35:39 -0800
Message-Id: <1644395739-3640-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xk98eVnQ01qdmS2/hX52qY1FoSzMbspYLIYFFl+PhzLv+UpvCdPS8neuHXhx?=
 =?us-ascii?Q?QyeKwKijtD2cqLXXKj3ZBdOog0bbI6B8bfdFmdXgatiFW3ebIsGQHfVLneqA?=
 =?us-ascii?Q?GeVeYz8rphWljoaq7u+xwJ/TDxv4d1t8CBOuuSGOnmWFI6dtR2q6JCovKu3h?=
 =?us-ascii?Q?sufIx+O8a3nWJ2cKjwq6RaJPUu7+uCHJBrP/cyCl7pQY3EXdXyXZsJeTqGbM?=
 =?us-ascii?Q?PWlOnNxUpYq26j9N88jqxL2LPQpBXG01hzC+fTpa9TgUSFA8msfKmlskSWXQ?=
 =?us-ascii?Q?3ucuH6+9nz9E1dU8E1gAanF9LlzBoCoG65jMo/qMOKExnVvQE2GuU0Q0I4sX?=
 =?us-ascii?Q?Vj1faAtcSgUCIAYF79mWLZSPMawXzApOlu0qjLqmBTzU7KvcxI4/n/C9owqZ?=
 =?us-ascii?Q?eIFTgeMiNJqQQxrnp/T9a3kSDEEFWa3rFVsURoNE2jOeyZNlTcReCYP2GBMe?=
 =?us-ascii?Q?/n1ngkm43VV833n0bdQ6MXslvf1EBKv6fS5FYeRj7pYJVpvlkCr+Iagcw2s1?=
 =?us-ascii?Q?PamJdGnATWplTlET1DrI560s3pwdhPQebKDMU8fjrLd2CF4bCJtCMVE74/Oh?=
 =?us-ascii?Q?CFv/3Q8rAc3f8rTQ9Sy5NkxUXQs11m4f0ivCJqMR/ba6lRnJ7oOGz7VOly4J?=
 =?us-ascii?Q?FH7jn+enW9kTBQ32H8UeRykal6Wp+HIr2lGell7ChmUEsDXpi4WRpj8moOjb?=
 =?us-ascii?Q?qa+EzpLpAGbCrtyrMbs3xUhW/DkJukZZtUQvM5/vw9w6E5l8t8rzSatwg7LR?=
 =?us-ascii?Q?cHSAlAFMN6oIE3s6PHf91FBeFPUJa6NFP85kBGYxrASDvo9Jo8bCl/EDTbrQ?=
 =?us-ascii?Q?UwhxkLE+EnzG9ILGK36rXKD+uVUUVVvd56cVqFhOi56SOp+dF5gUQExJSxOM?=
 =?us-ascii?Q?a33oK/qK2/leaI9183CWSdXO1SX6Sdebq62pNhziIH1tP3msodHy8umxxdmF?=
 =?us-ascii?Q?WKmISM/vftJyK79HTe365Vn66NQYp18TJ2bLThSQlCGXRd9SFEiyl4c4yMIC?=
 =?us-ascii?Q?CXOuTGCf0r+6WF4nlC3FxNuCVQ0ewxXa6Tlvdp1GC5De2As1OBPgtkKtb4lm?=
 =?us-ascii?Q?ynwP9eyYyUqISs88sB7/rWct8VL7JbA+QdXAlRcWQKwAmdrJvwCPKH3t0Vm/?=
 =?us-ascii?Q?h+mx1mjMFN00XNAhe/XQFONqwOek2xyf/7a+gzHcEkCAvUQxVifnncnzSF7T?=
 =?us-ascii?Q?Xp2dilZMoypJcNJZcOSlbWTKUtMEgC2HgyP5FmYZ92F8kimPh8ShOCqFjAdw?=
 =?us-ascii?Q?QxoThYhuL0IamNcpdJqopZcNEr5RHLx3rMR6HbmUaivnjAalc9jMS/7AJElv?=
 =?us-ascii?Q?k5cQakZSGRQWbj7BzxJrJX7J5iG2BmGHk4aNSsoiMKunPLIRt0YQU8YDTTM4?=
 =?us-ascii?Q?LVOYcsUgZa8zw3DmqwO/W8gMufdzctTGOSfuNeou5NqJ5/ty799ztZYeb/Se?=
 =?us-ascii?Q?8xJErR4iJAfTelgjrSxRBQED7/H3bWQbJxOjZ3bWkbWS50ccYLfigfFDatrC?=
 =?us-ascii?Q?POrBcnSjCD+9SFs28EYGUqTfxEiDG6wfyLEx3EbTCZipiPqy17fTp7nevQ3V?=
 =?us-ascii?Q?Z0j+MBZaWuEQczUEjSGZlu/PZBJtdLt+vMaxYKrAulQO+Uj8cyB2Ym7Rx56Z?=
 =?us-ascii?Q?+SuAHTRTF5ldf/A/rjAqqII=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e6f099-48e7-4969-1e31-08d9eba72b89
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:35:47.3826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 01/cnPfPwLrDPuEFbe1rIMVjeb5XyB8Ppj7NzDBFImlZau9QtCoU+jiSHmnAGFKSkbbNZTcTgbChtuDRvjPZBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/clk/clk-xgene.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index 857217c..6c40821
--- a/drivers/clk/clk-xgene.c
+++ b/drivers/clk/clk-xgene.c
@@ -262,7 +262,7 @@ static unsigned long xgene_clk_pmd_recalc_rate(struct clk_hw *hw,
 		scale++;
 
 	/* freq = parent_rate * scaler / denom */
-	do_div(ret, fd->denom);
+	div64_u64(ret, fd->denom);
 	ret *= scale;
 	if (ret == 0)
 		ret = (u64)parent_rate;
@@ -284,7 +284,7 @@ static long xgene_clk_pmd_round_rate(struct clk_hw *hw, unsigned long rate,
 	scale = DIV_ROUND_UP_ULL(ret, *parent_rate);
 
 	ret = (u64)*parent_rate * scale;
-	do_div(ret, fd->denom);
+	div64_u64(ret, fd->denom);
 
 	return ret;
 }
-- 
2.7.4