Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: dsa: ocelot: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:39:02 -0800
Message-Id: <1644395942-4186-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u4WZkgJjyGK5YyCuhLU4HOQ82ZrqFdddzU/eKytzT6iH1lGnYFE7DPedJsRi?=
 =?us-ascii?Q?+UnbfHNrTHDCiSk2VpHUjcG1ceo/2er0p91Zv86jlXO113KHs9MWgTr2AZzh?=
 =?us-ascii?Q?bgjGlG4NnLLHxhZ8Tt/K3yVLkYtVqOlVvzbRXd6bsVw95opmCFlhYqs527D+?=
 =?us-ascii?Q?yQetg2pspWQFA5bImgNGu5eMy625ORQhzs83QM1uZagcCbwMM7bujH7EzwDr?=
 =?us-ascii?Q?/ZPxxon4MmBC9v07sHkkh+sYuqqVibfwBUPPf0zmlIaQJiBUGXk5UhqLDHFU?=
 =?us-ascii?Q?99/Wto+/YiZPdGGpD4dgonsXZljES51HvHTamWCQq+YaH5v7QsV6p3h42LLN?=
 =?us-ascii?Q?MtMk3F2zpO/mCPyq5rnTV9TPf3lWLq99vYb3agW8t5JdYoVH2ki9ql9ny8Zf?=
 =?us-ascii?Q?26IT7lR+q9gGkUWPwhcvn1vdwvgYoKz8yi3cr0BGbImXnjluekjMv5KcUDH4?=
 =?us-ascii?Q?WEGoxvYSYWUzR//xClYf/MVcoTh8sQKjxlUOPlJ3Tgn/3voMl5cWwskBkwPz?=
 =?us-ascii?Q?G+6jjhAWeVylLHSBtAOjVOBBPSrU6YpkSFsguSzGqJZ1hXgLbjtNm6UpW5jm?=
 =?us-ascii?Q?SmZS/bohenorFgIpzkm2Pv4Vljj4wGXKxUlIn1IT+jovb/Qs68Q8SSw+ICEP?=
 =?us-ascii?Q?eKXR3bqe+2Qc2mA27IFM9NBxUgRvltUO3hEnF/P1pQ/F8xMirhFjbTJxepLg?=
 =?us-ascii?Q?y84mEOj+0HjS3lC7oo9egIscSqQs7TWvBw5MQ0ZT4w3bsx5NzIEQLjj8ytrp?=
 =?us-ascii?Q?uDmoJ+MbitlIoRgblwEcuMv6A8eIq79PCTCd1SuW0g+WCicrhm6rAvrkEZ2B?=
 =?us-ascii?Q?TWbyUF46/k3XCLartCWHTifExMbVq/Y/5iwv6nob/+/nKxCtm2RYsohq88iF?=
 =?us-ascii?Q?ijOYZt9kloJd6NcydQP/lPNdUuZpDY7uhItCYRBGKbh5JFKrC9kC5nUMAtud?=
 =?us-ascii?Q?k27FNC+n7RFSBTkvdl7hhXEF0R779jBrHWHfED3O5A2wLzHBSPobcJ8kYBxv?=
 =?us-ascii?Q?t5XfiMfLkpyVwHh5vQ53QPrWcfPVz6Gfr1UYr/6sFnxjRG2tm7omTc8qc880?=
 =?us-ascii?Q?tpxpws/CmCQeNqgPE+IC8F4C4QVRQK1rQboht5ZnJm/OwBT6shVhFOaOpEpI?=
 =?us-ascii?Q?OwrRIR91UMhgjD7Fb/c6lmoFvfiX7NfagnV0rxv7z3pUlOjW1J2/hT8lB2rm?=
 =?us-ascii?Q?4XeLEgRO1QvbvYdKaUi989iYN4hTAnyaRpxFFUu9Ad+8XIuPppk9RqJfI6rP?=
 =?us-ascii?Q?3tyqSF0QGGYKUGpEN0XFBuJNAC6ZJnnarfS7iBh/4YbmTTRKoebENTfLsQjm?=
 =?us-ascii?Q?rvH+4iJERkkftCqH6ubwTlpVVTativoZmX73O0SJ2KScm6whgxftTVzQc1h7?=
 =?us-ascii?Q?VRGHGCO5VSCXcp3veCpxzGZDCnA+4DwFZW2Z4fIjanboHVk2SutuYw+Dapmu?=
 =?us-ascii?Q?KNxAxxUWcpyVwS0jjVgyQ5tbQ3rX8wi8+ZfPPxY7YNLhvR+7WYi2sfwCwWYF?=
 =?us-ascii?Q?VKWcbNkbs0OrLzjaDRuKkloRBVCCQRu4RLZEb6lapquJC+Izoq1yk3lW3V9C?=
 =?us-ascii?Q?LhrIjNw7lvsRdN0Xibp+gJ/7VajP5+Jld3svftnMr4UMcd14SVoyiowl4gX8?=
 =?us-ascii?Q?giHLdNzwfu+EmbLbOG1FdiY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e35d08a2-4d84-412b-d559-08d9eba7a6c9
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:39:14.2134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qo/BcVnpWNHtfitTUs+zPo8hJfk28Sqg7mX/L8DHG0/cSkOC0x+/3sdFX5nl2J47bZAA9miMHJdHSAxBuWUPzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4387
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/dsa/ocelot/felix_vsc9959.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index bf8d382..5c2482f
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1178,7 +1178,7 @@ static void vsc9959_new_base_time(struct ocelot *ocelot, ktime_t base_time,
 	if (base_time < current_time) {
 		u64 nr_of_cycles = current_time - base_time;
 
-		do_div(nr_of_cycles, cycle_time);
+		div64_u64(nr_of_cycles, cycle_time);
 		new_base_time += cycle_time * (nr_of_cycles + 1);
 	}
 
-- 
2.7.4