Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Qing Wang <wangqing@vivo.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] staging: pi433: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:40:10 -0800
Message-Id: <1644396011-4450-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OvtbvPdlSTM+P7wpEntL36reX33pEHXg7dCSQnjderZmuAdkurHKTNfSXAfd?=
 =?us-ascii?Q?d7BkkbO8CHhBuMd1zfETTAEcJIsq3meF3FH6XPe9B4IzFAFPzkT42MMMWEAn?=
 =?us-ascii?Q?vHNxhuV9lbapZw2NYwOvqN/1jvFeUKFSWe6dUqgJCeWWYs5amLP/teE2MUr/?=
 =?us-ascii?Q?KbbKcreFDHSNrCWLFtUAaUb2C6JslgaU53FbWx6VDO+w/Ha27eXjInnTJCxy?=
 =?us-ascii?Q?yaimiOvroqnMnrdrJVhG9aqPKk8ecKqOaSGQD5KuD5MpswRqAyNsqRniR6CN?=
 =?us-ascii?Q?SHRM7vwxx4txUD3Wag76wJOO0U6W7a9ZvoEbMxgZbsgMOsugR7mRL6hS9IId?=
 =?us-ascii?Q?lt1bbydinjbex3yXDFyR7dy4etNE4WTJtClhRmMa0rlU80CqWW0zslyKaRUT?=
 =?us-ascii?Q?cbUwC0vqfAdmmvWmxw7pNNoF3SKApySmYtwRxFhaQxBfg1PwXtU2fO/ZBZiE?=
 =?us-ascii?Q?Yt5Vy8uRUC+7NakobUsaee6CWfCPN44jGy8zlhMWk04rF34KxDRm55icZVjk?=
 =?us-ascii?Q?iwbmI2uFXH+eph7M3joWIiOpRNJp/V5ZofIrhdtC7sEB4xVUjl3sVSEkzsRA?=
 =?us-ascii?Q?hNdAQ4wYh7jsJH3mrOWVhjO+g/PpWsVtQ+jmtP9oRGyZXLWv2vc7gNQw0Fky?=
 =?us-ascii?Q?MVZZCO0ta6IIQoFsbqzvpOlhNg7Xs5OU4UUkzvSeZ9ZPRqD4VK1H8Y0jzAam?=
 =?us-ascii?Q?esHIF6dByVpsTKnMZ1Ok4QSE/waEXeFt+uUSZgoswqG7e/XZRvxvS1/XITuZ?=
 =?us-ascii?Q?ZP+J6GkvJWAkh0H1yOqRSKWeT5JVqw1PY3NLQb0vjKqpZXiat9kUsOpfchur?=
 =?us-ascii?Q?rxCjzwhJD9wci7WsRGCnXXdlws/NemfO7YdVR0DPv7KmFk1MQrEPOiH5XaVZ?=
 =?us-ascii?Q?FdlSt/aQOzh7mA5AI03H+MhSS0Ex31DXPCqdkFFjg1Oatu7Ixa6YN2+GX1eP?=
 =?us-ascii?Q?75zmK7IxzTjSG29+iNQFRLVFLhCVPnjICqMw75Rne6QKXhRXWa0xiFCJ/ko6?=
 =?us-ascii?Q?BeGhTHiO5R72xOD18dHd3iqO3zQ/F5G8JBK9I8vMF7QnFGOAHc8eSiksP9qD?=
 =?us-ascii?Q?umn5wohMjaWLU3gNE5ehqsm+ITpvrxF8oJVrZsJ3xWlUIgARfNpSqN4AEYrX?=
 =?us-ascii?Q?MaZupVGLpDYIM8QLZ3gjJMuQJpjl2tvsRyqXO56bgQlwiR5XVFEoajgyUlIO?=
 =?us-ascii?Q?A0/C4ZD8+sdwXrIoIi4U9YN6EJtL3/K2qOXGn1beqOs+uu75W54grqGCkuP+?=
 =?us-ascii?Q?ZHt/B/O4CpNpeOfWPSnbSaf+WuvUF+58I+zVGS9r7lhKg3QQiitrPOY0HOSl?=
 =?us-ascii?Q?sUIklQw4UqQxfqfAqSZmbXK4L9HLJH2MsikCq0Mo6m0rG49ScPFXfFwYmLXt?=
 =?us-ascii?Q?25Kbvyboqt6yXxNvTJ3KGgHmSWQKEFTDAZjhR3ZyM4O9U6xs7pmdj0odYUFe?=
 =?us-ascii?Q?w7E+wRopaGRG8azHUZsW9sKW55IW5LgL+9kHVfxTxe5OzZZftNDwHT28HNAu?=
 =?us-ascii?Q?UOipELZJxoj9ClBHOA8UOgi48rxYVr3XKEq1xl29fFYSqZQWVGTrsgNVxkkB?=
 =?us-ascii?Q?rZWJQsLVSBbdMxyY7XdlWlPbHblxp+FWhVkfZ8cn0AbQ/hnCsyQCdlSn4X9/?=
 =?us-ascii?Q?OfHX/OuFVmooshrp9RzYs5Y=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78eb992a-7aac-4b00-4117-08d9eba7cc75
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:40:17.3656
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GweKGyjKNf1izdHWfZmjJW97RyEDtHIZCkzCGXxVZWDJofzuMSkzoXb3n1suB8iqOEkrCWU8OCwoIr3+ghjzdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4387
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/staging/pi433/rf69.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 2ab3bf4..cef542d
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -294,7 +294,7 @@ int rf69_set_deviation(struct spi_device *spi, u32 deviation)
 
 	// calculate register settings
 	f_reg = deviation * factor;
-	do_div(f_reg, f_step);
+	div64_u64(f_reg, f_step);
 
 	msb = (f_reg & 0xff00) >> 8;
 	lsb = (f_reg & 0xff);
-- 
2.7.4