Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Derek Chickles <dchickles@marvell.com>,
        Satanand Burla <sburla@marvell.com>,
        Felix Manlunas <fmanlunas@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: ethernet: cavium: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:39:19 -0800
Message-Id: <1644395960-4232-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wMVh4JQwstgbnv35ltCKyXd26BkU1waqT90WVovJJM8TfUHcsW7pHLRZsggV?=
 =?us-ascii?Q?csSfKcxQ65cJeCrxNgL9Qng48ZFJIKhboflysZQZicAiQ+bK46UnLBYulFQ+?=
 =?us-ascii?Q?d9hXTpiTiuFjE4Kai08RLizcPn5J/HHDohTzYbx7o2sO3bR467mJmuiBuawu?=
 =?us-ascii?Q?9egvns5seqRyAGsM/gZZSz/eD96bG13531Yx+eNoTSv26WAJV8TCPHOuFpDR?=
 =?us-ascii?Q?26pDbkAerWAdq9ZINl5t5uTuynLWckHyOU4G60DHUw5pqbVnBdAxk5LB8HLu?=
 =?us-ascii?Q?XFDURmlDImAYPFIHBWskAo8nYO+/O5nF1VOIP4MNx5mHW8LKZxuRhNFutm3F?=
 =?us-ascii?Q?BQ+RF0Jm1bjwIAZeF3TkvW13n/W/ZF8KTgYqaneUZE4MdOC1I/xTRkkdx5eN?=
 =?us-ascii?Q?nX3oobpYnc31utrBcQ2jRaiWBqTxzHsb6GlM1/VfLNiq1CDTzRzqe1UfFP5b?=
 =?us-ascii?Q?qzn5qfB8PxjZi5iuNF9H6m2BDLW4DlCBlAKTu8Q7rKln4r4lPTRKpW/xzSHu?=
 =?us-ascii?Q?SponLf6SgJrfopjnWncBu+QszSpqoV8O4re0tz9nJORQIFWz6ure+0ZLhGQ1?=
 =?us-ascii?Q?hB0/hvedhPtlKyDZaB8UO19h/Jj0+YTVVVPBm9l2eXdSXvdQUwTtb9Ga5Et6?=
 =?us-ascii?Q?Blx73HBzx/CDreDb4t5kgR/l7PAsLAiu7Xpu+g6eQ31NegdUTKv3T3esuPXZ?=
 =?us-ascii?Q?VV8t3C6mW9/ZF1LbIea5Pwz3LETckTdb0wnNrNHjLj0XJGlRrADR6iD4+mRT?=
 =?us-ascii?Q?cnpWh2ui0aYyhl9qBBJVeABFOaH8EZ8CbDIhnTiTzyGnUWOKl6I8Whd5eplN?=
 =?us-ascii?Q?4FHvUXUvloiy0+JBuLc2RyrUtcpSuX3lF2iWA32mEG43dUzZECr3BR6LS1Ot?=
 =?us-ascii?Q?gKyyLV8f/WCAqIQQNYEBk7UsxKC38+bsmhzgOGWn9sBovF0BJHo1FQlZg4gB?=
 =?us-ascii?Q?yuUErRQlX7l6TxUT6Z6h9+Q4AF8WI7ZZn6/4m0b7273KGAGrrErwEPf78Vhx?=
 =?us-ascii?Q?6XDrQfNVFkpKP3o6kRBeh1BM8lb8rw6pN/Rloy9K7Y3En7qzeRIEGxn8D6kL?=
 =?us-ascii?Q?2d5RBLkDOzKBlJJyHDdHRGgfDg4aqIGWPqfS8GqiJs21aV7Pk6UGuHMPDPgd?=
 =?us-ascii?Q?LsUw0efNg4Ii1A7QcOibnopZLj9iTI3tb5JAWw7DgsQliXBB107vx41GIVN0?=
 =?us-ascii?Q?aiqyC0qkfBD4Xvg6ATfshWUQiwNtCchZbapttJFBIyVW0S+BXne8gecxM+pt?=
 =?us-ascii?Q?SoFP0JXTEhwbWlmnofUoJqz2997ix4llfkA4RTf+R46I0Ng+Sl0tNC5457Do?=
 =?us-ascii?Q?FOJbagvkZpIwLXbCiGd16s7mht3eCcyAkxuQVsEu0UI3bB1rq+XYHocLfnQe?=
 =?us-ascii?Q?dFyrYwAh4g5GODkjONUmZpxPKbQfARqAH1jYKYen4kzaBbsnP894owQ7Nodw?=
 =?us-ascii?Q?KBSz46Kl72ckg0rCM3N0NM5Mc0OVKQgkn4A4T48iZMIlfEHcrHdFLVKO9R/8?=
 =?us-ascii?Q?WqGYilk8e96OGbQE+7mlC/67/22YF4iaT1UJIktpAGoQBNukTS18dsiRp+zw?=
 =?us-ascii?Q?LhJ9GxzIRqYZ/MiTgLR5trYAigmgvZcHLhpAMPwdbzHJ0tT+MSUEtqaip5kL?=
 =?us-ascii?Q?PdBzGXLIpSGy5fHMeHnYLCw=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9b2cfe-1903-46d4-2055-08d9eba7ae6f
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:39:26.9626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CbjLUz/seISY4qlEl0ThQIvluqks7pLRfUIs1G/I5T4ixm1LF7FV2+2ZBkAgC9zvfoSI1S1wB4x9mPcZtwHyvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4387
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index ba28aa4..8e07192
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -1539,7 +1539,7 @@ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
 	 * compute the delta in terms of coprocessor clocks.
 	 */
 	delta = (u64)ppb << 32;
-	do_div(delta, oct->coproc_clock_rate);
+	div64_u64(delta, oct->coproc_clock_rate);
 
 	spin_lock_irqsave(&lio->ptp_lock, flags);
 	comp = lio_pci_readq(oct, CN6XXX_MIO_PTP_CLOCK_COMP);
@@ -1672,7 +1672,7 @@ static void liquidio_ptp_init(struct octeon_device *oct)
 	u64 clock_comp, cfg;
 
 	clock_comp = (u64)NSEC_PER_SEC << 32;
-	do_div(clock_comp, oct->coproc_clock_rate);
+	div64_u64(clock_comp, oct->coproc_clock_rate);
 	lio_pci_writeq(oct, clock_comp, CN6XXX_MIO_PTP_CLOCK_COMP);
 
 	/* Enable */
-- 
2.7.4