Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Qing Wang <wangqing@vivo.com>
To:     Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] media: qcom: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:38:33 -0800
Message-Id: <1644395913-4091-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Eq+vJ0TS0LXlrtABhxQ4oOvbqFy14X2KdSn2idbc3ESY4BL9VZzGpVh4GTrD?=
 =?us-ascii?Q?zw46hVpmrvSLaarVwJLxjFG+PjB/VvHSjlCVbpg9/DR6j72mmupuq16bVRt/?=
 =?us-ascii?Q?U53kaypuVW0G6cm/ZQEPcpfdEUlui2fc4t2dsApdWmOzPfL9R0mPlIwBvybc?=
 =?us-ascii?Q?9S3jZPv7SyNL4zkPKSrEtJad6FaKdHqzIiKtOqIPIHPSsHAAszrdbP7Add2A?=
 =?us-ascii?Q?rVqrajHqS63bNc+7uKFGHXIgHY8rJSVLJB9e2cpyxNr1Mx2tHBC6KUEuNNVE?=
 =?us-ascii?Q?vuxG/U4NEzZYbHsQsYCCZHVusYV4hMTcZ4dZIYmuOz/4h7XcMT8OOTfucLar?=
 =?us-ascii?Q?IOtdsZGvx8rPCZC+Rpr1D8XM+yGdCPr7YSkyk0dukw1cd4gn6w50652b7epQ?=
 =?us-ascii?Q?GrWt0o7bbnFQb4nk6Zc19pF1t9g+RxD+ofyEUcDkYkFZZVOGNedZz2G6u6kE?=
 =?us-ascii?Q?4Vzx4g2vOoQgFM3ZHkxppysE9ko+1nMAuyaLNZYu5Pi5RTxpZu5vN/jNZbWy?=
 =?us-ascii?Q?I4uyIhCIF7EiSe88IsYiYax/qW+OwOzrAKdKX+Hrt9FTkGtyI94RsRUAraBV?=
 =?us-ascii?Q?X64cABRSKKAh7Hdwor5NqgrWZt2Bm/6rLnT/ABW1mL/sqOTUGHQSprtQyMxy?=
 =?us-ascii?Q?nG/iAiMp5Hc5PtojtxrIsYuBoo7Snv6nOua/fw85pstGoZZ2dLKay84RBDXT?=
 =?us-ascii?Q?6xdWfwA9XxLVF3Z+7eV5L7Uuo4rzrZBw52+Ng0FnwaNAk2gu1jJZFaDR6Joi?=
 =?us-ascii?Q?oI+MLCebqPs+Zh4tkf0bEllH6//CXcFkQDExtRf6oEaS5EoZf5h34n/UMB7j?=
 =?us-ascii?Q?9xa86vCZNiLMmZo9wVj6vTDz/jbuf/4yAmLQa7B9rUlLFTYgAacCLzxKn3iJ?=
 =?us-ascii?Q?nEQ5HKk9xJRjv3npLh0ibXnjB69c3txlebRlzH895rylRzAasHJw/JwvcaBp?=
 =?us-ascii?Q?iVnevgrXyraTP0xnIbi8T477AxZa0yGKIF79qZhCr6cmWZFt6QuXMHGO+IAI?=
 =?us-ascii?Q?DpNlyDi0RSRYnkctVB5XfOpaaYDMRwe3oKik98f7zD9iFQesJTEgNmVTURPu?=
 =?us-ascii?Q?Y458D0M8RTPYkatXInZ/MKVZ5FheGz+S3J5QZK/NcQasTNxpDk/nven09wJm?=
 =?us-ascii?Q?UJJGMnqw4dJtjCXaVDf2jhKC2ZBF9cTzJbTGPxqONJJ+/cnD7vk4ruBkjPre?=
 =?us-ascii?Q?mzqm4Rhd9ptYfsoQGWItX2jckdL9pbUmrEh4MInNCKl2uvw9hdkBXelx9y5V?=
 =?us-ascii?Q?33QdJPdSKUh6Rch3/PCgpbal+tOpUr9QvNHxVDH/9jj/OX32pTwbf2UVMvs/?=
 =?us-ascii?Q?b2yJseYk86sW0NTzvlXvIWN90FiYYXpz9gXaUnwPHzsXdpTM8vGK5Z5o8CS1?=
 =?us-ascii?Q?+WH/JPtv7bD1X2q/DKRBAwLgjs7BvbKkx8Og8+EMPOo38gbI0iXT/AM7RiVD?=
 =?us-ascii?Q?2I6YAtQ+p43c82t8Kt4enF4Bv2HZvNt7JMFbgom84mZNpB263bQnCa11onr+?=
 =?us-ascii?Q?FpqNcIblu5WEOZhjlzVC2Vo2/HGDkhhf/5ba63vn5JpaMQRKim6lDrawy5vI?=
 =?us-ascii?Q?m05oHD4wTH5toXI43dFuB6FMmIaAulKIZBN0PS5xIC/PadpRDPJubdR3xyWS?=
 =?us-ascii?Q?YcseIPdGEslW+xFzFX41TEA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 864a3aa0-85ea-4e02-2298-08d9eba79321
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:38:41.1998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dlffmw/HPr7FuEgmK+1B0AcAuQQlV28g1hNxUedtkY2CagCop4cowcwNypgWdfmgdxcqp7LHOfalm6AfBsJT+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/platform/qcom/venus/vdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index 91da3f5..941a904
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -435,7 +435,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
 		return -EINVAL;
 
 	fps = (u64)USEC_PER_SEC;
-	do_div(fps, us_per_frame);
+	div64_u64(fps, us_per_frame);
 
 	inst->fps = fps;
 	inst->timeperframe = *timeperframe;
-- 
2.7.4