Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] pwm: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:39:58 -0800
Message-Id: <1644395998-4397-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hzMaF4fK+XMLq3hRqzZPZE23MDd/2x5Qd7MalRQ6CnG+7UiJRAE6qfFx173c?=
 =?us-ascii?Q?/uMSHDB15eoyfq6FGtH3qbWUUj6GpzXy/dbIai4J3u9zWnbh1OeBdMV58ejj?=
 =?us-ascii?Q?7jqCmx8061var7E20J2L6+R83bCq2++rJWe8UvDMFhvlb4SbpPylMbHFisjW?=
 =?us-ascii?Q?f+5cPnkob/OS17UYvsFtpyp88PIR0E+CUR6mT8YcHU5BSyYIY8hlgktcC7eN?=
 =?us-ascii?Q?JwF0WZUeYSaXPwDT27vLK12oFfJmbprWSbZY5VenWz/2oJXQZjuEwIFf8xBj?=
 =?us-ascii?Q?6kdjOF54J4UrTH5D3mNUNhND71mNOfQPeT4fqyvnW7u1QV/1aYDw+I+Z6Edb?=
 =?us-ascii?Q?YgmkTJqHn1a6yD2ohzhyQQVUohg9Flg/Z+wuEQR9PBjQy/WzwcTWnbM/TPJo?=
 =?us-ascii?Q?2qqyHnw7XROsfsyIzVhdw7fMRzxXttjdfBIcCrMmOxJW0aMGHzTHoqOsmhen?=
 =?us-ascii?Q?ihKeNYJChh4b7adXaOGdkWHJfgK/bSXvkm9MPO1jvxcLUY7gjuBCrd4asB2V?=
 =?us-ascii?Q?PQ6Oba1ufdZTs8yn2ZFZ/KTBjnWShgJPxjxbBHAb7Vi8TqvdpvIJI6lqiA+2?=
 =?us-ascii?Q?l2ZDDwryC54W3L6i7QYRPvOvZRSb13qnV1ja0A7zVmq5V2eAdHF2pfvmXiaQ?=
 =?us-ascii?Q?VrduR/InHPqVgZ74TPXuvm+bXmAGnWZdvTLQgU1y8ZMaOTFYLTu2iuLsR2nW?=
 =?us-ascii?Q?YEN5RNzGr4HfT1e3jRvcWnshs36uos6uJQZsQGj+RxAjMB0Uzw7Rp2qdt6YU?=
 =?us-ascii?Q?qGJuSydnKvJuzce1KnSzxNsRbi7fd3b5hB0ia+2V+F6NB/ngEXRXq2M97o71?=
 =?us-ascii?Q?+OEMUSwpnr/naZzK0KaN87njarWeTI8Zvy7kB/JMWAqhXVBrohdmeABFx7iy?=
 =?us-ascii?Q?MdKPcn2fHLp0o8Ofb1O9DluQgXfE+bn1oaKnVDWZqD1EmKu8BEW0EWgptJKf?=
 =?us-ascii?Q?KQPu9ptW6pTTAf/0WEfJ7ccu03hsrNVlyAVjvKqYkkRHK8Sn9LY1khFnriM2?=
 =?us-ascii?Q?Khf87dIW2uGmh1KjFdQ2YQkb7voZQDi90aV8fSCbzrhGGU9yP4sSM5e4s4gG?=
 =?us-ascii?Q?zeJZL+E178OK0LNpjWYH6qHLvXPtK+yolpqkGBQUoCUnMaNANPqFqNjs6Nc1?=
 =?us-ascii?Q?lKVLHRUVh/doeDGcHuIMQlOUDwrw8Lvd7mMKJg+O+k748WTMfrcIGAyRikLE?=
 =?us-ascii?Q?sSzZapixLR2WeIxoE1QcafAhmqAA/e1DZlPlDKEwhk2OupZxr29Rb3/jNvkq?=
 =?us-ascii?Q?s6oIJ9iYo5ZJqeehXHfzknk4JDeZi/uU+3UK4frTYImoRjkjpodDNPY8zwXc?=
 =?us-ascii?Q?VOVDi631t1nFy1ZTP1KYgg0Cw8WzHgWwrnjg6gDmTI5CdyQy1yoe2yM+muR2?=
 =?us-ascii?Q?vlyVhn5ZCSTDRt2PlLj+oGgMwyRFhxIYbUw7dASDghabE00f3VlOO9jQ78Md?=
 =?us-ascii?Q?zmeRdoSr0QfqLUcbBBk7ERbFBibHuFnIve02ik4wqIOPnHW0nwxxE7KlhZ1s?=
 =?us-ascii?Q?7u/fUGYU5L4zp60cdnUuUefzgdzWU2T+z6SAb7n9JFAOtZDQS8ijcjHEYE4p?=
 =?us-ascii?Q?UFFdDeqa37uoHEXfj+QcyHNo1FUu3pKwTfIRgTgHevsrWfl0sAzJnsmN2Sux?=
 =?us-ascii?Q?affyzC+qgoGKS+acDq/Qtio=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97fd855a-4559-4c01-b6fa-08d9eba7c512
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:40:04.9758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K01pyWttu94RtQwAwwZykmc7r2NCYhUJz+98eIKMqWrA054Ntd+J5zfSgCppsgwUkUqkRx+QZRnGkwTqbWXUrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4387
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/pwm/pwm-berlin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c
index e157273..15b10cb3
--- a/drivers/pwm/pwm-berlin.c
+++ b/drivers/pwm/pwm-berlin.c
@@ -109,7 +109,7 @@ static int berlin_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 
 	period = cycles;
 	cycles *= duty_ns;
-	do_div(cycles, period_ns);
+	div64_u64(cycles, period_ns);
 	duty = cycles;
 
 	value = berlin_pwm_readl(bpc, pwm->hwpwm, BERLIN_PWM_CONTROL);
-- 
2.7.4