Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Qing Wang <wangqing@vivo.com>
To:     Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] gpu: drm: msm: use div64_u64() instead of do_div()
Date:   Wed,  9 Feb 2022 00:37:17 -0800
Message-Id: <1644395837-3845-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p7bICybPQ806gzeBzsIlC5jH2n9rQ+WJTE7a+KMHJiKXr9trv23w1EzrvNG7?=
 =?us-ascii?Q?fMttR4t+QM/DHKDg7W5cikzRqJKXhFL+p3WsegqEN7PrroC5Hv9TE491AXtW?=
 =?us-ascii?Q?DoMhv5b+NOjROa7ERfJ0+6h7OPQjrPwE1HfinkALnOpytJw/857A5npkKpKR?=
 =?us-ascii?Q?oxyqoyWsqsNSxOAbQl9qy1LVmYljIq9pG/AhHG1T0X+W6/yAWP4b6wtF1Fdx?=
 =?us-ascii?Q?viF7t9rFQfCV5/lMDU44o52CXnxhFmTa0CxHniMVtt1YgBtRWEyakhV7k/RA?=
 =?us-ascii?Q?91hmo4PGA/KvuFUWWNxXGHE+BsizUapjrcg9aAGaVc2sKY5DS85+asP3fkoz?=
 =?us-ascii?Q?Zga+25QVSnoxrhb3kKyThBm5SxT5QWN15SblPCLTbMnawIKZz1eiqUPZX5I+?=
 =?us-ascii?Q?4JKxh9chLAktc5ROJIFKkJ5dVtq5fbnJUjDl8vWuh1SvepN+EdnWoS4SLr50?=
 =?us-ascii?Q?IHyhArSf+v4/o1Szscld3UhAa9lYrxautkBmEZuhRRwQ3Q/Gw+uqO8SlWRG2?=
 =?us-ascii?Q?jhjB7kn5Ut9nZFzSmdRzGOHZV0nehzyLGNOqYVYX5JV8hmnVOJ/VK3qflu7y?=
 =?us-ascii?Q?luzaOwoiRT2bBhBZpU0BuBqQpLeovpHXbu5v4V0sn9Ioh8PcCh3dUy21N6Dq?=
 =?us-ascii?Q?9s8C0iJ29NVXk2XhVscURi5BbUDMvBU1od0W1Lh2s+Q6kfSZCTEtebEmQuPK?=
 =?us-ascii?Q?8UaOJk82Ikrd5rBBH5S9aAFdvrJ1O94L38J/VuqTUb9mvKR1OgMPE887WlLL?=
 =?us-ascii?Q?WCT2FmduDs4C27w5bWviXvJ6SxfpLPDT76+Wk42uRVhVTS4K6qhwVw4hhPXL?=
 =?us-ascii?Q?sWLCnReYxOkH8Oyz+waXL9DKvG5phvCCj0gOyv0iYskQ6XyQUYIj+ZE5rO+D?=
 =?us-ascii?Q?VuqOmFFsTuYSd5zOIb3Tp5eG3TXOeq8oJD9ttkbfcGdWSSLOoh8dKypFqxfq?=
 =?us-ascii?Q?s/lIMVcYEJ6OqHiwyL5W15rm4zKPpa5b8AIbu65bxBzUcLGPxlLS8O+6NhbJ?=
 =?us-ascii?Q?+u68yzoUFcjP+rMGBB7w8FrabSiu22hbRg180XnkeJ6QSH4imhtetj3QTZSV?=
 =?us-ascii?Q?1dFJWcHB1+GjqEnnB38lf/xUe9zLXsN3vTv2LuyLAcvQH2BBKCguCsLO1F6J?=
 =?us-ascii?Q?bRW9wTFWs6CtZeSOmISoFQ6Gngh2AxkK28IAn3G+kj/2BnNQVbRma5rIAA2r?=
 =?us-ascii?Q?cCC9gOjul7FA8wjd16ICQCwvH9cyrwnBUQZBWT/TApV/di97+OC98LkIYWx7?=
 =?us-ascii?Q?l90WukQCpHYnxeorUDpo38CAdsNFX9n8+m7/hyqsFUa4JHOR3JB7AmHYRdFr?=
 =?us-ascii?Q?owwIWE0LoUbnvJXxx1pcAtW0YRIixE2JilMKrOI++G5a3Hzf0//l1Rr3vQ69?=
 =?us-ascii?Q?kCHwTA9jrq57Dal5XU3xmQpftnkNLVfp5aUG5DUZgLKgW3SyzaZmWQxiswOV?=
 =?us-ascii?Q?lDJLtGUMKLCB+nkX+lrpDee4TIF87oxfe3zWeLUEXIglj0bhYvMdkYTypztq?=
 =?us-ascii?Q?WCDi5T7JAiM8PmEmG5iavHbF5Wy9/G8d+Ndadcly1upxglu2iGknQaOopY8y?=
 =?us-ascii?Q?g9WrkR76/aIWA4AQaZQTqFnqQC5fpyJMFCvMBdS1Z2Nzx50WO2XDbW7OrO9J?=
 =?us-ascii?Q?ZLS80N2Sg9T2juplfCBKugk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27d35d51-edd8-41be-a475-08d9eba765ea
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 08:37:25.3452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eDv6QqhTuxOIJ29k9+GlOwFPGrEE6Kb97/11tmvQjZPEVuyrtOAB0cML46OtwRc4IpejfIJ4m2bfTQ/t0yNGGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/msm/msm_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index 2c1049c..aa4617b
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -648,7 +648,7 @@ static void retire_submit(struct msm_gpu *gpu, struct msm_ringbuffer *ring,
 	/* Calculate the clock frequency from the number of CP cycles */
 	if (elapsed) {
 		clock = (stats->cpcycles_end - stats->cpcycles_start) * 1000;
-		do_div(clock, elapsed);
+		div64_u64(clock, elapsed);
 	}
 
 	trace_msm_gpu_submit_retired(submit, elapsed, clock,
-- 
2.7.4