Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: linux-kernel@vger.kernel.org,
 gregkh@linuxfoundation.org,
 corbet@lwn.net,
 linux-arm-kernel@lists.infradead.org,
 arnd@arndb.de
Message-ID: <195d35e3-dcea-e651-ff54-699c3019b6c6@xilinx.com>
Date:   Wed, 9 Feb 2022 10:27:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v5 1/3] firmware: xilinx: Add support for runtime features
Content-Language: en-US
To:     Ronak Jain <ronak.jain@xilinx.com>, <michal.simek@xilinx.com>,
        <linux-kernel@vger.kernel.org>
CC:     <gregkh@linuxfoundation.org>, <rajan.vaja@xilinx.com>,
        <corbet@lwn.net>, <linux-arm-kernel@lists.infradead.org>,
        <arnd@arndb.de>, <lakshmi.sai.krishna.potthuri@xilinx.com>
References: <20220209082709.32378-1-ronak.jain@xilinx.com>
 <20220209082709.32378-2-ronak.jain@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
In-Reply-To: <20220209082709.32378-2-ronak.jain@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 09:28:06.7223
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dc8420cd-90f3-4396-7b8d-08d9ebae7ae0
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT011.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB3501
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/9/22 09:27, Ronak Jain wrote:
> Add support for runtime features by using an IOCTL call. The features
>   can be enabled or disabled from the firmware as well as the features
>   can be configured at runtime by querying IOCTL_SET_FEATURE_CONFIG id.
>   Similarly, the user can get the configured values of features by
>   querying IOCTL_GET_FEATURE_CONFIG id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
> ---
> Changes in v5:
> - Resolved merge conflicts
> 
> Changes in v4:
> - Update commit message
> 
> Changes in v3:
> - Resolved merged conflict
> 
> Changes in v2:
> - Resolved merged conflict
> - Update commit message
> ---
>   drivers/firmware/xilinx/zynqmp.c     | 27 +++++++++++++++++++++++++++
>   include/linux/firmware/xlnx-zynqmp.h | 25 +++++++++++++++++++++++++
>   2 files changed, 52 insertions(+)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 450c5f6a1cbf..0fa6cae4969d 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1156,6 +1156,33 @@ int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype)
>   				   0, 0, NULL);
>   }
>   
> +/**
> + * zynqmp_pm_set_feature_config - PM call to request IOCTL for feature config
> + * @id:         The config ID of the feature to be configured
> + * @value:      The config value of the feature to be configured
> + *
> + * Return:      Returns 0 on success or error value on failure.
> + */
> +int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value)
> +{
> +	return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_SET_FEATURE_CONFIG,
> +				   id, value, NULL);
> +}
> +
> +/**
> + * zynqmp_pm_get_feature_config - PM call to get value of configured feature
> + * @id:         The config id of the feature to be queried
> + * @payload:    Returned value array
> + *
> + * Return:      Returns 0 on success or error value on failure.
> + */
> +int zynqmp_pm_get_feature_config(enum pm_feature_config_id id,
> +				 u32 *payload)
> +{
> +	return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_GET_FEATURE_CONFIG,
> +				   id, 0, payload);
> +}
> +
>   /**
>    * struct zynqmp_pm_shutdown_scope - Struct for shutdown scope
>    * @subtype:	Shutdown subtype
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 907cb01890cf..cf557fbeb8c7 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -143,6 +143,9 @@ enum pm_ioctl_id {
>   	IOCTL_OSPI_MUX_SELECT = 21,
>   	/* Register SGI to ATF */
>   	IOCTL_REGISTER_SGI = 25,
> +	/* Runtime feature configuration */
> +	IOCTL_SET_FEATURE_CONFIG = 26,
> +	IOCTL_GET_FEATURE_CONFIG = 27,
>   };
>   
>   enum pm_query_id {
> @@ -376,6 +379,14 @@ enum ospi_mux_select_type {
>   	PM_OSPI_MUX_SEL_LINEAR = 1,
>   };
>   
> +enum pm_feature_config_id {
> +	PM_FEATURE_INVALID = 0,
> +	PM_FEATURE_OVERTEMP_STATUS = 1,
> +	PM_FEATURE_OVERTEMP_VALUE = 2,
> +	PM_FEATURE_EXTWDT_STATUS = 3,
> +	PM_FEATURE_EXTWDT_VALUE = 4,
> +};
> +
>   /**
>    * struct zynqmp_pm_query_data - PM query data
>    * @qid:	query ID
> @@ -447,6 +458,8 @@ int zynqmp_pm_load_pdi(const u32 src, const u64 address);
>   int zynqmp_pm_register_notifier(const u32 node, const u32 event,
>   				const u32 wake, const u32 enable);
>   int zynqmp_pm_feature(const u32 api_id);
> +int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value);
> +int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 *payload);
>   #else
>   static inline int zynqmp_pm_get_api_version(u32 *version)
>   {
> @@ -689,6 +702,18 @@ static inline int zynqmp_pm_feature(const u32 api_id)
>   {
>   	return -ENODEV;
>   }
> +
> +static inline int zynqmp_pm_set_feature_config(enum pm_feature_config_id id,
> +					       u32 value)
> +{
> +	return -ENODEV;
> +}
> +
> +static inline int zynqmp_pm_get_feature_config(enum pm_feature_config_id id,
> +					       u32 *payload)
> +{
> +	return -ENODEV;
> +}
>   #endif
>   
>   #endif /* __FIRMWARE_ZYNQMP_H__ */


Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal