Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220207084912.9309-1-cai.huoqing@linux.dev>
In-Reply-To: <20220207084912.9309-1-cai.huoqing@linux.dev>
From:   Joel Stanley <joel@jms.id.au>
Date:   Mon, 7 Feb 2022 09:25:42 +0000
Message-ID: <CACPK8Xcs-qsO5COcSPZBsShhJWtDwfhreuYfkBy1pLXh8nz3Ow@mail.gmail.com>
Subject: Re: [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Gabriel Somlo <gsomlo@gmail.com>,
        Cai Huoqing <caihuoqing@baidu.com>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 7 Feb 2022 at 08:49, Cai Huoqing <cai.huoqing@linux.dev> wrote:
>
> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
>
> Fixes: 464a57281f29 ("net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()")

That looks wrong...

$ git show --oneline --stat  464a57281f29
464a57281f29 net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()
 drivers/net/ethernet/litex/litex_liteeth.c                 |  7 ++-----
 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 21
+++------------------
 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c |  7 +------
 drivers/net/ethernet/ni/nixge.c

That's a strange commit message for the litex driver. Similarly for
the ni driver. Did something go wrong there?

A better fixes line would be ee7da21ac4c3be1f618b6358e0a38739a5d1773e,
as the original driver addition also has the iomem dependency.

> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
>  drivers/net/ethernet/litex/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> index f99adbf26ab4..04345b929d8e 100644
> --- a/drivers/net/ethernet/litex/Kconfig
> +++ b/drivers/net/ethernet/litex/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_LITEX
>
>  config LITEX_LITEETH
>         tristate "LiteX Ethernet support"
> -       depends on OF
> +       depends on OF && HAS_IOMEM
>         help
>           If you wish to compile a kernel for hardware with a LiteX LiteEth
>           device then you should answer Y to this.
> --
> 2.25.1
>