Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1846670pxb; Wed, 9 Feb 2022 05:52:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwk0EPTG2Cukt6YlB/eMUsV8OsXkulDD4AssSWNbiHWYJSxDfE1RIIg7o7sS+lqaZO0CV3A X-Received: by 2002:a05:6a00:852:: with SMTP id q18mr2519243pfk.74.1644414747580; Wed, 09 Feb 2022 05:52:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644414747; cv=none; d=google.com; s=arc-20160816; b=CA3QSliFzSGYUNVUK7umU4XWjjN6sqUP/Xib0z0HKsl/HYUYnoJaFf31v6/8Rd8syQ CHZadI43ywoCjfS3gFu/QqPwW9WQ1VOYdV6gu5nlhfMcrQ0L7D3qnnNd3L2w5acepy90 2D2ZSlzYPpTsSeuEqQHIc/ZJk45DrZSPYPTvCTIOAlKdICC6c4xQYRQcvRtbKXx2IJM0 EWoJv6b1QNU5lkDeYId/shYq1evhb+mN1BgA+4/k0eCy/GBFEC2n4Nici7NT3QKlJ0r7 IqPlrm9tHCTyMbmKvsmwWsY10PJssy9v6ZRX3p9G1Fnayf0Z3nfs76Z+a0UCaNIjtg1H NnLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=XpQU7MwvnnmzkAtetNTBKBwEhnc+PKqXnl8IukTROIA=; b=GGSFK64vSjNaQZQAUyzq7kr8hqEMVhedro9cQlu4yRmyc3PdYYqKyzDF3CodG2HGN5 sidKUIxI0K6CGPulMuwdAK2seF1NuVpxDWDKyHhN/0WVu+YjBb5GpGYtWqXHH2aylkx6 KMqakTeQJ9q5pc64o3e7sXXsBEvAHjwgT4gB4HrmnnwU6RrG0fiZWxXgYFNYGTK71B3f gfiLuJdySWDZAHZGRmYH8+KBYPjtyF14UuFI+mMoxIp+OERvyzcgiwFTH8m0nZ5uUHsZ U4FB16aD/21rr2bESm/qTK57kGryzY/6fFaOhbrLUkrPmRk4NoJXRnH3YzSd43T/tMeR NytQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IhXDd7OG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q85si15083833pgq.656.2022.02.09.05.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 05:52:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IhXDd7OG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ABB77E03920A; Wed, 9 Feb 2022 02:32:26 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241038AbiBIIWS (ORCPT + 99 others); Wed, 9 Feb 2022 03:22:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239620AbiBIIWP (ORCPT ); Wed, 9 Feb 2022 03:22:15 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE58FC0613CA; Wed, 9 Feb 2022 00:22:18 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id cf2so3439909edb.9; Wed, 09 Feb 2022 00:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XpQU7MwvnnmzkAtetNTBKBwEhnc+PKqXnl8IukTROIA=; b=IhXDd7OGarp3eySx5bkZfw12VJDhaOaz7OC5hMX1/gqGa7Kv64i/UfuFWYOZ646SMC +COGlUX3M8SLh5qgaI138hDe5mHFI1ah2h7Ya68sA5Q7NyR5UNd88Cq+eFVzeZ0Of76Q N79j63SOMOlONqN/c5Vnjih/sDEW67NcDoHTdj80hEUuU977wg/Ju+LaEfTp+Nh/xPIg gXvQUAdJ15BHg5TDeROrmqmxo6PYPCBvlKC+wU5FTqSMf6SlivQeu9IoTBM6O9QBFqjB TaFiiZFMvdRL6qTgtEccmtyHtpgbNJKnaQw8U76C9RzU7NLskUOUdEI0p0ZrQRJ9NLkj JrlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XpQU7MwvnnmzkAtetNTBKBwEhnc+PKqXnl8IukTROIA=; b=Xo1cvAVoyQKP1xn+cpPf88o6c5ifycUQo0Po2d7iDa2Nq7wyMVd250hqGw650Nu7mK /5rvODwiBCvg3dTaQsxaZdKNjbNOvrKk1UM9CayrIqRHg3qF7urtXJTHVw2s8iEzuOX0 5CaBdq2zfYABChPZh/W5Gk5oLFOJkotoclKvTCN73VYP6HbjHvuJWgu+grMVuKMwUpPR ARxDwFjtzvx84I6LI3xYmgwmhQ5eq5tML4vax31rm5N/WM6gywbeUhHQ6292Y4UGP5Tx V/J42exdSYKfwGXGHGQ9KuzxXZan4xMVE0oRdbX20KlINYMHL2CTUXYdXcK9Zl8Y7mrK 8JxA== X-Gm-Message-State: AOAM530RByrFXYgmBF0zvH4+iaSh8JTp/UVtCJu+z40yHGeTO3fkLrBH eRnUGhXpuSiVYOtZjmAn1LUiYC0FljnVSl0/rac= X-Received: by 2002:a05:6402:4254:: with SMTP id g20mr1242666edb.281.1644394936606; Wed, 09 Feb 2022 00:22:16 -0800 (PST) MIME-Version: 1.0 References: <96f0e23f49d708ce2476a6c19867443a48d78f65.1644283006.git.yang.guang5@zte.com.cn> In-Reply-To: <96f0e23f49d708ce2476a6c19867443a48d78f65.1644283006.git.yang.guang5@zte.com.cn> From: Andy Shevchenko Date: Wed, 9 Feb 2022 10:21:40 +0200 Message-ID: Subject: Re: [PATCH] serial: 8259: replace snprintf with sysfs_emit To: davidcomponentone@gmail.com Cc: Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , "open list:SERIAL DRIVERS" , linux-arm Mailing List , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Linux Kernel Mailing List , Zeal Robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 9, 2022 at 9:24 AM wrote: > > From: Yang Guang > > coccinelle report: > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: > WARNING: use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. Subject should start with "serial: 8250_aspeed_vuart: " > Reported-by: Zeal Robot > Signed-off-by: Yang Guang > Signed-off-by: David Yang Who is the author(s)? -- With Best Regards, Andy Shevchenko