Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Claudiu Manoil <claudiu.manoil@nxp.com>
To:     Po Liu <po.liu@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tim.gardner@canonical.com" <tim.gardner@canonical.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Subject: RE: [v1,net-next 1/3] net:enetc: allocate CBD ring data memory using
 DMA coherent methods
Thread-Topic: [v1,net-next 1/3] net:enetc: allocate CBD ring data memory using
 DMA coherent methods
Thread-Index: AQHYHXjwDD6u9tqMqEactPGiVOG/iqyK43JA
Date:   Wed, 9 Feb 2022 08:31:19 +0000
Message-ID: <AM9PR04MB8397047CA8818F0E9B113007962E9@AM9PR04MB8397.eurprd04.prod.outlook.com>
References: <20220209054929.10266-1-po.liu@nxp.com>
In-Reply-To: <20220209054929.10266-1-po.liu@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LsW7g338OwFDM0ZwHLpSNhDkVsURluYkFppw+j2b/4jj4CX7GKj8Zs5TNExm?=
 =?us-ascii?Q?FDaPxPldiOiEfQ2F/KOE5QlzuTbCkGNgcb95ubDcDcafPwToIBK04MALSPia?=
 =?us-ascii?Q?3zkOFptocEq6S25kdG0rdkJw72b2hkIjNK5pyniKuVGwB58n+o9uCL9qdipu?=
 =?us-ascii?Q?+WWoAE4yQtJMWW0yLXQW/PKrz3BbfcK8U6/7nPunViI2zGB2WfdAhixN++4I?=
 =?us-ascii?Q?seNKWfMNYSWh0n8Cg410epYB7LuGgetNFJAH01S1QthUf+EpyKX2J8KlSz49?=
 =?us-ascii?Q?nizxQZPT2tgr30lIRWjVx1WRJ0kwgoYviuRDsoWTCMGHxHOPCVm9QCqdloPc?=
 =?us-ascii?Q?1F2PpjMQPo8fpHw0zOA6HsMWepcq7fVvT0s+B8jBTrRL3RIuYtikZDHKtnnd?=
 =?us-ascii?Q?V+lecWgiftMDGvW2BTnTzUHwHjyUetRWmOjQ3w9OIcwhsESr9S089ux/F8ZC?=
 =?us-ascii?Q?gadODnuXnoPtF9lFrpZL7TciYktaJXMN04eDDqPxM8WArg3Q1msPxpI7maoe?=
 =?us-ascii?Q?v99PX7qqUqF1/rnrh6glibFtcGB2dI8r0T8aysvusUiy7NjLdj/5t3C7aYOH?=
 =?us-ascii?Q?37PdpJsCnNKazTSmeL4ppkg/WCTendLm7bPTj5USjOalVSIrmwZ+MewRzgDJ?=
 =?us-ascii?Q?Xaagnf9nxCp045u790BVesDWILspGCS4W1mRx+Tv3z70xl4UtkA/oLKtBJs5?=
 =?us-ascii?Q?/3Fai+VMCG5av/hiYCP4/ss+qrgGfSv2s/SEg+sMnOqQY5GC27o0MKQcO0mt?=
 =?us-ascii?Q?HnGMqFJrFVOmbmKQ6qoJX+JQo564imUQQA4u6fjAdeL4UipwBFvnSdtvFENr?=
 =?us-ascii?Q?dh0gqSFIKKVxvm0tlSJP0rYG2tR+c749sSORVgjDRtCLrUM3Dc7Z97NNmxzt?=
 =?us-ascii?Q?gNkcmLcmZ+0kxakwTclMFzjbUwwbYerhNXplCgDHQcv5TgzDGyiJFDWTTuNE?=
 =?us-ascii?Q?T7MEJ9ffGhqDjddxle4VLovbK2QXBdou+J1d3k0siS5Vn5HqRZkmCFT4KOz+?=
 =?us-ascii?Q?5lKEZny2RjQVU/5s2a64Yxmf7DEPOw5D4LlxIjtv1bkRZEbZ4Qx3JUrdfLuU?=
 =?us-ascii?Q?ICjWnUHOYcFNZZyz/LaezaaDg1CVzcl3TGRMNZbvPmuoGNICLeOHyqBi+FN+?=
 =?us-ascii?Q?fdmyU8ewa+R6Pri1EUaixD3r/eOjRoZiz075SB83oS2ey9kKfBDi/yu8by+V?=
 =?us-ascii?Q?6L83QAs9sreHBJO3V8+AKkUYt3skrJYoervI+wTRnuQtu757XOwxzYscJ+u6?=
 =?us-ascii?Q?YQm1UDJfRQCwTB6ERXOZXA9Bx8z4bUM4/0vATSBSqoVR94mrDSIiI/iPWT9g?=
 =?us-ascii?Q?dc9auFYrrttencE1iGSuxosT7JflbQs6ci1jDpHUtT6wuUBmwcy9RBfC3amx?=
 =?us-ascii?Q?Ijco6s+zjie3Gs4nKBNFsaXKhkn8IgaOQxYWDNI45JDup7Q2MIFYxUkQHn3h?=
 =?us-ascii?Q?+bRXLlloZRAzKkxeyWeniwq9dUabCr56gpTRX19ouhcaCDPdy+i2irihYEhK?=
 =?us-ascii?Q?Q23HtjPWvFz6SfZB2BteYIRhugNYidK4TKGVrdgrcYfp0Vu/ECarcspflER9?=
 =?us-ascii?Q?Pfa2Mz75dEbhgr5ri/JhASj5HSJdrWtHK2crw83/V0ioEbjuchxaPqJWVheE?=
 =?us-ascii?Q?ow=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8397.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2364385-2dde-4ea6-ed3a-08d9eba68c4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 08:31:19.9987
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fD/mP5UO6ZstJdaf+P2/9XzA6tlW1f4PbVgjYM8Qz2Ex6YbreHVNJPwwh8hI3BNxtb8wEXi9gCLJuKYb3KWlSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7438
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Po Liu <po.liu@nxp.com>
[...]
> Subject: [v1,net-next 1/3] net:enetc: allocate CBD ring data memory using
> DMA coherent methods
>=20
> To replace the dma_map_single() stream DMA mapping with DMA coherent
> method dma_alloc_coherent() which is more simple.
>=20
> dma_map_single() found by Tim Gardner not proper. Suggested by Claudiu
> Manoil and Jakub Kicinski to use dma_alloc_coherent(). Discussion at:
>=20
> https://lore.kernel.org/netdev/AM9PR04MB8397F300DECD3C44D2EBD07796
> BD9@AM9PR04MB8397.eurprd04.prod.outlook.com/t/
>=20
> Fixes: 888ae5a3952ba ("net: enetc: add tc flower psfp offload driver")
> cc: Claudiu Manoil <claudiu.manoil@nxp.com>
> Reported-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Po Liu <po.liu@nxp.com>

Thanks, Po.

Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>